From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 942] i40e: condition in `i40e_flow_parse_fdir_pattern()` is always false
Date: Tue, 01 Mar 2022 06:59:18 +0000 [thread overview]
Message-ID: <bug-942-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=942
Bug ID: 942
Summary: i40e: condition in `i40e_flow_parse_fdir_pattern()` is
always false
Product: DPDK
Version: 21.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: Stepan.Repin@infotecs.ru
Target Milestone: ---
`i40e_flow.c` contains the following code processing `RTE_FLOW_ITEM_TYPE_ETH`
in the function
`i40e_flow_parse_fdir_pattern()` [1]:
if (eth_spec && eth_mask && next_type == RTE_FLOW_ITEM_TYPE_END) {
...
if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ...) {
...
}
}
Clearly, that condition in the inner "if" is always "false". Before commit
ea0c22fd [2] outer "if" was:
if (eth_spec && eth_mask && eth_mask->type) { ...
Please clarify, is there really an error?
[1]: http://git.dpdk.org/dpdk/tree/drivers/net/i40e/i40e_flow.c#n2448
[2]:
http://git.dpdk.org/dpdk/commit/drivers/net/i40e?id=ea0c22fd8227a3ac3507984ff766d66355a3651e
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2022-03-01 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 6:59 bugzilla [this message]
2024-04-02 2:26 ` [DPDK/ethdev Bug " bugzilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-942-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).