From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5ED5DA0032; Tue, 15 Mar 2022 21:02:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BCB340395; Tue, 15 Mar 2022 21:01:59 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 71F5B4014F for ; Tue, 15 Mar 2022 21:01:57 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 3FB62A0093; Tue, 15 Mar 2022 21:01:57 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 958] Most drivers are silently ignoring 'has_vlan' rte_flow match criteria Date: Tue, 15 Mar 2022 20:01:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 21.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: i.maximets@ovn.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org https://bugs.dpdk.org/show_bug.cgi?id=3D958 Bug ID: 958 Summary: Most drivers are silently ignoring 'has_vlan' rte_flow match criteria Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: i.maximets@ovn.org Target Milestone: --- VLAN presence attribute 'has_vlan' in the 'struct rte_flow_item_eth' was introduced by commit: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items") However, AFAICT, to the date, only 2 drivers actually supports that attribu= te. These are mlx5 and sfc. All other drivers (i40e, bnxt, ...) are not checking 'has_vlan' at all. Since the attribute is not checked by the drivers, it's not possible to identify if the particular driver supports it or not. Driver will just accept the structure in most cases and validation will pass. Documentation at https://doc.dpdk.org/guides/nics/overview.html says that most of the drivers supports 'eth' rte_flow item, but that is clearly wrong, since they doesn't support 'has_vlan' flag. All of them, except for mlx5 and sfc should be marked as partial support (P). This problem makes the 'has_vlan' attribute practically unusable by any application, e.g. OVS, which is not designed to work with a particular driver, but needs to support a large variety of different hardware. >From the OVS perspective, we seem to need the 'has_vlan' functionality in order to fix the vlan matching bug, but we can not use it, because that will introduce a lot of issues with drivers that silently ignore this flow attribute: https://patchwork.ozlabs.org/project/openvswitch/list/?series=3D284866 On a side note, rte_flow_item_eth.{src, dst} was supposed to be removed in 21.11 release (according to the deprecation notice), but these fields are still in the structure and most drivers are still using them. --=20 You are receiving this mail because: You are the assignee for the bug.=