From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45A02A0505; Wed, 23 Mar 2022 14:51:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8E24427F6; Wed, 23 Mar 2022 14:51:42 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id E47CF41140 for ; Wed, 23 Mar 2022 14:51:41 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id C6896A0506; Wed, 23 Mar 2022 14:51:41 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 975] Power DOWN of copper interface not working in e1000 driver Date: Wed, 23 Mar 2022 13:51:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 22.03 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tobias.karlsson@netscout.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org https://bugs.dpdk.org/show_bug.cgi?id=3D975 Bug ID: 975 Summary: Power DOWN of copper interface not working in e1000 driver Product: DPDK Version: 22.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: tobias.karlsson@netscout.com Target Milestone: --- A bug crept in via commit 44dddd14059f151f39f7e075b887decfc9a10f11 In function e1000_power_down_phy_copper_base() in file drivers/net/e1000/base/e1000_base.c The following change is needed or the interface will not be brought down properly: - if (phy->ops.check_reset_block(hw)) + if (phy->ops.check_reset_block(hw) =3D=3D E1000_SUCCESS) e1000_power_down_phy_copper(hw); Please also update the comment above these code lines. --=20 You are receiving this mail because: You are the assignee for the bug.=