From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54296A04FF; Thu, 24 Mar 2022 16:08:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F501410FC; Thu, 24 Mar 2022 16:08:31 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id D2B2A40683 for ; Thu, 24 Mar 2022 16:08:29 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 868F1A0503; Thu, 24 Mar 2022 16:08:29 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 979] hash: invalid shift expression in rte_thash Date: Thu, 24 Mar 2022 15:08:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: vhost/virtio X-Bugzilla-Version: 21.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: david.marchand@redhat.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: vladimir.medvedkin@intel.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org https://bugs.dpdk.org/show_bug.cgi?id=3D979 Bug ID: 979 Summary: hash: invalid shift expression in rte_thash Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: vhost/virtio Assignee: vladimir.medvedkin@intel.com Reporter: david.marchand@redhat.com CC: dev@dpdk.org Target Milestone: --- This has been reported by covscan in our internal CI for v21.11: 2. dpdk-21.11/lib/hash/rte_thash.c:116: assignment: Assigning: "j" =3D "0". 4. dpdk-21.11/lib/hash/rte_thash.c:118: large_shift: In expression "(uint16_t)rss_key[(i + 1) % size] >> 8 - j", right shifting "rss_key[(i + = 1) % size]" by more than 7 bits always yields zero. The shift amount, "8 - j", i= s 8. # 116| for (j =3D 0; j < 8; j++) { # 117| left_part =3D rss_key[i] << j; # 118|-> right_part =3D (uint16_t)(rss_key[(i + 1) % size]) >> # 119| (8 - j); # 120| m[i * 8 + j] =3D left_part|right_part; --=20 You are receiving this mail because: You are on the CC list for the bug.=