From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 981] vhost: avoid sleeping under mutex
Date: Fri, 25 Mar 2022 09:03:08 +0000 [thread overview]
Message-ID: <bug-981-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=981
Bug ID: 981
Summary: vhost: avoid sleeping under mutex
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: vhost/virtio
Assignee: dev@dpdk.org
Reporter: david.marchand@redhat.com
Target Milestone: ---
Reported by covscan:
2. dpdk-21.11/lib/vhost/socket.c:852: lock_acquire: Calling function
"pthread_mutex_lock" acquires lock "vhost_user.mutex".
23. dpdk-21.11/lib/vhost/socket.c:955: sleep: Call to
"vhost_user_reconnect_init" might sleep while holding lock "vhost_user.mutex".
# 953| vsocket->reconnect = !(flags &
RTE_VHOST_USER_NO_RECONNECT);
# 954| if (vsocket->reconnect && reconn_tid == 0) {
# 955|-> if (vhost_user_reconnect_init() != 0)
# 956| goto out_mutex;
# 957| }
The reason for this warning is that creating a ctrl thread might end up with
sleep() calls.
Maybe creating the ctrl thread could be moved early (out of the mutex).
Plus, comparing (pthread_t) reconn_tid against 0 is ugly.
Fixing this bz would be a good time to clean this too.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2022-03-25 9:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-981-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).