From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E04F9A00C3; Fri, 25 Mar 2022 12:13:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97AD040687; Fri, 25 Mar 2022 12:13:13 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id B05C140140 for ; Fri, 25 Mar 2022 12:13:12 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 87F91A00C4; Fri, 25 Mar 2022 12:13:12 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 982] [dpdk-20.11.5-rc1] ieee1588/ieee1588_enable: ninja build failed with support RTE_LIBRTE_IEEE1588 Date: Fri, 25 Mar 2022 11:13:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: meson X-Bugzilla-Version: 20.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: linglix.chen@intel.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org https://bugs.dpdk.org/show_bug.cgi?id=3D982 Bug ID: 982 Summary: [dpdk-20.11.5-rc1] ieee1588/ieee1588_enable: ninja build failed with support RTE_LIBRTE_IEEE1588 Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: meson Assignee: dev@dpdk.org Reporter: linglix.chen@intel.com Target Milestone: --- dpdk-20.11.5-rc1: 576842a59ab35979dc102535f59061fa3d6ea16b Reproduce Step: 1.CC=3Dgcc meson -Denable_kmods=3DTrue -Dlibdir=3Dlib -Dc_args=3D-DRTE_LIBR= TE_IEEE1588 --default-library=3Dstatic x86_64-native-linuxapp-gcc 2.ninja -C x86_64-native-linuxapp-gcc Expect results: Build passed Actual results: ninja: build stopped: subcommand failed. ninja: Entering directory `x86_64-native-linuxapp-gcc' [866/2458] Compiling C object drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_rxtx.c.o FAILED: drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_rxtx.c.o gcc -Idrivers/libtmp_rte_net_dpaa2.a.p -Idrivers -I../drivers -Idrivers/net/dpaa2 -I../drivers/net/dpaa2 -I../drivers/net/dpaa2/base -I../drivers/net/dpaa2/mc -Ilib/librte_ethdev -I../lib/librte_ethdev -I. -I= .. -Iconfig -I../config -Ilib/librte_eal/include -I../lib/librte_eal/include -Ilib/librte_eal/linux/include -I../lib/librte_eal/linux/include -Ilib/librte_eal/x86/include -I../lib/librte_eal/x86/include -Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics -Ilib/librte_telemetry -I../lib/librte_telemetry -Ilib/librte_net -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring -I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter -Idrivers/bus/pci -I../drivers/bus= /pci -I../drivers/bus/pci/linux -Ilib/librte_pci -I../lib/librte_pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Idrivers/mempool/dpaa2 -I../drivers/mempool/dpaa2 -Idrivers/bus/fslmc -I../drivers/bus/fslmc -I../drivers/bus/fslmc/mc -I../drivers/bus/fslmc/qbman/include -I../drivers/bus/fslmc/portal -Idrivers/common/dpaax -I../drivers/common/dp= aax -I../drivers/common/dpaax/caamflib -Ilib/librte_eventdev -I../lib/librte_eventdev -Ilib/librte_hash -I../lib/librte_hash -Ilib/librte_rcu -I../lib/librte_rcu -Ilib/librte_timer -I../lib/librte_tim= er -Ilib/librte_cryptodev -I../lib/librte_cryptodev -fdiagnostics-color=3Dalwa= ys -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -O3 -include rte_config.h -Wex= tra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initiali= zers -D_GNU_SOURCE -fPIC -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERN= AL_API -Wno-format-truncation -MD -MQ drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_rxtx.c.o -MF drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_rxtx.c.o.d -o drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_rxtx.c.o -c ../drivers/net/dpaa2/dpaa2_rxtx.c ../drivers/net/dpaa2/dpaa2_rxtx.c: In function =E2=80=98dpaa2_dev_rx=E2=80= =99: ../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: error: =E2=80=98priv=E2=80=99 unde= clared (first use in this function); did you mean =E2=80=98ldiv=E2=80=99? priv->rx_timestamp =3D ^~~~ ldiv ../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: note: each undeclared identifier is reported only once for each function it appears in [963/2458] Compiling C object lib/librte_pipeline.a.p/librte_pipeline_rte_table_action.c.o ninja: build stopped: subcommand failed. Is this issue a regression: Y Version the regression was introduced: Specify git id if known. First bad commit: 1d10966a22caf15f3b61e986becbeccdb2f03b33 (HEAD) Author: Vanshika Shukla Date: Mon Jan 3 15:31:19 2022 +0530 net/dpaa2: fix timestamping for IEEE1588 [ upstream commit 90762e5cb8154bb437618f81488ac92a24455521 ] The current implementation of DPAA2 driver code is such that it records Rx and Tx timestamp for PTP without checking if they are PTP packets or not. Packets for which RTE_MBUF_F_RX_IEEE1588_TMST and RTE_MBUF_F_TX_IEEE1588_TMST is not set, Rx and Tx timestamp should not be recorded. This patch fixes this issue by checking if the required flags are set in the mbuf before recording timestamps. Also this change defines separate values for DPAA2_TX_CONF_ENABLE and DPAA2_NO_PREFETCH_RX Fixes: e806bf878c17 ("net/dpaa2: support timestamp") Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --=20 You are receiving this mail because: You are the assignee for the bug.=