From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1D4C424C1; Mon, 10 Jun 2024 16:35:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B237402A9; Mon, 10 Jun 2024 16:35:37 +0200 (CEST) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 907ED40294 for ; Mon, 10 Jun 2024 16:35:35 +0200 (CEST) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-35f225ac23bso1111858f8f.0 for ; Mon, 10 Jun 2024 07:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1718030135; x=1718634935; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1sduno+YJLl2gpNWP1E6gpRZUu5DvhpWMeKoLHX+g2o=; b=Q8xmcDwGXrQ0sa4HsOQR1UBapx1g22P7uIpsKc58eiiK77Z7W5DSXxuLrrJc6GXOcV qaEHg/uXqM/md4QoFpM0icjyzKFSTzl2x/ng84dql4WkStUTh1MT5LqUB7tEWsGCHHZg 96EoXJGhMxxpjUu0RWm7UH/VW951p+EAXiDn45BcnOwNhQJB+l/RGdcPV3zL+/vzpuDu wCMPfmXLuScQISmndP7ZKOOxikqYbh6uormWr9QM1aixQjpSwvjDBDpwTKP848ljCO1U b9NUMx9YU3Jr4ObegmHLjdIFxeSOQe1y57otQsGLms2vZ9v/yx8r8ta/rSf++Cco55z/ 0g5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718030135; x=1718634935; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1sduno+YJLl2gpNWP1E6gpRZUu5DvhpWMeKoLHX+g2o=; b=VCQ1oudGDpy2cTN+UFrJvm/zOfL01bhIkMhSbQIfXJTHPureVENe4Y1FP0gYlebQp4 ydmOGobcDx5J+OVuuZbrpIOXiltVYSPXiL1eBEbzl0PqjzRtgHiK5yU2yCiVaqSwvlOG 0OT6TpAW3J0Yz5JKdTaEiBDmXNJSmt/+btFDWSCmJ4ScczHZrHf9VN0GXGtty3Ogynd+ KIBnFhmxCAFeTRxZZg+r2egqJyRaV/OoBFBoKOhtsCf491xaqyfUTFx+j32vWwUCcV/U NpAfCqS6/0i7phgQ+09YHdhwPMX8CC9LnMzZE+CwY06v0hmxZEw2lOrlMVoDWmpS6Z8l JsZg== X-Forwarded-Encrypted: i=1; AJvYcCUN069sRrlL5TM+OsYPAesdpyN+8M4B9pDmvzVZ2kzmS0LZg/B1cnDwC9kEyGIM9b5sQ9FCenXJjzvw8K8= X-Gm-Message-State: AOJu0Yw7hLfY5GaQPZaroDw9Utxf+BHbAabjNGIvoBVCXTklOnEp8K2v dDYHhLClPjImm19VT4N1uA3sNfAeVW5FNXOmYMqQZcc83+xIiIA/Qz5R3ILak+E= X-Google-Smtp-Source: AGHT+IGUSueV8tPCS1fL3WwoDvCcKt29Q7Y312E9OsiPzbfulJrVWpnmQqriQv9QDx5y/Lp8NP60MA== X-Received: by 2002:a05:6000:e41:b0:35f:20f6:b47 with SMTP id ffacd0b85a97d-35f20f60c76mr3205701f8f.2.1718030134995; Mon, 10 Jun 2024 07:35:34 -0700 (PDT) Received: from [192.168.1.113] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f22607f38sm3600875f8f.13.2024.06.10.07.35.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 07:35:34 -0700 (PDT) Message-ID: Date: Mon, 10 Jun 2024 16:35:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] dts: add methods for modifying MTU to testpmd shell To: Jeremy Spewock , Luca Vizzarro Cc: paul.szczepanek@arm.com, wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, yoan.picchi@foss.arm.com, npratte@iol.unh.edu, thomas@monjalon.net, dev@dpdk.org References: <20240514201436.2496-1-jspewock@iol.unh.edu> <20240530163339.14566-1-jspewock@iol.unh.edu> <20240530163339.14566-4-jspewock@iol.unh.edu> <10406e58-8b37-4f5a-bcd9-c0a24922345a@arm.com> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 31. 5. 2024 23:08, Jeremy Spewock wrote: > On Fri, May 31, 2024 at 12:34 PM Luca Vizzarro wrote: >> >> Due to the nature of this patch the console is spammed with a lot of >> commands. Would it be better to log these in debug and instead log: >> Setting port X to MTU XXXX >> as INFO? > > Potentially, but this would require a global change for how logging > works when sending commands to interactive shells in general. They are > each logged as their own message since they are each individual > commands being sent into the shell which (in general) we do want to > log. I could maybe add an optional flag to the send command function > that logs its output to debug rather than info however which might be > a nicer solution. I agree that it does get cluttered. I think this would be suitable as a separate change; we should make a bugzilla ticket. It's likely better to move these to debug and let individual commands log as info the most important part if needed (either using a switch or a separate log call).