From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
Ori Kam <orika@nvidia.com>, Jan Viktorin <viktorin@cesnet.cz>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action
Date: Thu, 1 Jul 2021 18:11:50 +0300 [thread overview]
Message-ID: <c005e123-b751-3fa8-cf5e-435bbdf77f5a@oktetlabs.ru> (raw)
In-Reply-To: <f1db469f-9f16-7ee1-2546-f50d2e5e64d6@intel.com>
On 6/25/21 9:58 AM, Singh, Aman Deep wrote:
>
> On 6/23/2021 7:43 PM, Andrew Rybchenko wrote:
>> On 6/23/21 4:39 PM, Ori Kam wrote:
>>> Hi Jan,
>>>
>>>> -----Original Message-----
>>>> From: Jan Viktorin <viktorin@cesnet.cz>
>>>> Sent: Wednesday, June 23, 2021 12:18 PM
>>>>
>>>> The struct rte_flow_action was missing from DPDK API documentation.
>>>>
>>>> Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
>>>> ---
>>>> lib/ethdev/rte_flow.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>>> 961a5884fe..70f455d47d 100644
>>>> --- a/lib/ethdev/rte_flow.h
>>>> +++ b/lib/ethdev/rte_flow.h
>>>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m,
>>>> uint32_t v)
>>>> *RTE_FLOW_DYNF_METADATA(m) = v;
>>>> }
>>>>
>>>> -/*
>>>> +/**
>>>> * Definition of a single action.
>>>> *
>>>> * A list of actions is terminated by a END action.
>>>> --
>>>> 2.32.0
>>> Acked-by: Ori Kam <orika@nvidia.com>
>>> Thanks,
>>> Ori
>>>
>> Not that important, but it looks like a fix which should be
>> backported to stable branches as well.
>> Shouldn't "Fixes:" be added with Cc to stable?
>>
>> Andrew.
>
> Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
> Thanks,
> Aman
ethdev: fix doc comment for a single action struct
Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions")
Cc: stable@dpdk.org
Applied, thanks.
prev parent reply other threads:[~2021-07-01 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 9:18 Jan Viktorin
2021-06-23 13:39 ` Ori Kam
2021-06-23 14:13 ` Andrew Rybchenko
2021-06-25 6:58 ` Singh, Aman Deep
2021-07-01 15:11 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c005e123-b751-3fa8-cf5e-435bbdf77f5a@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viktorin@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).