From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0718EA0A0C; Thu, 1 Jul 2021 17:11:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADF8440141; Thu, 1 Jul 2021 17:11:51 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id B6D884003E for ; Thu, 1 Jul 2021 17:11:50 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 4AB447F529; Thu, 1 Jul 2021 18:11:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 4AB447F529 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625152310; bh=hOwQvK1I0vjXP185hhEDNC4/qaZu7WgTZjpewR9twA4=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=OA8mNEmsmUZJQE7mUPfj2ViSuJNkfC2NoaeqcTT+ewqIAJ40cjfEO+adlHzhCdCk8 VNvn/HCrfg2/rWBv2dsLSRtgqnWTmzb4SZRzmh3GKe7SVD7Tmrn2MdaOzQg4LOOD5s ATRPplueKxmCv2hlG7g8/CiF39cQkQqCqdAJEfvY= To: "Singh, Aman Deep" , Ori Kam , Jan Viktorin , "dev@dpdk.org" Cc: NBU-Contact-Thomas Monjalon , Ferruh Yigit References: <20210623091825.16269-1-viktorin@cesnet.cz> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 1 Jul 2021 18:11:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/25/21 9:58 AM, Singh, Aman Deep wrote: > > On 6/23/2021 7:43 PM, Andrew Rybchenko wrote: >> On 6/23/21 4:39 PM, Ori Kam wrote: >>> Hi Jan, >>> >>>> -----Original Message----- >>>> From: Jan Viktorin >>>> Sent: Wednesday, June 23, 2021 12:18 PM >>>> >>>> The struct rte_flow_action was missing from DPDK API documentation. >>>> >>>> Signed-off-by: Jan Viktorin >>>> --- >>>>   lib/ethdev/rte_flow.h | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index >>>> 961a5884fe..70f455d47d 100644 >>>> --- a/lib/ethdev/rte_flow.h >>>> +++ b/lib/ethdev/rte_flow.h >>>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m, >>>> uint32_t v) >>>>       *RTE_FLOW_DYNF_METADATA(m) = v; >>>>   } >>>> >>>> -/* >>>> +/** >>>>    * Definition of a single action. >>>>    * >>>>    * A list of actions is terminated by a END action. >>>> -- >>>> 2.32.0 >>> Acked-by: Ori Kam >>> Thanks, >>> Ori >>> >> Not that important, but it looks like a fix which should be >> backported to stable branches as well. >> Shouldn't "Fixes:" be added with Cc to stable? >> >> Andrew. > > Acked-by: Aman Deep Singh > Thanks, > Aman ethdev: fix doc comment for a single action struct Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions") Cc: stable@dpdk.org Applied, thanks.