* [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action
@ 2021-06-23 9:18 Jan Viktorin
2021-06-23 13:39 ` Ori Kam
0 siblings, 1 reply; 5+ messages in thread
From: Jan Viktorin @ 2021-06-23 9:18 UTC (permalink / raw)
To: dev
Cc: Jan Viktorin, Ori Kam, Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko
The struct rte_flow_action was missing from DPDK API documentation.
Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
---
lib/ethdev/rte_flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index 961a5884fe..70f455d47d 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m, uint32_t v)
*RTE_FLOW_DYNF_METADATA(m) = v;
}
-/*
+/**
* Definition of a single action.
*
* A list of actions is terminated by a END action.
--
2.32.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action
2021-06-23 9:18 [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action Jan Viktorin
@ 2021-06-23 13:39 ` Ori Kam
2021-06-23 14:13 ` Andrew Rybchenko
0 siblings, 1 reply; 5+ messages in thread
From: Ori Kam @ 2021-06-23 13:39 UTC (permalink / raw)
To: Jan Viktorin, dev
Cc: NBU-Contact-Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko
Hi Jan,
> -----Original Message-----
> From: Jan Viktorin <viktorin@cesnet.cz>
> Sent: Wednesday, June 23, 2021 12:18 PM
>
> The struct rte_flow_action was missing from DPDK API documentation.
>
> Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
> ---
> lib/ethdev/rte_flow.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
> 961a5884fe..70f455d47d 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m,
> uint32_t v)
> *RTE_FLOW_DYNF_METADATA(m) = v;
> }
>
> -/*
> +/**
> * Definition of a single action.
> *
> * A list of actions is terminated by a END action.
> --
> 2.32.0
Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action
2021-06-23 13:39 ` Ori Kam
@ 2021-06-23 14:13 ` Andrew Rybchenko
2021-06-25 6:58 ` Singh, Aman Deep
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Rybchenko @ 2021-06-23 14:13 UTC (permalink / raw)
To: Ori Kam, Jan Viktorin, dev; +Cc: NBU-Contact-Thomas Monjalon, Ferruh Yigit
On 6/23/21 4:39 PM, Ori Kam wrote:
> Hi Jan,
>
>> -----Original Message-----
>> From: Jan Viktorin <viktorin@cesnet.cz>
>> Sent: Wednesday, June 23, 2021 12:18 PM
>>
>> The struct rte_flow_action was missing from DPDK API documentation.
>>
>> Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
>> ---
>> lib/ethdev/rte_flow.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>> 961a5884fe..70f455d47d 100644
>> --- a/lib/ethdev/rte_flow.h
>> +++ b/lib/ethdev/rte_flow.h
>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m,
>> uint32_t v)
>> *RTE_FLOW_DYNF_METADATA(m) = v;
>> }
>>
>> -/*
>> +/**
>> * Definition of a single action.
>> *
>> * A list of actions is terminated by a END action.
>> --
>> 2.32.0
>
> Acked-by: Ori Kam <orika@nvidia.com>
> Thanks,
> Ori
>
Not that important, but it looks like a fix which should be
backported to stable branches as well.
Shouldn't "Fixes:" be added with Cc to stable?
Andrew.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action
2021-06-23 14:13 ` Andrew Rybchenko
@ 2021-06-25 6:58 ` Singh, Aman Deep
2021-07-01 15:11 ` Andrew Rybchenko
0 siblings, 1 reply; 5+ messages in thread
From: Singh, Aman Deep @ 2021-06-25 6:58 UTC (permalink / raw)
To: Andrew Rybchenko, Ori Kam, Jan Viktorin, dev
Cc: NBU-Contact-Thomas Monjalon, Ferruh Yigit
On 6/23/2021 7:43 PM, Andrew Rybchenko wrote:
> On 6/23/21 4:39 PM, Ori Kam wrote:
>> Hi Jan,
>>
>>> -----Original Message-----
>>> From: Jan Viktorin <viktorin@cesnet.cz>
>>> Sent: Wednesday, June 23, 2021 12:18 PM
>>>
>>> The struct rte_flow_action was missing from DPDK API documentation.
>>>
>>> Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
>>> ---
>>> lib/ethdev/rte_flow.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>> 961a5884fe..70f455d47d 100644
>>> --- a/lib/ethdev/rte_flow.h
>>> +++ b/lib/ethdev/rte_flow.h
>>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m,
>>> uint32_t v)
>>> *RTE_FLOW_DYNF_METADATA(m) = v;
>>> }
>>>
>>> -/*
>>> +/**
>>> * Definition of a single action.
>>> *
>>> * A list of actions is terminated by a END action.
>>> --
>>> 2.32.0
>> Acked-by: Ori Kam <orika@nvidia.com>
>> Thanks,
>> Ori
>>
> Not that important, but it looks like a fix which should be
> backported to stable branches as well.
> Shouldn't "Fixes:" be added with Cc to stable?
>
> Andrew.
Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
Thanks,
Aman
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action
2021-06-25 6:58 ` Singh, Aman Deep
@ 2021-07-01 15:11 ` Andrew Rybchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2021-07-01 15:11 UTC (permalink / raw)
To: Singh, Aman Deep, Ori Kam, Jan Viktorin, dev
Cc: NBU-Contact-Thomas Monjalon, Ferruh Yigit
On 6/25/21 9:58 AM, Singh, Aman Deep wrote:
>
> On 6/23/2021 7:43 PM, Andrew Rybchenko wrote:
>> On 6/23/21 4:39 PM, Ori Kam wrote:
>>> Hi Jan,
>>>
>>>> -----Original Message-----
>>>> From: Jan Viktorin <viktorin@cesnet.cz>
>>>> Sent: Wednesday, June 23, 2021 12:18 PM
>>>>
>>>> The struct rte_flow_action was missing from DPDK API documentation.
>>>>
>>>> Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
>>>> ---
>>>> lib/ethdev/rte_flow.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>>> 961a5884fe..70f455d47d 100644
>>>> --- a/lib/ethdev/rte_flow.h
>>>> +++ b/lib/ethdev/rte_flow.h
>>>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m,
>>>> uint32_t v)
>>>> *RTE_FLOW_DYNF_METADATA(m) = v;
>>>> }
>>>>
>>>> -/*
>>>> +/**
>>>> * Definition of a single action.
>>>> *
>>>> * A list of actions is terminated by a END action.
>>>> --
>>>> 2.32.0
>>> Acked-by: Ori Kam <orika@nvidia.com>
>>> Thanks,
>>> Ori
>>>
>> Not that important, but it looks like a fix which should be
>> backported to stable branches as well.
>> Shouldn't "Fixes:" be added with Cc to stable?
>>
>> Andrew.
>
> Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
> Thanks,
> Aman
ethdev: fix doc comment for a single action struct
Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions")
Cc: stable@dpdk.org
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-01 15:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 9:18 [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action Jan Viktorin
2021-06-23 13:39 ` Ori Kam
2021-06-23 14:13 ` Andrew Rybchenko
2021-06-25 6:58 ` Singh, Aman Deep
2021-07-01 15:11 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).