From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87D83A04B7; Wed, 14 Oct 2020 11:23:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 071081DD76; Wed, 14 Oct 2020 11:23:27 +0200 (CEST) Received: from dal2relay184.mxroute.com (dal2relay184.mxroute.com [64.40.26.184]) by dpdk.org (Postfix) with ESMTP id 87F951DD70 for ; Wed, 14 Oct 2020 11:23:24 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by dal2relay184.mxroute.com (ZoneMTA) with ESMTPSA id 175266bc814000f106.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 14 Oct 2020 09:23:19 +0000 X-Zone-Loop: 52bec2cdad85193ca40b7adce2248f337538350e74a6 X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 2D0736311E; Wed, 14 Oct 2020 09:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uslPi2FNu0nikGLHm1HC5RH8OOkfjq8oyTPYgfTWBSw=; b=cD1IJB5kp97e8GMpLHp/shKSaj 11rsefl8YUKTT2qxTXfa8bixj1yyyFwxYZK3MNYKe9z2jvWA9jAfiGPplKYyKN5+G+k+pZnPDan54 k1ooM5niG7GxUFLEHOdiBp9amyXTlPzzpNfKMlKVl6l73cgrmjMHMuL42YpY7Qx5cLPIFRodVevgu OOGESniKifeRMdY9vqPEZMQnqCkHgDPiFrdzobumKZyTrJW0cICiL7aN3woW+Du9kZ37ARat8t2Q/ f7DLf7JJdrfVWPs8y5p3fJQTz9clk2u9BAD9S36ttnL6tGGjs4uKkNrF9TPq07z5sak9FO0+PU3eA w+vulgYg==; To: "Ananyev, Konstantin" , David Marchand Cc: dev , Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" , "Medvedkin, Vladimir" , Thomas Monjalon , "Richardson, Bruce" References: <20200915165025.543-1-konstantin.ananyev@intel.com> <20201005184526.7465-1-konstantin.ananyev@intel.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Wed, 14 Oct 2020 10:23:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v3 00/14] acl: introduce AVX512 classify methods X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/10/2020 17:07, Ananyev, Konstantin wrote: > >> >> On Mon, Oct 5, 2020 at 9:44 PM Konstantin Ananyev >> wrote: >>> >>> These patch series introduce support of AVX512 specific classify >>> implementation for ACL library. >>> It adds two new algorithms: >>> - RTE_ACL_CLASSIFY_AVX512X16 - can process up to 16 flows in parallel. >>> It uses 256-bit width instructions/registers only >>> (to avoid frequency level change). >>> On my SKX box test-acl shows ~15-30% improvement >>> (depending on rule-set and input burst size) >>> when switching from AVX2 to AVX512X16 classify algorithms. >>> - RTE_ACL_CLASSIFY_AVX512X32 - can process up to 32 flows in parallel. >>> It uses 512-bit width instructions/registers and provides higher >>> performance then AVX512X16, but can cause frequency level change. >>> On my SKX box test-acl shows ~50-70% improvement >>> (depending on rule-set and input burst size) >>> when switching from AVX2 to AVX512X32 classify algorithms. >>> ICX and CLX testing showed similar level of speedup. >>> >>> Current AVX512 classify implementation is only supported on x86_64. >>> Note that this series introduce a formal ABI incompatibility >> >> The only API change I can see is in rte_acl_classify_alg() new error >> code but I don't think we need an announcement for this. >> As for ABI, we are breaking it in this release, so I see no pb. > > Cool, I just wanted to underline that patch #3: > https://patches.dpdk.org/patch/79786/ > is a formal ABI breakage. As David said, this is an ABI breaking release - so there is no requirement to maintain compatibility. https://doc.dpdk.org/guides/contributing/abi_policy.html However the following requirements remain:- * The acknowledgment of the maintainer of the component is mandatory, or if no maintainer is available for the component, the tree/sub-tree maintainer for that component must acknowledge the ABI change instead. * The acknowledgment of three members of the technical board, as delegates of the technical board acknowledging the need for the ABI change, is also mandatory. I guess you are the maintainer in this case, so that requirement is satisfied. > >> >> >>> with previous versions of ACL library. >>> >>> v2 -> v3: >>> Fix checkpatch warnings >>> Split AVX512 algorithm into two and deduplicate common code >> >> Patch 7 still references a RTE_MACHINE_CPUFLAG flag. >> Can you rework now that those flags have been dropped? >> > > Should be fixed in v4: > https://patches.dpdk.org/project/dpdk/list/?series=12721 > > One more thing to mention - this series has a dependency on Vladimir's patch: > https://patches.dpdk.org/patch/79310/ ("eal/x86: introduce AVX 512-bit type"), > so CI/travis would still report an error. > > Thanks > Konstantin >