From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD5B3A0553; Thu, 20 Oct 2022 16:45:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF85242D8A; Thu, 20 Oct 2022 16:45:58 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2080.outbound.protection.outlook.com [40.107.100.80]) by mails.dpdk.org (Postfix) with ESMTP id 785BC42D82 for ; Thu, 20 Oct 2022 16:45:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=coU7ZjewVAU3LYvt+vgRbtiSPt7QvLtjbwSsypi0K/6ssOqGtCTiUwl71uirMuj/0Q4NHkMQkEQgcKVPEONCzP0sJ3/RebTJLexEwi4Umd/1VgCeObu37AYvZEE0pzyGlS8lJRO4LIFlJscfLtT2YPp3tk3kGsiqWpHf8UdqJenUstLjbpwn92FLxZ3okPSd62itUzX1gUacE5sAeipa6TSVVU3XgOO59Lwn9y1xa4i58DaZUQZtadHPnuHhz8mLaEH+046BpN+iUyq9Qa2e2g/7d7+GYXQE72UyAnDOjmZ0j22uuTeVDv/REqaZ62pCsQTxNWUgk2K4dpQWLh1Kwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b0MQxWCERHjDo+WAw5vArHf7gtBYDRWhxG36EMGrBA4=; b=k3mDSLLCDimiikyAaQX6yWdKJlVRLr0lzd4/QmVgu21lkKdM223YtXkZveQxOGABV3r1NDp4hQCyj95s9R0P+0en37fqwxfVesre00HAeJ4ji4SK/7pgpshmyBSsxyFdVTUP3yTRrVMGKJBACfy9Ztc8h4/KNk54mA1OretdKzhsPKrqa74TKPxjSpJNZGq2sLMXciY/DL5M6SUIIvJgUWCWkRn0fKQvhaEyFTtthhSiAno5ElPVNqarbadar5fMGL2RHLVAuT1buuRVO18fPLHbgpsmUo81S0zfuIoRVhnQvRm2gGdMu/xb1JBKP/juVL81a6Z7nCfqh0+k+4JDsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b0MQxWCERHjDo+WAw5vArHf7gtBYDRWhxG36EMGrBA4=; b=S+wv/fyq9kq1FJFka8aedzuV2PFmuzEo7OtRgEiIp+t2J2TuT22a+mq50piE2Nh7IkbTNPlkErGENRFdE3iQxVaLjFRQRlY/7JzyWdZs91iwOyATP9Xkaf+tjCDdS65V2i7YYuAlmaMsuC6na+mJ1QnoRVSKtJQJtM/V22JIj2I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by CH0PR12MB5282.namprd12.prod.outlook.com (2603:10b6:610:d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct 2022 14:45:56 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 14:45:56 +0000 Message-ID: Date: Thu, 20 Oct 2022 15:45:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v6 6/8] net/gve: add support for dev info get and dev configure Content-Language: en-US To: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, stephen@networkplumber.org, chenbo.xia@intel.com, helin.zhang@intel.com References: <20221010101757.878317-2-junfeng.guo@intel.com> <20221020103656.1068036-1-junfeng.guo@intel.com> <20221020103656.1068036-7-junfeng.guo@intel.com> From: Ferruh Yigit In-Reply-To: <20221020103656.1068036-7-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0476.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::13) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|CH0PR12MB5282:EE_ X-MS-Office365-Filtering-Correlation-Id: da78d62e-892a-448d-ce5c-08dab2a9cada X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3XrUPJla4x+9FFhjQ9lSlEZxcA55nXt8f+zTjOO5Gc68V0OptvJUmiNyunzssh7mlIaN599z7E+uPWUEFnuxfeWY4tqCZehGfomXi+A8h2q2MnWB4uJmnaYpR6ezFywjKg47nUbPk6fp3cVwPNoo5zpjE1futBNP6xXoUeJX5XmCInCl01iQsCGe3vlmNDS3g6d+d0r4VkO9s35JUETx74NWdMkQkHLPL0JXMuJ/itYCXRIE2EOVDLuvkk8HgtFIz/fNBohOsdo/jgpu3ugZ8NBG68uWC0B7HhlGszDEdc6P952xcyiDGWusRDKAyguUfWfK56VAvJs0kAPWOtBqnc44yuqnmdj3DFYOjetWoetVTI7KkAJubk7DlyP4bmEe9dHxTzfxq9Z8wD4dBzxW1HuLJ4y+4gnm5axeTzkiB3SEjSV2Y44ZZZoRPxmCJ57OK8aT1dc2NJ49Lw1pRFF303KFLweR2xTiltA/C05UnTSGOXqSgXmXl8WbIf1MO0L2WrOGiAZhOjnlSgpVUrD1ZyCkbQPkJ4+sY8pVHzpZePdRg3q0OFIcd9demO/CNtnsEMPKUj8zZL3CkqoEJukZdMn8mMRlFNHfRpAWzxUK6c7juneAYZr9hpHE57QtUdLWe8p/bt7DPyUxvfcfVfTUpzXCv4KEI/i5Ar9Bk65734gtne5WpfEQ9v0i6s7FBvTqmfYdamX0qXUshgxqS0et1N/zvQ/OXa1Omy1IhJPFKloJJjo2ENYDxornNeW7HKoTjGkKWlcrVpl9KzJ5L/6VG2AFQ88MHgwZNlLqymzPjD8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(366004)(451199015)(31686004)(38100700002)(478600001)(6486002)(6666004)(6512007)(186003)(8936002)(316002)(41300700001)(83380400001)(53546011)(66946007)(86362001)(66556008)(31696002)(36756003)(8676002)(44832011)(2906002)(7416002)(2616005)(6506007)(26005)(5660300002)(4326008)(66476007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHFWQXkrcmhQWDVWeWEwbHJ3b2gwTm1ZYjZDdVVJOEE3Nk5SL2lMSCtqZDBq?= =?utf-8?B?ZUNxUXljSjZndkh6VGwvaTZDbDRlYUsyTjg1UXluUlUydTlIUis2UStkTmpM?= =?utf-8?B?OTFTSkFtV0VEZ1dtV1l2WFhJVnBPeXdFcnh2ODlvdGtsc3J0KzNjRGc4ZDlR?= =?utf-8?B?ZURrR2Y2Z2gxaThFNm5vZ2RRZGJCMXZkR0c0UnBCajI0UWx4eEppZm8wOHRQ?= =?utf-8?B?NGZCbDRSOVIwN3VyYzd5aDlocmdaQWs4REd5WHdra0lSWWIwZkFQZ1FkbTBQ?= =?utf-8?B?azZyMyttSTQxc3Z1WWVMM1R1dFhYVVcxbmVDNVFQVmhpRk9jeFVzQmFsaitv?= =?utf-8?B?NVhNZFFvKzAyenJCampLRGxzdHhGUnFGcGVuQWM1VzN0SG8vcndzWmdQOTJP?= =?utf-8?B?L3FGcWtLMzlXMklMei9YUngweDJwMXRENm80eCtuaWMwQXZiQ1dFSnJXM2o3?= =?utf-8?B?OFZ6cno4dm1hbmVJejhmdmpZd2w3VVRCM3ZWUXRtOGd2MW9ZY1Y5WFUrcStM?= =?utf-8?B?NDlpSWY4b1ZpWXF0aHg5ZXY1a0lqOFdFZXVvRUp3c0pJdG0rTWc5eWdyNHpC?= =?utf-8?B?MXFSbXZFRWgvU0lFMStMU0dZeGlkQWpFczFZR3JmMXUwY2xhczc2d1Mwb1Fy?= =?utf-8?B?QTN4Szl3eDJwMmlUSVlnNjc4cGJHeWZTVHgzZFMrS0h0RVdrbjh1R0lFd3da?= =?utf-8?B?Znh3NjlUalp3UXZuK0loVkZGL0MwcEVsenJ1c1gwamZFWXFBSzBWMXZlNDdk?= =?utf-8?B?cEdNdmhvOGhKK1djKzVkbWozSmhEaWFBRlpkaGtoNUR3MWRUYng0WFBuMUNh?= =?utf-8?B?bE15Qm9JTWRHK3F0MFJibWdvcDVINmYxbHZUM3FVamNiVmttZ0RnTDVjMTU4?= =?utf-8?B?ZWNwU3h2b09hUC8rcXpCeFhaZ2hnNWNuU3prZEN4THZhbkhqSVZrNHF4ZGdZ?= =?utf-8?B?dTJXdFp6bFByc1VzUzNlakd4UHlGVHEyaENudTcvQko3Skl5eDJNZ2FIU05a?= =?utf-8?B?NWpPb2UvYzNHRlpaU0orZG5XRm84eXFJYzJRWFR2ZzJRMnZ1L1kyckZ1N1dq?= =?utf-8?B?MjBlNUphYVpFOE9uMkl1TUNLM0pEZ25vTSt4bEd6bVBSYi91dnVHbXBubER4?= =?utf-8?B?V2RlWm91WUJ1Z1hNaEUyVW9YcHpPT1NKenJWek01Z3o4d25tbGsyS2NzQjdi?= =?utf-8?B?U3JSRWpteUVtWnNnMDhZNWJoTDNPbkxzd1RGQ1Z0ekRROGl5R0tmZ2JDdzBU?= =?utf-8?B?NFRtZWdsQkdHUWlZN3NmNHhSM2loR1BSdVlsNzNXc1E0V0x6UkFNeElIRXpz?= =?utf-8?B?Ri9BRnBXdk1zR2FGNEtGMWpyVWxMYy9LK3BQUmxPcHJiUDltWlp0cFBTdGU2?= =?utf-8?B?bzhxazVSSE1YTnhlTnc0N2V6b2hhMjFwTXRqNjFtNG8zdjNkOW45L1dpSk9L?= =?utf-8?B?NEY3V01PT0pUaVlmK0JUUGRsQ2hKMHVGa3VXSXd6eFFZUUxXa3haWGljbUpS?= =?utf-8?B?SHdoOHJNN1FRMHJGN1RpMEhRdUw5aFYrZFRSQWF5eGhWWmVIclhMZGRVK284?= =?utf-8?B?Y3hoeG5tdVl1cDF3SjdZOHNOUkZ6eHlnVlNtU3dzZ2N5YTVKeFNFVHQyN1N2?= =?utf-8?B?QThMMUEwcTJNSTBNekdjWjQvV1ppUHR4djVRNjhwMDY1OXdpT25lWi9iRmhE?= =?utf-8?B?KzVRcWZIL1FBN2dLN2VOQmJkUG9Tb2VKcFFDK3FhRlFkcTJrUmdxK25tOUV0?= =?utf-8?B?dmwrNEZIWnhZVmh6TXpWd0VyK2tha3YvblVqNFM1QzNwcnE1aWJTczJld2xO?= =?utf-8?B?dCtaajFCUFMrSjE2NlRQcnhaK1BJa1VSMTBpU3RyVkFocjk4K3hlMnhPSzVq?= =?utf-8?B?d09ZNkpzWTJ2RmMzWTkvZjZscHJSc0JrNWNwbHp4VllFdFg0UEhXNXBuQzVs?= =?utf-8?B?Y2VnV3VaSXE2NW9HZVMrc2YvWnM3eUtwNDMyV0NaaGlsMjhGbHJKZ1F0ZTNU?= =?utf-8?B?RSswNEcyV2RmNDlhNXZXV2MyejU3M3BlOWZtalBwd2hmWHZPR1FmZDJqbDFq?= =?utf-8?B?L0kzRGx3a0RHMEF5Zi83YmN6ZGgvOUo2RS9CYjVldWwzM0diTnplN2RQaFpm?= =?utf-8?Q?uUR2hIZPoRcO/2Ibt+Sm/qZNL?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: da78d62e-892a-448d-ce5c-08dab2a9cada X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 14:45:56.0461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ht89pNTHusSJ9aZyN56C31MEsXojHHco0YfsvgoBE8V2FK0JARcdZoskdLdt3Mcn X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5282 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/20/2022 11:36 AM, Junfeng Guo wrote: > > Add dev_ops dev_infos_get. > Complete dev_configure with RX offloads configuration. > > Signed-off-by: Xiaoyun Li > Signed-off-by: Junfeng Guo > --- > doc/guides/nics/features/gve.ini | 2 ++ > doc/guides/nics/gve.rst | 1 + > drivers/net/gve/gve_ethdev.c | 56 +++++++++++++++++++++++++++++++- > 3 files changed, 58 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/features/gve.ini > index d1703d8dab..986df7f94a 100644 > --- a/doc/guides/nics/features/gve.ini > +++ b/doc/guides/nics/features/gve.ini > @@ -4,8 +4,10 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Speed capabilities = Y > Link status = Y > MTU update = Y > +RSS hash = Y I think this was added because of 'RTE_ETH_RX_OFFLOAD_RSS_HASH', it is OK to keep this feature if you add force enabling above offload, otherwise please remove the feature. > Linux = Y > x86-32 = Y > x86-64 = Y > diff --git a/doc/guides/nics/gve.rst b/doc/guides/nics/gve.rst > index c42ff23841..8c09a5a7fa 100644 > --- a/doc/guides/nics/gve.rst > +++ b/doc/guides/nics/gve.rst > @@ -62,6 +62,7 @@ In this release, the GVE PMD provides the basic functionality of packet > reception and transmission. > Supported features of the GVE PMD are: > > +- Receiver Side Scaling (RSS) I am not sure if driver can claim this, I can see a RSS hash is provided but is it possible to update which hash function to use or update key or RETA table to configure which queue packets goes? Right now what is RSS calculated on? Perpaps RSS support can be documented as limited? And not sure if this update belongs this patch, it should be to the one that has the datapath.