From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Michał Krawczyk" <mk@semihalf.com>
Cc: Marcin Wojtas <mw@semihalf.com>,
Shai Brandes <shaibran@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ena: remove useless address check
Date: Mon, 11 Oct 2021 16:49:47 +0100 [thread overview]
Message-ID: <c0237fab-800c-8889-4430-93812c8b252d@intel.com> (raw)
In-Reply-To: <CAJMMOfONUE19e_0-TcEAMx63qLe=FpM7xjCTO_i7EF_vagMaMw@mail.gmail.com>
On 10/11/2021 7:49 AM, Michał Krawczyk wrote:
> pon., 4 paź 2021 o 19:27 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>>
>> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>>
>> ./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’:
>> ./drivers/net/ena/ena_rss.c:140:66:
>> error: the comparison will always evaluate as ‘false’ for the
>> pointer operand in ‘reta_conf + 136’ must not be NULL
>> [-Werror=address]
>> 140 | (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL)))
>> | ^~
>>
>> Fixing it by removing useless check.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Michal Krawczyk <mk@semihalf.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-10-11 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 17:27 Ferruh Yigit
2021-10-11 6:49 ` Michał Krawczyk
2021-10-11 15:49 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0237fab-800c-8889-4430-93812c8b252d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=igorch@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=shaibran@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).