From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 707D6A034F; Mon, 11 Oct 2021 17:50:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F381410DA; Mon, 11 Oct 2021 17:50:57 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 7624740E50 for ; Mon, 11 Oct 2021 17:50:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="313099197" X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="313099197" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 08:49:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="625540244" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 11 Oct 2021 08:49:57 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 08:49:57 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 08:49:57 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 08:49:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4F/4Dpodz4DG5P5r3blFRzLNEaRPlbSad0/oBVgQGJu6Mz0m43TV4ZKGzJ5W/tyndFfQ8bjL94fKsb2mUgaEIOakdm3yNVb/uxPKmtzHzCP0Wy7pV4zKxxl0mqgiY6KSmOPJXvFc6PpZl/e+pWJzlo06FFaeYm+kmXqxe9+bwvKykRr+TlYM6dmHtCG5fuOBKw06USZcMYyF67Vf7OXarHQh/JDo99XZnnxH3aXdetf220rrV3Kz5qESbCUM4Go6CBrh+7ucxOxSfQC0nDxbmV72FVmk5HcXBnaln6PQ55fjUEzVIJVSKtjgw6B7iLzlbEtQZcEc/7eAaS65pjeAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E7P8qzdkqaIyhUJYNPzdN4uvTwFxS/S7N6wM0iY9z5Q=; b=I2mmAF4mjMI+jnfFeORWDdzLuXP5IlZCd3XoCXjy/BKi2ARg/jaHBGboiZzB8AtMl4S8o4UNISMdrW36W9Q0TqA1JUl2U/6iRMlz8UW40xDhb5GkqabMhSZrjic3K7K18mxu5Nuj6/WqgtEHGQFVE7AoP7FbUwSsZ6XD58u3WchymaKxmpitwX25NLdCi0oRkskX5QILUWDXFB9x3gpss1oSVGmIgqO1cbgd7eYly+G+Sx4UPn3p/r0BWO1pj37TN2B9NvICYUDsqle+ADlSBoYIThc96SEJxXz7hO1DOzvaJmSIDOeo89M33jIduj0n0N6ZzzTSNvuawiTfeRW/6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E7P8qzdkqaIyhUJYNPzdN4uvTwFxS/S7N6wM0iY9z5Q=; b=o5z2gpq8Cc7vlwhr9Mf1QcQkquP6dCtJSdhcOdNGwrzA/RS8s0GbLHAVn6oJG+q+bqgo9Pu8ftNwXdoqF8viLTMplD9xjL6HX1q1/nAR9HGWNcjn2xGnmJvzQ2zghmPxmkrYiTqyXMnSHV8/zr2fkZyMtl1j9G9GmwGPQGBXB7s= Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5902.namprd11.prod.outlook.com (2603:10b6:510:14d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct 2021 15:49:54 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 15:49:54 +0000 Message-ID: Date: Mon, 11 Oct 2021 16:49:47 +0100 Content-Language: en-US To: =?UTF-8?Q?Micha=c5=82_Krawczyk?= CC: Marcin Wojtas , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , dev References: <20211004172702.3461360-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB7PR03CA0105.eurprd03.prod.outlook.com (2603:10a6:10:72::46) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR03CA0105.eurprd03.prod.outlook.com (2603:10a6:10:72::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Mon, 11 Oct 2021 15:49:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 411598b5-97ba-4029-8475-08d98ccec4a4 X-MS-TrafficTypeDiagnostic: PH0PR11MB5902: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:398; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Am174DC10PX2ZYToXfr0eJ1fVxKAsnkAlJhONDsM0EyV00qDi8QcWCCBmxzoijvJ3EPpnwP3wAHogpUc/7Ykwz9djCMqhtDERAAYiqt0ygqU1NgtSddkf639QVoo2wQBaRdDQN0iFisaWVJ5ioZFCH45PIBEKGPPIeHAwpIx02PUvBxpNRXOUzzE8obiFaLXt+jkxfPwTO1bjDGYRVJB7pEUBpkYpWTVv7gfi4MVHTDFLlNhUq3Q0rqjKDlZdQ/teJMbHuvpj5/nMWNsaiLOq6pRyRj5Aed2XYxGG9IQjs1GH4f/EE1Ap4FGDWZK0VcPnplfBCIww3OmSJ72YMidhr6VRYhRTdEkTwZrVmA77XlMu6T+7FIs3+B5CIn6FfwoP63n6p7wU3dwDsMqZk5wurS8Coy43Hoj/XXG3sAF7Nqn5ZTy4W1CnpmHvsSvAbxLqp/bzhBHxVyFm3xB8tWhmBmtuemTkgzbYpODNPAuomCMQwpfAHQqFK9Ishn2SHySZIsWOvDtciGUcAtcZyvHfdu1Cgzxw906KV6CKnm5B7s+3hke+ZrvEZ+SrrbFJLMAD4eUDP5Cc3Mp9iMuagzPRZfz2uhlvlLje542g2Pmgjz/q7YMfIA1S4+4RY550vY4toHhPGs+ij5VqCWbLL67UTo4WOcbHJYm0dCrgMVxNh/+ZrDNkXuGCS/FvgqG4OgiazzSpSommhzIeI8VcZlZ4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(36756003)(2906002)(6486002)(6916009)(38100700002)(44832011)(16576012)(54906003)(316002)(5660300002)(31686004)(31696002)(508600001)(86362001)(8936002)(4744005)(4326008)(186003)(8676002)(956004)(53546011)(26005)(2616005)(6666004)(66946007)(66556008)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0NuR2M2YTV2bEFsY0Vhckc4S0FHNVIyT21SS2ZiNGhVS05MZ3R2dVJEUGRI?= =?utf-8?B?dWFiMElzSnFEeUFxdTJtZitPZFZvMEVNVXpRaGYrTlJkeDVVZzB0NlB1bnc2?= =?utf-8?B?d3V6YzVrUkIyNHpyKzdoSFd1VkpTZGxTZFBwcllHNTVVcmg0T1BDUzBMNEFI?= =?utf-8?B?V04wbU5sQUR1S3dVTmY3ZVRpNm04TVlQS1FBQXU4cElvRFByY1Vsa3BQdlh4?= =?utf-8?B?cTNhanB4R1RNYmdXUDRjb3JHYUw0RjgwUElnT1FHc1VITE44TjYzT2dGZFJu?= =?utf-8?B?QWE2QXlIbWp0TnRMcjM1a3J5OTNzSTkvaUhmYWpzUC9uMjhwNEh6enVOTHBy?= =?utf-8?B?bGNRQWM5bCtpeVFOeDVkdTU3a1lodUxsMWpIS3pTMlBXOW1yZzJKdGFLL0dV?= =?utf-8?B?SHJ6MkVLS3lsZUhNTC9NQTFYRXNYSXlyUDBPOVhDTnUvT01ZTXY3TDhTUmR3?= =?utf-8?B?NU5RbmYwSk42anNYc1NPTUUxdnlySTFyQXBONXBydkhyWGhUWU9tdEtMczVW?= =?utf-8?B?L1RVa2VYQUk0VTEyRHZxYkVFMXRtMWdNbEkvbWQ3WVN5NGpVeUZoa3B5S2hQ?= =?utf-8?B?WndhWE1XdDdlMG1XMEJnbzd1L2MyQ2N2ODh1dC8rcFBicjIzTlpNUzAxZU9u?= =?utf-8?B?VDd4RVBSWlQ4NmNWTDUvVDdBSWR3NDZIUDl6OENVd05QelpQU2Yvd3hseWhh?= =?utf-8?B?WUxFbGRaRktsa1BTSHBoTGE1cElXa281b1JNVDFLK2JxUElQTUt2MVdiN09W?= =?utf-8?B?dFpvMmt1RWR3ZlNJSUFuNjljWUdQNkJMWjVGQmxwKzR6R3o2enVBaG5rTVlE?= =?utf-8?B?NzVoNWtKY05HTyt4VzRNWHRxVzc2WHlOMWZFaExYanJUcUphL3QvdVhvYXE1?= =?utf-8?B?Wld0ZXpuazIwUTNmUkRRSlV4QkNaK2lBdk1kWFgzbDROaWxobEtCWjBmbzJ2?= =?utf-8?B?d2VrTk1YSjdWOEdyNC9WbDVzRUo3RXlVUTA5YlY5UmR5TjRIVHB2NlVyRTlG?= =?utf-8?B?WHZHeXE0am9yYjNMMDlwMmlpYkhDZlhicnJxZGovK1N1MXczQm41NjlLUG1U?= =?utf-8?B?cFpiNHFsajFLeFFIcU12UEVhVVpFbHJqQjZYRW53aVdrVjJsUTU4NStIeVNW?= =?utf-8?B?R2lvaEoyNkJudFZZV0tSMis0VXYvK3pOdUc0cjJEU0IwMkF4S0g4cEl1T2hG?= =?utf-8?B?ZmRCNWtOSW9XNEVzTWhwbyt5bEtpU09MNUtKR05rK1lrOG5oU1YwVStRMTZT?= =?utf-8?B?eXE5R0JHdVU1MHpxQXI2RDlNVXNva0xwYm55eVVwOElNMlVVN2hZY0pkaVJR?= =?utf-8?B?c1FPQVNJN1ZaNkI0ZkxDYkJwaC9GQ1FNY3RKdEVPSjBiWEpmSFdvbjM2ZnBt?= =?utf-8?B?NDZwWE1jbE1BRlF2RTV4bnpteWtaS0xUdWFyQS92S0NXTHpMNWRkWnpLb2NL?= =?utf-8?B?MytQa003OHMxWHFWMDFLczJibFVhU2FZZDRCcHdEY0FCT2VaK0UzeUpIdTBn?= =?utf-8?B?RlN3MlFqdHlhbEtLODdFcXo1MjdSdE55c0hWd25ZRzlZamJOeE1PYkwxNUhU?= =?utf-8?B?T1RqQUs5OS9yejhzV1hvYnRTK0xOelE0VCsxRWhDM3BnL0xYU0h0YThxRUxV?= =?utf-8?B?U0pGelRTbHpmc1BSRU9TenR6L1NLbTV3cHFwWmxIWmIvOHpkdmhaT3Vxbldt?= =?utf-8?B?elBoODN6MU5NL3VNUi9oMlBpVzNhRTRoZWFnU0xNSFFweUU0OWJ3bEcyT2Rl?= =?utf-8?Q?2aP9qNQIUpDR3Olh+eeueUs/HPx/a/h/gRE5ATk?= X-MS-Exchange-CrossTenant-Network-Message-Id: 411598b5-97ba-4029-8475-08d98ccec4a4 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:49:54.2721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OLfjPTJdQlPKUCeCeXa6fmlKO/954C1xLowr+ntuZPcrjTDhL50RVWmlBjUhBYI7ukZNwV+hFC6jpRf5Zs7JBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5902 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ena: remove useless address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/11/2021 7:49 AM, Michał Krawczyk wrote: > pon., 4 paź 2021 o 19:27 Ferruh Yigit napisał(a): >> >> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)": >> >> ./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’: >> ./drivers/net/ena/ena_rss.c:140:66: >> error: the comparison will always evaluate as ‘false’ for the >> pointer operand in ‘reta_conf + 136’ must not be NULL >> [-Werror=address] >> 140 | (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL))) >> | ^~ >> >> Fixing it by removing useless check. >> >> Signed-off-by: Ferruh Yigit > Acked-by: Michal Krawczyk > Applied to dpdk-next-net/main, thanks.