From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFA31A2EEB for ; Fri, 13 Sep 2019 15:24:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E585E1F040; Fri, 13 Sep 2019 15:24:58 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C6BBA1F03A; Fri, 13 Sep 2019 15:24:57 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06D518980FE; Fri, 13 Sep 2019 13:24:57 +0000 (UTC) Received: from [10.36.118.30] (unknown [10.36.118.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 903F760606; Fri, 13 Sep 2019 13:24:52 +0000 (UTC) To: Eelco Chaudron , Ye Xiaolong , stable@dpdk.org Cc: David Marchand , Beilei Xing , Qi Zhang , dev References: <8daee65a8edeae439ba9c2542877744b5be53684.1568284682.git.echaudro@redhat.com> <20190912124049.GA71525@intel.com> <0D62C8C6-EE28-401F-BE60-B388EADD70BC@redhat.com> From: Kevin Traynor Message-ID: Date: Fri, 13 Sep 2019 14:24:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <0D62C8C6-EE28-401F-BE60-B388EADD70BC@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Fri, 13 Sep 2019 13:24:57 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/09/2019 10:00, Eelco Chaudron wrote: > Forgot to include the stable alias to get this in 18.11, sorry Kevin > No problem, I'll take a note to backport it and add Fixes: ae19955e7c86 ("i40evf: support reporting PF reset") > //Eelco > > On 12 Sep 2019, at 14:40, Ye Xiaolong wrote: > >> On 09/12, David Marchand wrote: >>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron >>> wrote: >>>> >>>> When receiving the unsupported AQ messages, it's taken as an >>>> error. It's not appropriate and triggers too much unnecessary print. >>>> >>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade >>>> unnecessary error log") which made the same change for the PF >>>> instance. >>>> >>>> Signed-off-by: Eelco Chaudron >>>> --- >>>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c >>>> b/drivers/net/i40e/i40e_ethdev_vf.c >>>> index c77b30c54..7b1d485c6 100644 >>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c >>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c >>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev) >>>> } >>>> break; >>>> default: >>>> - PMD_DRV_LOG(ERR, "Request %u is not >>>> supported yet", >>>> + PMD_DRV_LOG(DEBUG, "Request %u is not >>>> supported yet", >>>> aq_opc); >>>> break; >>>> } >>>> -- >>>> 2.18.1 >>>> >>> >>> Reviewed-by: David Marchand >>> >>> >>> -- >>> David Marchand >> >> Reviewed-by: Xiaolong Ye >> >> Applied to dpdk-next-net-intel.