From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C8EFA04FD; Mon, 23 May 2022 20:09:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CD404067B; Mon, 23 May 2022 20:09:24 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2078.outbound.protection.outlook.com [40.107.101.78]) by mails.dpdk.org (Postfix) with ESMTP id EB5AD40156 for ; Mon, 23 May 2022 20:09:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9SeM0+sED4zRrqaDcW3hi2n+YKmKN6ynoLAgB9vHf0GgeC4fjgRj9xsCJNKEkgnLHxoP8qNJtkgL5XI06/ukrH4kpr65/ngYAouaLBzhCBg8+qN7MnQJzuksc8RnIxqKR2MJlQ6qmCJiryqgqcqqnBpHxq6ihdg54kxJgfolk/DUNddsk04o33iggZjtAAScwtPQlbwrKhYGcQa58zLzJLTtQ6unVbmS2ghEPXNCf6VfXHYN9BFy51oz8NoYCymwAm+lI5olqcNIIpLgiwSi2v077HFW0S/WOE4hNbtIvL1l/Nz4VfFMbpJ/88p1snbNhlSALUlfgu/mNxsZHwHOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvQFfWbGKNnaQeZ5Sm/5i4+eyyqo7FBbOBqBm+aa8C4=; b=hdbTOGcNJR63WKpVdG66+/Kk53TenrwPPO3y0XQT3VERDbfAJPaeJbvyqnOo9iYLfWz7mTliTXoQ0l5qOEd83w/7j0LUKCoAAUdAyRmb8ywkIhKT98oihEbSwVMtC1G51I81E4ovRO6YKNwnc34xH7631A+3aCEZLNHu0Cwar4IdTCJVZflrnt0cGOGaxaazKUeSvY9ZetTkklRgu+CBJJyi2c2dMNOYep7YiFDVDsRuuMHMTYJ7fWPdTIKH8ajo9dyrMM815jXT/jKpz6hIT3BKNJ70Yf3qP3r0+wEBpJ5BebglYNzZhwhBN18WOORyOsVJ0EEexLWCEROrtf6+8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FvQFfWbGKNnaQeZ5Sm/5i4+eyyqo7FBbOBqBm+aa8C4=; b=s9QDDtsPkOtvoSet39EbQVUaIn6T5+dbpSe7MVRmJiODRu1S4Exgg+UWPvBISA/H3qffTsIPdKkSVBPAspHbhFSrnMGbLlxMtYXStmkrbOJOdAJ+c3dZXsogZOFVlPX7uKyMxPo4hUqbrUUzh8/W0c6i/95x3SoFCXBbjqcXSA4= Received: from BN0PR02CA0051.namprd02.prod.outlook.com (2603:10b6:408:e5::26) by CO1PR02MB8692.namprd02.prod.outlook.com (2603:10b6:303:151::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Mon, 23 May 2022 18:09:20 +0000 Received: from BN1NAM02FT055.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e5:cafe::1b) by BN0PR02CA0051.outlook.office365.com (2603:10b6:408:e5::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Mon, 23 May 2022 18:09:19 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT055.mail.protection.outlook.com (10.13.2.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 18:09:19 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 23 May 2022 19:09:18 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 23 May 2022 19:09:18 +0100 Envelope-to: david.marchand@redhat.com, dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Received: from [10.71.119.126] (port=62622) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ntCUY-00042E-1u; Mon, 23 May 2022 19:09:18 +0100 Message-ID: Date: Mon, 23 May 2022 19:09:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 0/6] Split driver specific commands out of testpmd Content-Language: en-US To: David Marchand , CC: , References: <20220513075718.18674-1-david.marchand@redhat.com> <20220523071031.1868862-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20220523071031.1868862-1-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3137c883-30b9-4add-b40d-08da3ce75b8d X-MS-TrafficTypeDiagnostic: CO1PR02MB8692:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0PC+O4NaEGJsaDOy/VepH5hMmXhVAVkTQ/U7efmMGvY2I3LywCHrI9A1HiLcTMiKq6m7eStQqn1Ec5GFLn0VwH+EI8SVVO310MSDsshFLj9fnfmd+QwCintnfkaP04FemzQ3VCJ5j73YRVK3J0wTj0qBCxw/5dBOgXqA/DGO+jCfPdw4I4QchPm1330neLDBoROaNyoILPtpglJxyx+oxeO6QS4AnxsOFAxfQI3w9gGdPxQe5SsR/YS8Hq0bs/DDFWS9TlWkx6llf5ky/ZUDkelwbxA+v245Dxnrgedw93UadrYPeRtaA9K0/qRZR4Fy0UfttDz/UY7pzmJ0LqGFjpj4qptaCcWluAKS9ENjCyeRflkmME2YIX2jHhEr5BKZEnKPlWTqwhp5gk0+IFEwhbzRqP2rP72peO+xtf21wytE1c1fPw+vACqlRW/ZkYmNprVyvr+dx6Fbe1UV62hiLmZlu1GpjSljrIZb+oTwOn3emT/tdGpFXMDNY5dfrCODAUHAUhm1XGTg48xVSGYH+JTdEpDDv/fUn/3nq8gQ96i4L/4H47sBh9/ee/oAXWDDi06d6OKbDjeG39SlaCe7I5l9UKBZZY2NLqh9QdEQLdyoi7EH2HSTlVxM08mA71sBhBn31audaOjxw5vCvQN9AGULrN2MM5sJpRC83DOnTpAQgz39Z1BMgKtQtILB03JJS6CFPGoyKqUpiMCQYFrYkIu0G6X+TCoWawlN1P65Vnwa0vvlcy0mXBggLU6F0U4rydJOif1QKS4UnGhV8Xu6L2lYSz/zrwoN4i3MjAbNDcAWolKiThHsUuVdMnMZgfiWIrbSzG8Dgy5/SQJPheOj2Q== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(54906003)(316002)(4326008)(47076005)(8676002)(336012)(2906002)(70586007)(45080400002)(31686004)(82310400005)(36756003)(35950700001)(110136005)(70206006)(356005)(5660300002)(8936002)(7636003)(44832011)(40460700003)(53546011)(26005)(508600001)(2616005)(9786002)(83380400001)(31696002)(86362001)(50156003)(43740500002)(2101003); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 18:09:19.5596 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3137c883-30b9-4add-b40d-08da3ce75b8d X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT055.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB8692 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/23/2022 8:10 AM, David Marchand wrote: > Hello, > > Following TB decision [1] and recent discussions on the driver specific > commands in testpmd, here is a proposal on how the split could be done. > > For now, this series simply moves the testpmd code in the driver > directory. The driver specific testpmd code is still compiled as part of > testpmd compilation via a global meson testpmd_driver_sources list. > > Notes: > - ixgbe bypass commands in testpmd were "dead" code since switch to meson, > as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd. > No one complained about issue for the last two years, so those commands > are dropped. > > > 1:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpdk.org%2Farchives%2Fdev%2F2022-April%2F239191.html&data=05%7C01%7Cferruh.yigit%40amd.com%7C14ffb5d174e04def3edd08da3c8b59be%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637888866467042882%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XH8MQEiCmLkL%2FtX9BIaogwoaYLqy7ZrGAGQa7M7KM7A%3D&reserved=0 > > -- > David Marchand > > Changes since RFC v2: > - extended cleanup patch 1, > - fixed command registration (again..), > - dropped ixgbe bypass commands, > - fixed some indent, > - updated documentation, > > Changes since RFC v1: > - added a cleanup as patch 1, to make all parser symbols static, > - fixed registering issue in patch 1, > - moved more i40e specific commands, fixed checkpatch warnings, > > David Marchand (6): > app/testpmd: mark most cmdline symbols as static > app/testpmd: register driver specific commands > net/bonding: move testpmd commands > net/i40e: move testpmd commands > app/testpmd: drop ixgbe bypass commands > net/ixgbe: move testpmd commands +1 to split the PMD specific commands, and set lgtm. Thanks for the work.