From: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" <jgrajcia@cisco.com>
To: Phil Yang <phil.yang@arm.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"Damjan Marion (damarion)" <damarion@cisco.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"gavin.hu@arm.com" <gavin.hu@arm.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/memif: optimized with one-way barrier
Date: Wed, 9 Oct 2019 11:14:34 +0000 [thread overview]
Message-ID: <c041e5b6c5d34632ab29b8c865312b63@XCH-ALN-004.cisco.com> (raw)
In-Reply-To: <1570586694-18180-1-git-send-email-phil.yang@arm.com>
> -----Original Message-----
> From: Phil Yang <phil.yang@arm.com>
> Sent: Wednesday, October 9, 2019 4:05 AM
> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> <jgrajcia@cisco.com>; ferruh.yigit@intel.com; dev@dpdk.org
> Cc: thomas@monjalon.net; Damjan Marion (damarion)
> <damarion@cisco.com>; Honnappa.Nagarahalli@arm.com;
> gavin.hu@arm.com; nd@arm.com
> Subject: [PATCH v2] net/memif: optimized with one-way barrier
>
> Using 'rte_mb' to synchronize the shared ring head/tail between producer and
> consumer will stall the pipeline and damage performance on the weak
> memory model platform such like AArch64. Meanwhile update the shared
> ring head and tail are observable and ordered between CPUs on IA.
>
> Optimized this full barrier with the one-way barrier can improve the
> throughput. On AArch64 n1sdp server this patch make testpmd throughput
> boost 2.1%. On Intel E5-2640, testpmd got 3.98% performance gain.
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> v2:
> Upgrade 'MEMIF_VERSION_MAJOR' number to 3. (Jakub Grajciar)
>
> v1:
> Initial version.
I jumped the gun with the version bump. The change doesn't break compatibility. I'm putting reviewed label on v1.
Sorry for the inconvenience.
next prev parent reply other threads:[~2019-10-09 11:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 11:00 [dpdk-dev] [PATCH v1] " Phil Yang
2019-08-26 11:03 ` Phil Yang (Arm Technology China)
2019-10-08 11:05 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-09 2:10 ` Phil Yang (Arm Technology China)
2019-10-09 11:17 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-14 8:59 ` Ferruh Yigit
2019-10-09 2:04 ` [dpdk-dev] [PATCH v2] " Phil Yang
2019-10-09 11:14 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) [this message]
2019-10-10 14:04 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c041e5b6c5d34632ab29b8c865312b63@XCH-ALN-004.cisco.com \
--to=jgrajcia@cisco.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=damarion@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gavin.hu@arm.com \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).