From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92C95A00C2; Fri, 9 Dec 2022 16:13:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 786A4410FB; Fri, 9 Dec 2022 16:13:14 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2072.outbound.protection.outlook.com [40.107.102.72]) by mails.dpdk.org (Postfix) with ESMTP id 4A911410D7 for ; Fri, 9 Dec 2022 16:13:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eAGo1CjaDjeaTAJ/9T/Te8bj5O9t6WWUq7M+lXn1WCsJh7/aCNFIQRrzfqyw6XYUDdU7XQJnQs8GvYVmhKg8/bNso4PE0ou97I3sfB0Yca1Lb3odd51dXXYXM9smMZyISBLEytld9pRsnII89kWFZXajo3+zV2Me8Ea+eLqnKuzGCFYUQnLRgWC5ke1TQ6HULKr+6zN3FCTP41iqN4HnKdtPtiKoNEawu6KYftcbUH765JpQsccYEztigUkrXiiDyZNg728YUNGf1IB1FHRJ+FlZnTQXxA/RBPxvICx0/cmF69xDOouBTcbTHZoHD3aTkfl5mGp1LdcjK5GxMasyfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bk0BsFNSRwRPhT31oE2W/GGGy8d2rAUrbjwixu7Za6M=; b=bRhauFEyXUVMBHcwfNluJRandjziOg6MUBP2d7GSspxt79PTp7pEdOjxpqW1yXB1tpWGeuHNP5v00ceeCm+exY8meB4zALMFIMvYjFeXBr3C7rUSxOAepq8JO6uILJYUR9CfHncn1Z1fo61hxBaicUWuvAAI2g9BAutMaSex1ZVR9QK5Tiknv2eY70zutHboFugx+9OP4ofexDuaaiuzCFVj1WwvidQOy5Y+aNZ0v3yCncAptVjStQu9p7GCf31PVeL6Ij5BIGAX6htjzTaaRyKKdjW/JnusuyOI8VzepBDQmpSgpuLbQXxc//gCZ55x4KrM8WpAku0tmt5U/O2fkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bk0BsFNSRwRPhT31oE2W/GGGy8d2rAUrbjwixu7Za6M=; b=4vbMhCbFHl+roj+UbyGlK2cGiSCn/wz8zgjkB3B1PnMyCogqHQ/oI9Y/pkUEB+LMdD/Z3E+ZvS74xePccx4GNyrTd/ZLjxfGCnt7GTKnUNFmBF2G8tM3t9AXlKii+JeKF79KuglN6bViaNOSiv1SypDiI3T+DnrKuX9CXNeeMic= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB6190.namprd12.prod.outlook.com (2603:10b6:8:99::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 15:13:09 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.014; Fri, 9 Dec 2022 15:13:09 +0000 Message-ID: Date: Fri, 9 Dec 2022 15:13:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US To: Nathan Skrzypczak , Stephen Hemminger Cc: andrew.rybchenko@oktetlabs.ru, Jakub Grajciar , dev@dpdk.org References: <20221010104038.15867-1-nathan.skrzypczak@gmail.com> <20221017121246.9721-1-nathan.skrzypczak@gmail.com> <1520db83-9e0f-9973-f2e1-d2a91a3b3104@amd.com> <625cb85c-4d10-6912-48ad-971e809da0b8@amd.com> <20221207130121.5ce3fa18@hermes.local> From: Ferruh Yigit Subject: Re: [PATCH v2] net/memif: default to physical socket In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::32) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB6190:EE_ X-MS-Office365-Filtering-Correlation-Id: c1fa70c0-8a0d-4da6-da15-08dad9f7e06b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S47N1yF5lrPOE+Qubm2Ilh0EM+f/Ewym4RIBJGP9KOqM8CZ3B8+qZyoLrF+Blid8KyqHAdiIZDFC5nX77Zjejx1MT8tXbSDYKN37Fa5tBixzvFvGeCQSzZyI+e/06NexUeLEHqD60qhNaWBN85Z1URgaRUmjs2RFuZQfrIk5Bq3Z0ZLLLTnIqrCZSuVHALUCExm1VJnsbSTHxAI4x3py61hFDhFzgXavmxi6xoexoGU9AAZBOvOoQz/IoM7ro/3juomZ+/UfLt19rl60nvReIeWfLfLQ5DmQ9/4fkOVqG8Nu5IA8VLy84Px6j8dC6chBlSK0YyhXZcG/86XcFVnZO0Jum65sMdBdlMvOKd8KwChoGc+k7yDs6XnvV4s9gBxk0hBZ8efvW1CNoEy9voQJ4QEkhAXlNRCYdkv5jBNvuELXbC4bD7m2JmTft+0WHg5TdQvDnm3NcTPcZ+Iu/UbzZSV/1aobHdjIrOSE0c/TOwqWSvGetkTeT5tuwvG1CXNIo2HhVqoX0Nnq0mgq/3alR1WVdEYtB8fPRzHDcH38Ej535EwYAXuJXLkX7aUY1jpbaLmGs8WBDlFCy/FiLh94kA1KqLM32fqLaRzKyp5hKpk+uLnUWJHaaeeP5Z3V4parJa9uaHuL7992L8nTIaXT3ZkgvBQzpnnQbI+pxxpaUCUCa8LKxGZpOubAmtfl84rJsaGhRozbBZfc8chgnFyw2gEbMVp1oCYwc3IcXsnW/ZQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(38100700002)(41300700001)(66946007)(66476007)(86362001)(31696002)(26005)(6506007)(6512007)(8936002)(2616005)(6666004)(4326008)(53546011)(186003)(110136005)(8676002)(478600001)(6486002)(316002)(66574015)(66556008)(5660300002)(83380400001)(66899015)(31686004)(36756003)(2906002)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QS9JaFAwNVhGNFRuN0c1ZjNUbmsxOWpJY3NuMDFmSFBvV2dsc0hNZVoxSUxR?= =?utf-8?B?SVRaWWZKR1oydE9qNWlBU1NNaHpFZ3ZINXBYOUo5TFBYZCtLc2hSdTY4UUU3?= =?utf-8?B?OXdGVlkxNnlqbDJOQS9sZHdzTStsSGttcnpSNTZiRU8xV21mdmtMbVlkMFpU?= =?utf-8?B?WTNlMHl4WmhWS0huTHFUajFiNnA2cFdJM2gxRkZKdGFOMmF2OERtbWp3T3Fn?= =?utf-8?B?MGNIdm5CaGFpM2themlzWWpwbW1jSVRUelQ0N3ZiVDlwa3hXYW1Ea1oreHRH?= =?utf-8?B?MDJWdTIrRzQ3UDhRVDFtZWZxc2hMZEt2b3hPcjlLVUN4N2I4VWRCUjB0d2w0?= =?utf-8?B?TWtxcnprWVIxM2JYVnhCcnFaQnB6QjZNQ2pvaGcxTHYvZ09xK1RqdmNnVmRY?= =?utf-8?B?ZGdURnkzVHZ1MzVjK0pSVnB3Z054bUFNN2VTUGlqLy9WYVB3UStia25mRVRO?= =?utf-8?B?elhrQTNyU3gwV3dmejNST0w2ZXF3NGlHNFR3RDBJQm9CUURiRjJkV3Q5bEZE?= =?utf-8?B?L1NYRnVJNlBuMEdDWHpDb3ZSUVViNVE3eDdlb045dXVFaU9FbTNDM3lhNDZy?= =?utf-8?B?ZXhCZi9qTVAwRHNqZDlvNGlIbGdDR29FTHJYVVFZWVZOYkxzeG9TQi9PSGIx?= =?utf-8?B?Z21KSGFKbUEwS0k5azQyQUlITk5FRkFTU2FMTWs2ZzRzMmdFcW02MDJ4TUdV?= =?utf-8?B?ZHZGZlVXbUQ2ZHYzTXpEYVl5eVQ2bzFVV0I5L3piOHhPa2pzQzFzMHpYa01y?= =?utf-8?B?Q082OGd1YmFIOGNuaXByUFFxTWNxRWhjSWZKRUFRS0JVbmpwUXlCbWNia1F1?= =?utf-8?B?cFVlVnpoaVRPQkJDZnI0UEJVWE9lbzhKb0FwNjFQdWJiNkNFTmF2TVA2Lyty?= =?utf-8?B?ZGFsSW5zRmx3RzBpMXFpcVdaTVBnLytXZ29vdUlWdkR6K2xza1dpYnA2eG1v?= =?utf-8?B?Wld0ZytrclFHWnNFQnBMT1hkdlFLc1grbTlYZ0RCRkxrYSt4YnEwclRaYkhj?= =?utf-8?B?WE95WFR3S3dwYzE0N0l2ZFpCdDY3UjNNOU91anpSbDdTRC9KOFF6R1pBeGZz?= =?utf-8?B?TEJoWUdsUUZZSjdNdXlxbWwvcy9GdlBqY2NzVE4yZFlkRnpha3ZBK3ZGTDcz?= =?utf-8?B?QU5hZFl4RFN4UkpWR1EwckNvenc0YS9wN3JMNjVnWVYyMHQyWklzWmNMclFO?= =?utf-8?B?WkVCaGVBSXpkT0dxSlY1Z3dOUzRQR2tBYlVjcUZjbkpJRkRsSlphSnkwZDVq?= =?utf-8?B?OTVIQ3dVc1BPS3d4eFN4bjNtZk9xcTZMTzNLN3BBQ09tUTJqL3B2OEhUaUQy?= =?utf-8?B?UUZ5dW9OYitTckJpbmZienNiYkZwd0pkRURwS2pSZGZBSjN5MVNsTStrUk9C?= =?utf-8?B?K0ROTnZLcHRHZjVHSklFVS9rVzJKcTA4VkxSbTE2WTFBM3lxaFpUQWNJMWlP?= =?utf-8?B?TU5xcEw0aklRaWIvakVxVGxTUTVZZUxvVFFkb0lIL1Q2a2k4KzFDUndoZmha?= =?utf-8?B?YndLZTdvV0ZQeWpkSU5vR09kZGlseVN2MXgyY054WmlEcFlDdlluOSsvaElk?= =?utf-8?B?bEdpN2luK1ZNeW13MTF4WkFQMDBKVGxRUG9HUkdzNlBoUEpTenFJV3B2K0xv?= =?utf-8?B?Tyt5aXdWb1lNUjlybmhPVi9OQ2k0WENVSVh2aVhHTWJHYzdnT2N6Z21SMlAw?= =?utf-8?B?QS9Lei9iRzNQTDRFdDBRTTBZUE1NQnlwVjVDRllzU3BRd0VzRHZhZEt3c012?= =?utf-8?B?N0JLTmpGR2xpMWRVVnp3RDY4R1BpcVRsbzJobFFWYjQySW1uazZsTU5YVlR3?= =?utf-8?B?VGtDaGR6YlZGdXhPa3pzMW1oclRlM243MS9oU2Z6WHE3TnBkYnVRZlRXbW1j?= =?utf-8?B?blhWVWRIZEtNM0VHOGlUWm5KQWZ5VmpvdWMrdlN0NU5pdkJ5QlZaZXNwL0NR?= =?utf-8?B?WC9YSGZsRGdDZm5jUjNzUHZOdkhZSXRHVHlIZjhQZjRPSFZwZjNMV3hIb2l1?= =?utf-8?B?UnJmbjZNakxlUElsWHlsTnlCWEpUZ014VytWNDlNRlB3a01sUDV4VXRqREla?= =?utf-8?B?a1JtbWl6RGhoTFpSMGw3QVhmNFplTmExMElXOWVseXMva2FoRGE3c25QbzRQ?= =?utf-8?Q?SM9Vyw/Kx2Qvw1jYdImwrC63g?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1fa70c0-8a0d-4da6-da15-08dad9f7e06b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 15:13:09.0242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zm6G8t0mGOsdfxirZB0565IEdRaY52eFN0K4Oi/T3wn/PgiEqNIpQdLBImghsLKQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6190 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/8/2022 11:24 AM, Nathan Skrzypczak wrote: > Hi Stephen, Hi Ferruh, > > I don't have a strong opinion on usage of regular sockets vs abstract > sockets. My point is that most existing memif implementations > either don't yet properly support abstract sockets or require extra > flags to be passed by users (iirc VPP, gomemif, libmemif, etc...). > As a matter of fact, abstract socket support in dpdk was broken until > quite recently. So I expect most users to be somewhat > constrained by their implementation to use regular sockets. > > Also, as a user when you come with a filesystem path, understanding you > need to pass the following is not really straightforward > --vdev=net_memif,socket=/tmp/memif.sock,socket-abstract=no > > A better solution might be to use the '@' prefix which seems the usual > representation and remove the socket-abstract=no altogether > --vdev=net_memif,socket=@memif > --vdev=net_memif,socket=/tmp/memif.sock > There is a default socket value ('/run/memif.sock'), that is why additional 'socket-abstract' parameter is required: abstract socket: --vdev=net_memif0 regular socket ('/run/memif.sock'): --vdev=net_memif0,socket-abstract=no Using '@memif' syntax an option to *replace* 'socket-abstract=no' syntax, but this will break existing user interface. And if intentions is NOT replace usage, but add '@memif' syntax, it doesn't add much value since abstract socket is already default option, although it doesn't hurt. Instead, by keeping existing user interface, we can say if user explicitly set a socket value, regular socket is implied, like: abstract: --vdev=net_memif0 --vdev=net_memif0,socket-abstract=yes --vdev=net_memif0,socket=/tmp/memif.sock,socket-abstract=yes [socket-abstract overrides] regular: --vdev=net_memif0,socket=/tmp/memif.sock --vdev=net_memif0,socket-abstract=no --vdev=net_memif0,socket=/tmp/memif.sock,socket-abstract=no Does this improve user experience for regular sockets? > What do you think ? > > (Also iirc Jakub is not receiving emails on this address) > > Cheers > -Nathan > > Le mer. 7 déc. 2022 à 22:01, Stephen Hemminger > > a écrit : > > On Wed, 7 Dec 2022 17:15:06 +0000 > Ferruh Yigit > wrote: > > > On 12/7/2022 3:56 PM, Nathan Skrzypczak wrote: > > > Hi Ferruh, > > >    > > > > Hi Nathan, > > > > > Thank you for your reply,  > > > > > > On the potential confusion for users of the DPDK memif PMD : when > > > defaulting to abstract sockets was added in [0] (v20.10 release) > > > it did change the existing behavior, so reverting it would > restore the > > > old behavior.> Also abstract sockets are quite a unusual feature > in linux (a 0byte > > > prefixed string...), so I'm expecting most users of memif to > just use > > > regular sockets because they're way easier to handle. > > >    > > > > Not sure if regular socket is easier to handle, or users prefer > regular > > sockets, we need more input on these. > > Regular sockets are actually harder handle, it is more that users > are less familiar with them! Regular sockets have to go through > file permission checks which makes dealing with containers and SELinux > hard.  Regular sockets persist when application crashes which makes > recovery harder. >