From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 346951BB68 for ; Thu, 12 Apr 2018 14:05:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2018 05:05:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,441,1517904000"; d="scan'208";a="216052568" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by orsmga005.jf.intel.com with ESMTP; 12 Apr 2018 05:05:13 -0700 To: Neil Horman , dev@dpdk.org Cc: Thomas Monjalon , Ferruh Yigit References: <20180402120619.30404-1-nhorman@tuxdriver.com> <20180412111640.8977-1-nhorman@tuxdriver.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 12 Apr 2018 13:05:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180412111640.8977-1-nhorman@tuxdriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCHv2] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 12:05:16 -0000 On 12-Apr-18 12:16 PM, Neil Horman wrote: > https://dpdk.org/tracker/show_bug.cgi?id=18 > > Indicated that several mmap call sites in the [linux|bsd]app eal code > set fd that was not -1 in their calls while using MAP_ANONYMOUS. While > probably not a huge deal, the man page does say the fd should be -1 for > portability, as some implementations don't ignore fd as they should for > MAP_ANONYMOUS. > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: Ferruh Yigit > > --- > Change notes > > v2) Rebased to HEAD again to adjust for patches that landed ahead of > this > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly