From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D55AA0093; Wed, 9 Mar 2022 03:53:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC30140687; Wed, 9 Mar 2022 03:53:18 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id DAA2D40395 for ; Wed, 9 Mar 2022 03:53:17 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KCxXm3SNVzBrgy; Wed, 9 Mar 2022 10:51:20 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Wed, 9 Mar 2022 10:53:15 +0800 Subject: Re: [PATCH v4] net/bonding: another fix to LACP mempool size To: Stephen Hemminger , Gaoxiang Liu CC: , , References: <20220305070922.308-1-gaoxiangliu0@163.com> <20220308142402.2455-1-gaoxiangliu0@163.com> <20220308172517.66ac5a8d@hermes.local> From: "Min Hu (Connor)" Message-ID: Date: Wed, 9 Mar 2022 10:53:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20220308172517.66ac5a8d@hermes.local> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Stephen, ÔÚ 2022/3/9 9:25, Stephen Hemminger дµÀ: > On Tue, 8 Mar 2022 22:24:02 +0800 > Gaoxiang Liu wrote: > >> diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h >> index 1e7a3c1527..fa15ed710f 100644 >> --- a/lib/mempool/rte_mempool.h >> +++ b/lib/mempool/rte_mempool.h >> @@ -56,6 +56,8 @@ >> extern "C" { >> #endif >> >> +#define RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER 1.5 > > Why is a magic number from bonding ending up in the user API for mempool? Yes, I suggest putting the macro(name should be changed) in bonding. No need to define a new RTE_* macro in mempool. By the way, the RTE_MEMPOOL_CACHE_FLUSHTHRESH_MULTIPLIER is the same as CACHE_FLUSHTHRESH_MULTIPLIER already defined in rte_mempool.c. > . >