From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17B84A034F; Thu, 1 Apr 2021 10:42:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEF27140ED6; Thu, 1 Apr 2021 10:42:10 +0200 (CEST) Received: from dal3relay66.mxroute.com (dal3relay66.mxroute.com [64.40.27.66]) by mails.dpdk.org (Postfix) with ESMTP id 42CC940142 for ; Thu, 1 Apr 2021 10:42:09 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay66.mxroute.com (ZoneMTA) with ESMTPSA id 1788c98c59b0004444.004 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 01 Apr 2021 08:42:05 +0000 X-Zone-Loop: cb47e642566c9a51178273d1435b0a9fa0b514b858be X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YdbS04TQRCWmBfEwwG/Dl2SCWPS9ArIYRAgbO7OXzP0=; b=hfgg1unZfQ89E5X+dk02Q28VJu X1S3aBjjC0ydmu3csBft5wx+0hk76h9iV4ims0kb6Pc7Sz9QnQ40OEyxdXcVbYBSs4HrG8rQcMIrx B9SwVh9VSYHMPot2RGqaK6cjB4dfRn09q5EDNDQZa9iYc73sGPqQ7kzyzppPE95psj2h6W7mkn9Lb i9K58LgK230qMH6sq+IXml1Tu/kyQRiFqrgrypqkx2rztOKJycWXt8dl+GDIm55C7dw/83gOdcQaB G56tnAv4+HOaWjIZ7CIv+vyiLppnJjtVT7u5KZgIHa27IlaCx9p2i6ehkIt1kKobcvWB5tbbo7nnb eTwkMQQA==; To: Ferruh Yigit , Keiichi Watanabe , dev@dpdk.org Cc: dgreid@chromium.org, chirantan@chromium.org, Maxime Coquelin , Chenbo Xia , Neil Horman , David Marchand References: <20210322072257.2017227-1-keiichiw@chromium.org> <20210322072257.2017227-2-keiichiw@chromium.org> From: "Kinsella, Ray" Message-ID: Date: Thu, 1 Apr 2021 09:42:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 31/03/2021 17:45, Ferruh Yigit wrote: > On 3/22/2021 7:22 AM, Keiichi Watanabe wrote: >> Add rte_vhost_get_negotiated_protocol_features, which returns a set of >> enabled protocol features. >> >> Signed-off-by: Keiichi Watanabe > > <...> > >> diff --git a/lib/librte_vhost/version.map b/lib/librte_vhost/version.map >> index 9183d6f2f..95c4c0990 100644 >> --- a/lib/librte_vhost/version.map >> +++ b/lib/librte_vhost/version.map >> @@ -63,6 +63,7 @@ EXPERIMENTAL { >>       rte_vhost_va_from_guest_pa; >>       rte_vhost_extern_callback_register; >>       rte_vhost_driver_set_protocol_features; >> +    rte_vhost_get_negotiated_protocol_features; >>       rte_vhost_set_inflight_desc_split; >>       rte_vhost_set_inflight_desc_packed; >>       rte_vhost_set_last_inflight_io_split; > > Added the release version that experimental API is added as comment in next-net, like following: > > +++ b/lib/librte_vhost/version.map > @@ -76,4 +76,7 @@ EXPERIMENTAL { >         rte_vhost_async_channel_unregister; >         rte_vhost_submit_enqueue_burst; >         rte_vhost_poll_enqueue_completed; > + > +       # added in 21.05 > +       rte_vhost_get_negotiated_protocol_features; >  }; > > > We are doing this already in many libraries [1], this helps us easily observe how long an API is staying as experimental in a library. Good idea. > [1]: https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407