From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 877484598C; Sat, 14 Sep 2024 10:21:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7850D40A80; Sat, 14 Sep 2024 10:21:37 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 62E1C40A80 for ; Sat, 14 Sep 2024 10:21:25 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4X5PJ31ST3zyRwS; Sat, 14 Sep 2024 16:20:35 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 203D414035F; Sat, 14 Sep 2024 16:21:24 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sat, 14 Sep 2024 16:21:23 +0800 Message-ID: Date: Sat, 14 Sep 2024 16:21:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/8] net/hns3: remove some basic address dump To: Jie Hai , , , , CC: References: <20231214015650.3738578-1-haijie1@huawei.com> <20240914071320.1982-1-haijie1@huawei.com> <20240914071320.1982-4-haijie1@huawei.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20240914071320.1982-4-haijie1@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2024/9/14 15:13, Jie Hai wrote: > For security reasons, some address registers are not suitable > to be exposed, remove them. > > Cc: stable@dpdk.org > > Signed-off-by: Jie Hai > Acked-by: Huisong Li > --- > drivers/net/hns3/hns3_regs.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c > index be1be6a89c94..53d829a4fc68 100644 > --- a/drivers/net/hns3/hns3_regs.c > +++ b/drivers/net/hns3/hns3_regs.c > @@ -17,13 +17,9 @@ > > static int hns3_get_dfx_reg_line(struct hns3_hw *hw, uint32_t *lines); > > -static const uint32_t cmdq_reg_addrs[] = {HNS3_CMDQ_TX_ADDR_L_REG, > - HNS3_CMDQ_TX_ADDR_H_REG, > - HNS3_CMDQ_TX_DEPTH_REG, > +static const uint32_t cmdq_reg_addrs[] = {HNS3_CMDQ_TX_DEPTH_REG, > HNS3_CMDQ_TX_TAIL_REG, > HNS3_CMDQ_TX_HEAD_REG, > - HNS3_CMDQ_RX_ADDR_L_REG, > - HNS3_CMDQ_RX_ADDR_H_REG, > HNS3_CMDQ_RX_DEPTH_REG, > HNS3_CMDQ_RX_TAIL_REG, > HNS3_CMDQ_RX_HEAD_REG, > @@ -44,9 +40,7 @@ static const uint32_t common_vf_reg_addrs[] = {HNS3_MISC_VECTOR_REG_BASE, > HNS3_FUN_RST_ING, > HNS3_GRO_EN_REG}; > > -static const uint32_t ring_reg_addrs[] = {HNS3_RING_RX_BASEADDR_L_REG, > - HNS3_RING_RX_BASEADDR_H_REG, > - HNS3_RING_RX_BD_NUM_REG, > +static const uint32_t ring_reg_addrs[] = {HNS3_RING_RX_BD_NUM_REG, > HNS3_RING_RX_BD_LEN_REG, > HNS3_RING_RX_EN_REG, > HNS3_RING_RX_MERGE_EN_REG, > @@ -57,8 +51,6 @@ static const uint32_t ring_reg_addrs[] = {HNS3_RING_RX_BASEADDR_L_REG, > HNS3_RING_RX_FBD_OFFSET_REG, > HNS3_RING_RX_STASH_REG, > HNS3_RING_RX_BD_ERR_REG, > - HNS3_RING_TX_BASEADDR_L_REG, > - HNS3_RING_TX_BASEADDR_H_REG, > HNS3_RING_TX_BD_NUM_REG, > HNS3_RING_TX_EN_REG, > HNS3_RING_TX_PRIORITY_REG,