From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Vivien Didelot <vivien.didelot@gmail.com>, dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
patrick.keroulas@radio-canada.ca, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v2] net/pcap: support software Tx nanosecond timestamps
Date: Wed, 10 Jun 2020 14:42:27 +0100 [thread overview]
Message-ID: <c0928e50-1aa9-503b-bf8b-de0d08f93fb9@intel.com> (raw)
In-Reply-To: <20200609190719.105323-1-vivien.didelot@gmail.com>
On 6/9/2020 8:07 PM, Vivien Didelot wrote:
> When capturing packets into a PCAP file, DPDK currently uses
> microseconds for the timestamps. But libpcap supports interpreting
> tv_usec as nanoseconds depending on the file timestamp precision,
> as of commit ba89e4a18e8b ("Make timestamps precision configurable").
>
> To support this, use PCAP_TSTAMP_PRECISION_NANO when creating the
> empty PCAP file as specified by PCAP_OPEN_DEAD(3PCAP) and implement
> nanosecond timeval addition. This also ensures that the precision
> reported by capinfos is nanoseconds (9).
>
> Note that NSEC_PER_SEC is defined as 1000000000L instead of 1e9 since
> the latter might be interpreted as floating point.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
(Since there is a potential patch on top of this, I am merging this quickly)
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-06-10 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 19:07 Vivien Didelot
2020-06-09 19:43 ` Stephen Hemminger
2020-06-09 19:57 ` Vivien Didelot
2020-06-10 12:17 ` Ferruh Yigit
2020-06-10 13:42 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0928e50-1aa9-503b-bf8b-de0d08f93fb9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=patrick.keroulas@radio-canada.ca \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).