From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96B3145C04; Tue, 29 Oct 2024 01:12:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BEDE4014F; Tue, 29 Oct 2024 01:12:09 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 90CAA40144 for ; Tue, 29 Oct 2024 01:12:07 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4XcrHs3Dbpz1SDP4; Tue, 29 Oct 2024 08:10:33 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 5243A1402E1; Tue, 29 Oct 2024 08:12:04 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 29 Oct 2024 08:12:04 +0800 Message-ID: Date: Tue, 29 Oct 2024 08:12:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] config/arm: fix warning for native build with meson >= 0.55 To: David Marchand , CC: Wathsala Vithanage , Bruce Richardson , Pavan Nikhilesh , Jerin Jacob , Robin Jarry References: <20241028131047.3036831-1-david.marchand@redhat.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20241028131047.3036831-1-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2024/10/28 21:10, David Marchand wrote: > Caught in UNH logs for native compilation on ARM: > > Program /...../dpdk/config/arm/armv8_machine.py found: YES > (/...../dpdk/config/arm/armv8_machine.py) > WARNING: Project targeting '>= 0.57' but tried to use feature deprecated > since '0.55.0': ExternalProgram.path. use ExternalProgram.full_path() > instead > > There is nothing to search, nor a reason to call the script with an > absolute path. > The script can be directly pointed at with files(). > > Fixes: 200b88cbe0e6 ("build: detect micro-arch on ARM") > Fixes: 6f3dbd306de0 ("build: increase minimum meson version to 0.57") > > Signed-off-by: David Marchand > --- > config/arm/meson.build | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 55be7c8711..95500c8ed3 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -784,9 +784,8 @@ else > # native build > # The script returns ['Implementer', 'Variant', 'Architecture', > # 'Primary Part number', 'Revision'] > - detect_vendor = find_program(join_paths(meson.current_source_dir(), > - 'armv8_machine.py')) > - cmd = run_command(detect_vendor.path(), check: false) > + detect_vendor = py3 + files('armv8_machine.py') > + cmd = run_command(detect_vendor, check: false) > if cmd.returncode() == 0 > cmd_output = cmd.stdout().to_lower().strip().split(' ') > implementer_id = cmd_output[0]