From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D874FA034F; Mon, 22 Feb 2021 11:31:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 654FA40041; Mon, 22 Feb 2021 11:31:19 +0100 (CET) Received: from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id 5B7A04003C for ; Mon, 22 Feb 2021 11:31:17 +0100 (CET) Received: from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw01.pantheon.sk (Proxmox) with ESMTP id 0745C201DDF; Mon, 22 Feb 2021 11:31:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=Ha7Z5FZqBfCX5hrIp5NZ OAvdi57w2/BTYWIohB04qxU=; b=Ri9q65EHTb26+ruWGzDUIF/IE4a3Q4dJwOI1 gh8I8wguu0Go3IpX8dPvcKkiNf/uFBTd/jVjBVRCD16Y7Jn+t0rtC+NdjfeHwyvO evjJIXbNMSCYpDV4kWW8MroiJpJpR6UAHD/c4qrKwAkOAQ/aEKNH2oxJshFUII+V ai4BLNd2TcPMxqf7LR8GT8FFwxaD6GLcQo4op/ZsQcaPTdMTslp/AdDACJrBh6pc mKH0JdiZUMJDn1I1fKNT1xvApcMDv2gc6kZ6LuDe5n3SrSR73moM17p0sDAoE2SQ kObYO2d3WmJY1MN/4R0hsDHw9fRUknYKvkvI4pRqRLaL09M64w== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Aaron Conole , "dev@dpdk.org" CC: Bruce Richardson , David Hunt , Anatoly Burakov Thread-Topic: [dpdk-dev] Build errors due to duplicate version.map entries in librte_power Thread-Index: AQHXA89i2ueR74tdqEWeVMeBAIm+uKpkAdHg Date: Mon, 22 Feb 2021 10:31:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] Build errors due to duplicate version.map entries in librte_power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This seems to have gone unnoticed. lib/librte_power/version.map specifies rte_power_guest_channel_send_msg bot= h under DPDK_21 and EXPERIMENTAL. This is causing the clang cross-compile job to always fail with the error A= aron provided: ld.lld: error: duplicate symbol 'rte_power_guest_channel_send_msg' in versi= on script Only the clang cross compile jobs are failing. This could be due to them us= ing the LLVM linker (ld.lld) and the other clang jobs using the default lin= ker. I have two questions about this: 1. Is this a real failure? 2. If this is a real failure, should we also use ld.lld in the other clang = jobs? Thanks, Juraj > -----Original Message----- > From: dev On Behalf Of Aaron Conole > Sent: Monday, February 15, 2021 8:18 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; David Hunt > ; Anatoly Burakov > Subject: [dpdk-dev] Build errors due to duplicate version.map entries in > librte_power >=20 > Greetings, >=20 > During CI runs, I've noticed lots of failures from the Travis-CI side all= related to > librte_power/version.map containing some duplicate symbols. It seems com= mit > 4d3892dcd77b ("power: make channel message functions public") made the > following hunk: >=20 > diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map = index > 69ca9af616..13f0af3b2d 100644 > --- a/lib/librte_power/version.map > +++ b/lib/librte_power/version.map > @@ -34,4 +34,8 @@ EXPERIMENTAL { > rte_power_guest_channel_receive_msg; > rte_power_poll_stat_fetch; > rte_power_poll_stat_update; > + > + # added in 21.02 > + rte_power_guest_channel_receive_msg; > + rte_power_guest_channel_send_msg; > }; >=20 >=20 > As can be seen, rte_power_guest_channel_receive_msg was added already (it= 's > present in the hunk itself). The rte_power_guest_channel_send_msg functi= on > was added as part of 85ff364f3bd3 ("build: align symbols with global ABI > version"). >=20 > I guess it may not be allowed to have duplicate symbols here, because in = travis, I > see (only for some builds): >=20 > clang -o lib/librte_power.so.21.1 > 'lib/lib@@rte_power@sta/librte_power_rte_power.c.o' > 'lib/lib@@rte_power@sta/librte_power_power_acpi_cpufreq.c.o' > 'lib/lib@@rte_power@sta/librte_power_power_kvm_vm.c.o' > 'lib/lib@@rte_power@sta/librte_power_guest_channel.c.o' > 'lib/lib@@rte_power@sta/librte_power_rte_power_empty_poll.c.o' > 'lib/lib@@rte_power@sta/librte_power_power_pstate_cpufreq.c.o' > 'lib/lib@@rte_power@sta/librte_power_rte_power_pmd_mgmt.c.o' > 'lib/lib@@rte_power@sta/librte_power_power_common.c.o' -Wl,--no- > undefined -Wl,--as-needed -shared -fPIC -Wl,--start-group -Wl,- > soname,librte_power.so.21 -Wl,--no-as-needed -pthread -lm -ldl > lib/librte_eal.so.21.1 lib/librte_kvargs.so.21.1 lib/librte_telemetry.so.= 21.1 > lib/librte_timer.so.21.1 lib/librte_ethdev.so.21.1 lib/librte_net.so.21.1 > lib/librte_mbuf.so.21.1 lib/librte_mempool.so.21.1 lib/librte_ring.so.21.= 1 > lib/librte_meter.so.21.1 -Wl,--end-group -Wl,--version- > script=3D/home/travis/build/ovsrobot/dpdk/lib/librte_power/version.map '-= Wl,- > rpath,$ORIGIN/' -Wl,-rpath-link,/home/travis/build/ovsrobot/dpdk/build/li= b - > target aarch64-linux-gnu -fuse-ld=3Dlld --gcc-toolchain=3D/usr >=20 > ld.lld: error: duplicate symbol 'rte_power_guest_channel_send_msg' in ver= sion > script >=20 > Thoughts? >=20