From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 0E6BF235
 for <dev@dpdk.org>; Fri,  7 Jul 2017 15:37:16 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga105.fm.intel.com with ESMTP; 07 Jul 2017 06:37:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,322,1496127600"; d="scan'208";a="1169871580"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91])
 ([10.237.220.91])
 by fmsmga001.fm.intel.com with ESMTP; 07 Jul 2017 06:37:14 -0700
To: Andrew Rybchenko <arybchenko@solarflare.com>,
 John McNamara <john.mcnamara@intel.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
 Thomas Monjalon <thomas@monjalon.net>
References: <20170622190233.67933-1-ferruh.yigit@intel.com>
 <20170705132028.58993-1-ferruh.yigit@intel.com>
 <8a981e9a-2215-a2ae-cb75-5982fd714845@solarflare.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <c0c639a6-996c-161b-c5db-ee5402871524@intel.com>
Date: Fri, 7 Jul 2017 14:37:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <8a981e9a-2215-a2ae-cb75-5982fd714845@solarflare.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3] doc: document NIC features
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jul 2017 13:37:18 -0000

Hi Andrew,

On 7/7/2017 11:55 AM, Andrew Rybchenko wrote:
> On 07/05/2017 04:20 PM, Ferruh Yigit wrote:
>> Document NIC features, add more information about them and add more
>> implementation related support.
> 
> It is very useful information and very good start.

Thanks for review, I rely on more comments to have more comprehensive
document.

> I think it would be very useful to explain how PMD advertises support of 
> the feature and
> how application or further layers like bonding PMD can find out if the 
> feature is supported.

I agree this should be documented and may not be clear right now, but
not sure if it should be in this document, I would prefer this document
just documents the NIC features we are advertising.

Let's think where this information may fit.

> 
> Also some PMDs have few implementations of the datapath (like vector and 
> usual). Ideally
> we need common way to highlight it. May be it is OK that control path 
> features are duplicated
> in this case, but ideally it should be expressed somehow.

I agree different datapath implementations can be documented better, I
just don't know how to do ...

For some drivers there are multiple vector implementations and the
feature set for them is not clear. And as you said control features are
duplicated in the table.

Perhaps control and datapath features can be separated.

Or as Thomas suggested sometime ago, vector and scalar version can be
merged into one in the table and feature can be marked as supported if
both scalar and vector has support for it. But this is not solving
multiple vector implementation problem.

Overall this is something needs some more thinking on it, any comment
welcome.

> 
> Below I'll add information which would be useful from my point of view. 

I will update the document with below comments and send a new version of
patch.

Thanks,
ferruh