From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C293AA04AF; Fri, 21 Aug 2020 03:32:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 060D55F69; Fri, 21 Aug 2020 03:32:06 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0F2AE2BE2 for ; Fri, 21 Aug 2020 03:32:03 +0200 (CEST) IronPort-SDR: 0k+E/jdk4sRDE2UPMXL9gkF84Ue+7hHHTKzuWRBIA3YuzLLwr0WcxqNu6v+AlGRtS1Jlx8FfZO HkASkPrNN99w== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="240257522" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208,217";a="240257522" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 18:32:03 -0700 IronPort-SDR: q45yNwSSWvSez8SrMlBWGmzuCu/W8tJbuJ3GOo9Pt08a3q9G7MYvZ+kiRPMyPwoO8p8XQrQe5C Qz07WasN3okg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208,217";a="371772287" Received: from orsmsx606-2.jf.intel.com (HELO ORSMSX606.amr.corp.intel.com) ([10.22.229.86]) by orsmga001.jf.intel.com with ESMTP; 20 Aug 2020 18:32:02 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 20 Aug 2020 18:32:02 -0700 Received: from orsmsx101.amr.corp.intel.com (10.22.225.128) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 20 Aug 2020 18:32:02 -0700 Received: from [10.166.30.253] (10.166.30.253) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Aug 2020 18:32:02 -0700 To: Narcisa Ana Maria Vasile , , , , , CC: , , Narcisa Vasile , Harini Ramakrishnan References: <1597962235-4787-1-git-send-email-navasile@linux.microsoft.com> From: Ranjit Menon Message-ID: Date: Thu, 20 Aug 2020 18:32:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1597962235-4787-1-git-send-email-navasile@linux.microsoft.com> Content-Language: en-US X-Originating-IP: [10.166.30.253] Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Naty On 8/20/2020 3:23 PM, Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > The Windows NetUIO kernel driver allows the DPDK userspace > application to directly access the hardware. > > Cc: Harini Ramakrishnan > Cc: Omar Cardona > Signed-off-by: Narcisa Vasile > --- > > v2: > Fix license message in each file > Minor fixes in README > Remove RC file as it is autogenerated > Remove HW Ids from Inf > Resubmit as single patch > > .gitattributes | 4 + > .gitignore | 2 + > windows/netuio/kernel/README_NetUIO.rst | 64 +++ > .../netuio/kernel/windows/netuio/netuio.inf | 78 ++++ > .../netuio/kernel/windows/netuio/netuio_dev.c | 388 +++++++++++++++++ > .../netuio/kernel/windows/netuio/netuio_dev.h | 61 +++ > .../netuio/kernel/windows/netuio/netuio_drv.c | 146 +++++++ > .../netuio/kernel/windows/netuio/netuio_drv.h | 32 ++ > .../kernel/windows/netuio/netuio_interface.h | 73 ++++ > .../kernel/windows/netuio/netuio_queue.c | 397 ++++++++++++++++++ > .../kernel/windows/netuio/netuio_queue.h | 31 ++ > .../netuio/kernel/windows/netuio/resource.h | 14 + > .../mk/exec-env/windows/netuio/netuio.sln | 24 ++ > .../mk/exec-env/windows/netuio/netuio.vcxproj | 113 +++++ > .../windows/netuio/netuio.vcxproj.filters | 54 +++ > .../windows/netuio/netuio.vcxproj.user | 11 + > 16 files changed, 1492 insertions(+) > create mode 100644 .gitattributes > create mode 100644 .gitignore > create mode 100644 windows/netuio/kernel/README_NetUIO.rst > create mode 100644 windows/netuio/kernel/windows/netuio/netuio.inf > create mode 100644 windows/netuio/kernel/windows/netuio/netuio_dev.c > create mode 100644 windows/netuio/kernel/windows/netuio/netuio_dev.h > create mode 100644 windows/netuio/kernel/windows/netuio/netuio_drv.c > create mode 100644 windows/netuio/kernel/windows/netuio/netuio_drv.h > create mode 100644 windows/netuio/kernel/windows/netuio/netuio_interface.h > create mode 100644 windows/netuio/kernel/windows/netuio/netuio_queue.c > create mode 100644 windows/netuio/kernel/windows/netuio/netuio_queue.h > create mode 100644 windows/netuio/kernel/windows/netuio/resource.h > create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.sln > create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj > create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj.filters > create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj.user I haven't reviewed the code yet, but a few general suggestions and observations: 1. This code is going into the dpdk-kmods repo, so we don't need the four-level deep directory path for the source. 2. The code can simply be in the windows/netuio directory (don't need 'kernel') 3. The 'virt2phys' module that is already in the repo puts the build-related files (project files, solution files etc) in the same folder as the source files. We should do the same here. We don't need the mk/exec-env subfolder for these files. They can be in the same directory as the source. 4. Remove the .vcxproj.user file from the patch. It is not required. 5. The README should be renamed to simply README.rst and it can also be in this windows/netuio folder 6. The existing README.rst in the windows folder contains information on how to build and load kernel modules in Windows. This new README can reference the root-level README, if required. (Also some of the information in this new README is out-of-date. I'll review that separately) ranjit m.