From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39B74A0A03; Mon, 18 Jan 2021 17:37:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6DF5140D1E; Mon, 18 Jan 2021 17:37:05 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id C0799140CAA for ; Mon, 18 Jan 2021 17:37:03 +0100 (CET) IronPort-SDR: CBY0+9RqyAmWvZ7yi4Q5DJle4hzMFeLu8J9R0AYHaPv+Ikq0aLM6SFtHM82dFzml9K767wKu/4 O88W5T/LLxdw== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="158597385" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="158597385" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 08:36:55 -0800 IronPort-SDR: kTr1uCQcCZmfy4HWOEd/xiKPzfArgM4HguzwXqQnzrgSHh6eGEwybSnVZGltOjtLl65trDK5Ll x+2F/FubEQ0w== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="383622290" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.24]) ([10.213.241.24]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 08:36:51 -0800 To: Odi Assli , "Rong, Leyi" , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Xing, Beilei" , "Kadam, Pallavi" , "Menon, Ranjit" Cc: "dev@dpdk.org" , Tal Shnaiderman , NBU-Contact-Thomas Monjalon , Raslan Darawsheh , Ali Alnubani References: <20201215021945.103396-1-leyi.rong@intel.com> <20210114063951.2580-1-leyi.rong@intel.com> <2f4e5455-2c11-9f90-fc8e-ac5d1601536e@intel.com> From: Ferruh Yigit Message-ID: Date: Mon, 18 Jan 2021 16:36:47 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/18/2021 2:53 PM, Odi Assli wrote: >> Subject: Re: [PATCH v3 0/3] AVX512 vPMD on i40e >> >> External email: Use caution opening links or attachments >> >> >> On 1/18/2021 1:58 PM, Rong, Leyi wrote: >>> >>>> -----Original Message----- >>>> From: Odi Assli >>>> Sent: Sunday, January 17, 2021 7:26 PM >>>> To: Zhang, Qi Z ; Rong, Leyi >>>> ; Lu, Wenzhuo ; Yigit, >>>> Ferruh ; Richardson, Bruce >>>> ; Xing, Beilei ; >>>> Kadam, Pallavi ; Menon, Ranjit >>>> >>>> Cc: dev@dpdk.org; Tal Shnaiderman ; NBU-Contact- >>>> Thomas Monjalon ; Raslan Darawsheh >>>> ; Ali Alnubani >>>> Subject: RE: [PATCH v3 0/3] AVX512 vPMD on i40e >>>> >>>>>> Subject: [PATCH v3 0/3] AVX512 vPMD on i40e >>>>>> >>>>>> This patchset aims to support AVX512 vPMD on i40e. >>>>>> And the changes are only target to AVX512 vector path. >>>>>> >>>>>> --- >>>>>> v3: >>>>>> - Extract get_avx_supported() to get the proper vector data path to >>>>> choose. >>>>>> >>>>>> v2: >>>>>> - Add return value check on rte_mempool_default_cache(). >>>>>> >>>>>> >>>>>> Leyi Rong (3): >>>>>> net/i40e: remove devarg use-latest-supported-vec >>>>>> net/i40e: add AVX512 vector path >>>>>> net/i40e: optimize Tx by using AVX512 >>>>>> >>>>>> doc/guides/nics/i40e.rst | 9 - >>>>>> drivers/net/i40e/i40e_ethdev.c | 63 +- >>>>>> drivers/net/i40e/i40e_ethdev.h | 3 - >>>>>> drivers/net/i40e/i40e_rxtx.c | 196 ++-- >>>>>> drivers/net/i40e/i40e_rxtx.h | 13 + >>>>>> drivers/net/i40e/i40e_rxtx_vec_avx512.c | 1136 >>>>> +++++++++++++++++++++++ >>>>>> drivers/net/i40e/meson.build | 24 + >>>>>> 7 files changed, 1301 insertions(+), 143 deletions(-) create >>>>>> mode >>>>>> 100644 drivers/net/i40e/i40e_rxtx_vec_avx512.c >>>>>> >>>>>> -- >>>>>> 2.17.1 >>>>> >>>>> >>>>> Applied to dpdk-next-net-intel after revert v1. >>>>> >>>>> Thanks >>>>> Qi >>>> >>>> Hi, >>>> This patch series broke i40e compilation on windows with failure in >>>> undefined __m_prefetchw function Please see details in bug: 619 [1]. >>>> >>>> [1]: >>>> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbug >>>> >> s.dpdk.org%2Fshow_bug.cgi%3Fid%3D619&data=04%7C01%7Codia%40 >> nvidia >>>> >> .com%7C4b212e1ae3d045b6264108d8bbbd7703%7C43083d15727340c1b7db3 >> 9efd9c >>>> >> cc17a%7C0%7C0%7C637465769725929951%7CUnknown%7CTWFpbGZsb3d8e >> yJWIjoiMC >>>> >> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000& >> amp;s >>>> >> data=oSmKjG6Za9DCSthbn72YfsQ1JsrUoaVSUCLNt7c5R4o%3D&reserve >> d=0 >>>> >>> >>> Hi Ferruh, >>> >>> Could you help to squash my fix patch into the patch series? As I've verified >> it works locally. >>> >>> Hi Assli, >>> >>> Could you help to check after Ferruh squashed the fix patch into the next- >> net? >>> >> >> Hi Assli, >> >> The other-way around is safer perhaps, can you please test with the patch: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc >> hes.dpdk.org%2Fpatch%2F86804%2F&data=04%7C01%7Codia%40nvidia >> .com%7C4b212e1ae3d045b6264108d8bbbd7703%7C43083d15727340c1b7db3 >> 9efd9ccc17a%7C0%7C0%7C637465769725939943%7CUnknown%7CTWFpbGZs >> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn >> 0%3D%7C1000&sdata=ZQU7m8zNXw%2BKxeG6AcveYp9Dpa4k%2BdeO >> 2hK5DiBT3lg%3D&reserved=0 >> >> If it is good, I can squash it in the next-net. >> >> Thanks, >> ferruh > > Hi Guys, > > I tested it in my side and it works Thanks Assli, Leyi, I will proceed with the patch. > Can you please the Bugzilla bug 619? >