From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"phil.yang@arm.com" <phil.yang@arm.com>
Subject: Re: [dpdk-dev] [PATCH] test/service: add perf test for service on app lcore
Date: Tue, 5 May 2020 14:38:46 +0200 [thread overview]
Message-ID: <c0ee846a-a721-a6cd-232e-baf437ece9ec@partner.samsung.com> (raw)
In-Reply-To: <BYAPR11MB3143A2191BFD32C7EE73E4D8D7A70@BYAPR11MB3143.namprd11.prod.outlook.com>
W dniu 05.05.2020 o 12:21, Van Haaren, Harry pisze:
>> -----Original Message-----
>> From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
>> Sent: Monday, May 4, 2020 9:50 PM
>> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
>> Cc: honnappa.nagarahalli@arm.com; phil.yang@arm.com
>> Subject: Re: [dpdk-dev] [PATCH] test/service: add perf test for service on app
>> lcore
> <snip code>
>
>>> + unregister_all();
>>> return TEST_SUCCESS;
>>> }
>>>
>> Hi Harry,
> Hey Lukasz,
>
>> I like the idea of adding this test. I checked it and it works fine.
> Thanks for testing - please send a "Tested-by: .. <email>" and we can track
> your input into the git logs :)
No problem, I just wanted to get you opinion first, but here you go:
Tested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
>
>> However have you considered adding it as a separate testcase or even
>> better as "service_perf_autotest" command ?
> Actually I started implementing a new function with a very similar name,
> but realized that the configuration/mapping would be duplicated, only to
> have a different named test... so opted for this smaller diff solution.
>
>> With your changes the: service_app_lcore_mt_safe and
>> service_app_lcore_mt_unsafe unit tests cases have multiple
>> functionalities: they test simultaneous execution of service and they do
>> performance checks.
> Correct - if you feel strongly that this isn't right I can refactor to a v2,
> however I expect there would be more duplicated code to manage, and
> hence I decided the above approach was simpler and easier.
It's up to you and some more dpdk-experienced guys. Isn't there a way
not to duplicate the code but wrap it in a function?
You don't really need that much, because you run the performance test
after the former version of test is completed. You don't need 2 lcores
also as you measure direct start of service function, which also is
almost empty as it immediately returns because the loop breaking
conditions are already set.
>
>> Best regards
>> Lukasz
> Regards, -Harry
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com
next prev parent reply other threads:[~2020-05-05 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200501155607eucas1p2509870b6b5f4cc520dca11888e221b1b@eucas1p2.samsung.com>
2020-05-01 15:56 ` Harry van Haaren
2020-05-04 20:50 ` Lukasz Wojciechowski
2020-05-05 10:21 ` Van Haaren, Harry
2020-05-05 12:38 ` Lukasz Wojciechowski [this message]
2020-05-06 14:33 ` Phil Yang
2020-05-06 15:44 ` David Marchand
2020-05-06 17:00 ` Van Haaren, Harry
2020-05-06 17:16 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2020-05-07 6:28 ` Phil Yang
2020-05-07 12:11 ` David Marchand
2020-05-11 11:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0ee846a-a721-a6cd-232e-baf437ece9ec@partner.samsung.com \
--to=l.wojciechow@partner.samsung.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=phil.yang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).