From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9850A04B8; Tue, 5 May 2020 14:38:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7FAF61D59C; Tue, 5 May 2020 14:38:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A05CD1D598 for ; Tue, 5 May 2020 14:38:49 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200505123849euoutp011a4e99c398c2c624ae548606a204eb4b~MIik7aSwH0136501365euoutp01z for ; Tue, 5 May 2020 12:38:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200505123849euoutp011a4e99c398c2c624ae548606a204eb4b~MIik7aSwH0136501365euoutp01z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1588682329; bh=x0tslvB5QkN/akPYL+D2J31kHKaxTGe3Zgi4rnuE+kM=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=nMst0V7OYEAyC8fC3QXtcSER/IkS535cZW4ckaBAfo/F5VGrQwSbX+u10VZmM3M7O g6bf1Fr2UZt6v3lFrGAOa696qcmh85emTSvLmbmYyidoLPALlkhgGOilmwci2YMdkh YzLYNgFLrw/8QH1cclyaTmqux+NBz7joorvYoqf4= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200505123848eucas1p2501c1d63201b46344f0c9c25ad4caf7f~MIikvJA262729527295eucas1p2E; Tue, 5 May 2020 12:38:48 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 7B.03.60679.85E51BE5; Tue, 5 May 2020 13:38:48 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200505123848eucas1p293bd4f8e4182687f88af1794fdf21c01~MIikQ7WNO2730927309eucas1p2E; Tue, 5 May 2020 12:38:48 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200505123848eusmtrp2723c02c1566883b5918bec0a927589e5~MIikQUsZF2263322633eusmtrp2p; Tue, 5 May 2020 12:38:48 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-d7-5eb15e5897cf Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F2.FF.07950.85E51BE5; Tue, 5 May 2020 13:38:48 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200505123847eusmtip1ba951b62158fea02d191fe9748a20463~MIijwjzbH2680226802eusmtip1H; Tue, 5 May 2020 12:38:47 +0000 (GMT) To: "Van Haaren, Harry" , "dev@dpdk.org" Cc: "honnappa.nagarahalli@arm.com" , "phil.yang@arm.com" From: Lukasz Wojciechowski Message-ID: Date: Tue, 5 May 2020 14:38:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsWy7djP87oRcRvjDNYd0Ld492k7k0Vj/zcW i5lPW9gt1rzvZnZg8Vgzbw2jx68FS1k9Fu95yRTAHMVlk5Kak1mWWqRvl8CV8W7yVKaCZqGK Bbd2MTUwnuXrYuTkkBAwkbi4ZzJTFyMXh5DACkaJYx8fsUE4XxglZvXOZodwPjNKbDq7gxmm 5U3rUUaIxHJGieudk6D63zJKvJx/nwmkSlggTKJp/0zWLkYODhGBUInrr8NAwswCORITb65n BLHZBGwljsz8ygpi8wq4STw/fQ8sziKgIrH6xAuwVlGBWInp10IgSgQlTs58wgJicwKF55w6 wAgxUl6ieetsZghbXOLWk/lg50gIdLNL9HSsZIc42kXizcRbTBC2sMSr41ug4jIS/3fCNGxj lLj6+ycjhLMf6LPeFVBV1hKH//1mA7mIWUBTYv0ufYiwo8SJ7w/ZQcISAnwSN94KQhzBJzFp 23RmiDCvREebEES1nsTTnqmMMGv/rH3CMoFRaRaS12YheWcWkndmIexdwMiyilE8tbQ4Nz21 2CgvtVyvODG3uDQvXS85P3cTIzClnP53/MsOxl1/kg4xCnAwKvHwGrhvjBNiTSwrrsw9xCjB wawkwrvsx4Y4Id6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzGi17GCgmkJ5akZqemFqQWwWSZODil GhilOFVVvT03p7M/SlxTk+U8+YKZvIbcTC+HzDfB+d/D+Ct2pMf883EOvSoX/H2uh+32b6t6 qlMPVP/ZfGAJZ1Pd+hXJT5jD3n89md3M0NitOSnb4vJl5sAIgWitrg0/2K+qetVaXOSwiPSy msK1fcGjGwb18aa7E26b2HXN/M15xeK/Rv7NVUosxRmJhlrMRcWJAKOcUHYlAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsVy+t/xu7oRcRvjDE6181u8+7SdyaKx/xuL xcynLewWa953MzuweKyZt4bR49eCpawei/e8ZApgjtKzKcovLUlVyMgvLrFVija0MNIztLTQ MzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DLeDd5KlNBs1DFglu7mBoYz/J1MXJySAiYSLxp PcrYxcjFISSwlFFixdGdzF2MHEAJGYkPlwQgaoQl/lzrYoOoec0o0TF7FiNIQlggTOJmx29m EFtEIFTi+et+NhCbWSBHou/SdBaIhkVMEv8nLQIrYhOwlTgy8ysriM0r4Cbx/PQ9sEEsAioS q0+8YAVZLCoQK9FyUROiRFDi5MwnLCA2J1B4zqkDjBDzzSTmbX7IDGHLSzRvnQ1li0vcejKf aQKj0Cwk7bOQtMxC0jILScsCRpZVjCKppcW56bnFRnrFibnFpXnpesn5uZsYgTG07djPLTsY u94FH2IU4GBU4uE1cN8YJ8SaWFZcmXuIUYKDWUmEd9mPDXFCvCmJlVWpRfnxRaU5qcWHGE2B fpvILCWanA+M77ySeENTQ3MLS0NzY3NjMwslcd4OgYMxQgLpiSWp2ampBalFMH1MHJxSDYyx PN37vTcvu6tttHECY8RWx7AipizR03YXlseLcKlE1gWVsRRoXHr1RycpdnlKzKFwec8Tu5V3 xZWKSi7d+P3r2giXdqmSvw05e3etbnji7csV+OpW6TwRvX8zmu5KJDyQUFaOaS9Q2r69RZn3 1az99V3ObJudN3yxjNhR0sv626jjtatLsRJLcUaioRZzUXEiAMXO7RW3AgAA X-CMS-MailID: 20200505123848eucas1p293bd4f8e4182687f88af1794fdf21c01 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200501155607eucas1p2509870b6b5f4cc520dca11888e221b1b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200501155607eucas1p2509870b6b5f4cc520dca11888e221b1b References: <20200501155649.2959-1-harry.van.haaren@intel.com> <38e4b29c-4aaa-87f8-8e3f-498d4be2fcf0@partner.samsung.com> Subject: Re: [dpdk-dev] [PATCH] test/service: add perf test for service on app lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 05.05.2020 o 12:21, Van Haaren, Harry pisze: >> -----Original Message----- >> From: Lukasz Wojciechowski >> Sent: Monday, May 4, 2020 9:50 PM >> To: Van Haaren, Harry ; dev@dpdk.org >> Cc: honnappa.nagarahalli@arm.com; phil.yang@arm.com >> Subject: Re: [dpdk-dev] [PATCH] test/service: add perf test for service on app >> lcore > > >>> + unregister_all(); >>> return TEST_SUCCESS; >>> } >>> >> Hi Harry, > Hey Lukasz, > >> I like the idea of adding this test. I checked it and it works fine. > Thanks for testing - please send a "Tested-by: .. " and we can track > your input into the git logs :) No problem, I just wanted to get you opinion first, but here you go: Tested-by: Lukasz Wojciechowski > >> However have you considered adding it as a separate testcase or even >> better as "service_perf_autotest" command ? > Actually I started implementing a new function with a very similar name, > but realized that the configuration/mapping would be duplicated, only to > have a different named test... so opted for this smaller diff solution. > >> With your changes the: service_app_lcore_mt_safe and >> service_app_lcore_mt_unsafe unit tests cases have multiple >> functionalities: they test simultaneous execution of service and they do >> performance checks. > Correct - if you feel strongly that this isn't right I can refactor to a v2, > however I expect there would be more duplicated code to manage, and > hence I decided the above approach was simpler and easier. It's up to you and some more dpdk-experienced guys. Isn't there a way not to duplicate the code but wrap it in a function? You don't really need that much, because you run the performance test after the former version of test is completed. You don't need 2 lcores also as you measure direct start of service function, which also is almost empty as it immediately returns because the loop breaking conditions are already set. > >> Best regards >> Lukasz > Regards, -Harry -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com