From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4FEA45946; Mon, 9 Sep 2024 09:42:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4392F402A8; Mon, 9 Sep 2024 09:42:21 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 9046C402A5 for ; Mon, 9 Sep 2024 09:42:19 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4X2JgK1D4FzyRfs; Mon, 9 Sep 2024 15:41:33 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 8CF9C1800D2; Mon, 9 Sep 2024 15:42:16 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 9 Sep 2024 15:42:16 +0800 Subject: Re: [RFC PATCH v1 4/5] eal: rename --socket-mem/--socket-limit To: Anatoly Burakov , , Matan Azrad , Viacheslav Ovsiienko , Dariusz Sosnowski , Bing Zhao , Ori Kam , Suanming Mou , Tyler Retzlaff , Nicolas Chautru , Radu Nicolau , Akhil Goyal , Maxime Coquelin , Chenbo Xia References: From: fengchengwen Message-ID: Date: Mon, 9 Sep 2024 15:42:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/9/6 19:47, Anatoly Burakov wrote: > Currently, --socket-mem and --socket-limit EAL flags effectively refer to > NUMA nodes, not CPU sockets. Update the flag names to reflect this. Old > flag names are still supported for backward compatibility. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > Technically, this is a user-facing change and so would require a > deprecation notice. We can do it the other way around, and add > support for --numa-mem/--numa-limit but do not expose it in > documentation yet, and instead add a deprecation notice for next > release. However, since old flags are kept for compatibility, > nothing will break as a result of merging this series even if we > didn't announce this change in advance. I'm open to feedback on > how to best do this change. > ... > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index cf174aeaa3..591028f641 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -443,8 +443,8 @@ eal_usage(const char *prgname) > printf("\nUsage: %s ", prgname); > eal_common_usage(); > printf("EAL Linux options:\n" > - " --"OPT_SOCKET_MEM" Memory to allocate on sockets (comma separated values)\n" > - " --"OPT_SOCKET_LIMIT" Limit memory allocation on sockets (comma separated values)\n" > + " --"OPT_NUMA_MEM" Memory to allocate on NUMA nodes (comma separated values)\n" > + " --"OPT_NUMA_LIMIT" Limit memory allocation on NUMA nodes (comma separated values)\n" > " --"OPT_HUGE_DIR" Directory where hugetlbfs is mounted\n" > " --"OPT_FILE_PREFIX" Prefix for hugepage filenames\n" > " --"OPT_CREATE_UIO_DEV" Create /dev/uioX (usually done by hotplug)\n" > @@ -693,11 +693,11 @@ eal_parse_args(int argc, char **argv) > } > break; > } > - case OPT_SOCKET_MEM_NUM: > + case OPT_NUMA_MEM_NUM: > if (eal_parse_socket_arg(optarg, > internal_conf->numa_mem) < 0) { > EAL_LOG(ERR, "invalid parameters for --" > - OPT_SOCKET_MEM); > + OPT_NUMA_MEM); This may confuse user, how about "invalid parameters for --numa-mem (aka --socket-mem)" > eal_usage(prgname); > ret = -1; > goto out; > @@ -705,11 +705,11 @@ eal_parse_args(int argc, char **argv) > internal_conf->force_numa = 1; > break; > > - case OPT_SOCKET_LIMIT_NUM: > + case OPT_NUMA_LIMIT_NUM: > if (eal_parse_socket_arg(optarg, > internal_conf->numa_limit) < 0) { > EAL_LOG(ERR, "invalid parameters for --" > - OPT_SOCKET_LIMIT); > + OPT_NUMA_LIMIT); Same to above > eal_usage(prgname); > ret = -1; > goto out; >