From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CD72437A6 for ; Wed, 19 Apr 2017 14:25:04 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2017 05:25:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,221,1488873600"; d="scan'208";a="91682181" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.59]) ([10.237.220.59]) by fmsmga006.fm.intel.com with ESMTP; 19 Apr 2017 05:25:02 -0700 To: Shahaf Shuler , Adrien Mazarguil , =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= Cc: "dev@dpdk.org" , Raslan Darawsheh References: <20170416074640.171390-1-shahafs@mellanox.com> <20170418102228.145971-1-shahafs@mellanox.com> <20170418102228.145971-2-shahafs@mellanox.com> From: Ferruh Yigit Message-ID: Date: Wed, 19 Apr 2017 13:25:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix PMD specific parameters defaults X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 12:25:05 -0000 On 4/19/2017 12:32 PM, Shahaf Shuler wrote: > Wednesday, April 19, 2017 1:57 PM, Ferruh Yigit: >> On 4/18/2017 11:22 AM, Shahaf Shuler wrote: >>> With the Enhanced multi packet send addition, the defaults were made >>> in order to get the maximum out of the box performance. >>> Features like tso, don't use the enhanced send, however the defaults >>> are still valid. This cause Tx queue creation to fail. >>> >>> Fixes: aea00c008140 ("net/mlx5: add hardware TSO support") >> >> Can you please confirm the Fixes line, the code modified below added with >> commit [1], and above commit (correct one is: 3f13f8c23a7c) doesn't touch >> those lines? > > Well I guess it can be either. > The commit Fixes TSO because [1] caused TSO to fail on some cases. > The commit Fixes multi-packet send since it is the one which caused the fault. > > Since you pointed that out, I guess other will follow your logic as well. So let's take you suggestion. Does it make sense to add both? > Do you need me to post a v3? If you confirm, I can update while applying, not a new patch required. > >> >> [1] >> Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for >> ConnectX-5")