From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A66CA0503; Tue, 17 May 2022 15:23:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C37E427EB; Tue, 17 May 2022 15:23:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D02F540041 for ; Tue, 17 May 2022 15:23:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652793801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=liUcnJTObXkpjr03667itX5OhI04ZvjmniXsd8nVNJ0=; b=X8lFJPqsKGbGaYqFgmpjvbwSb/NPzARNO0b/IlvWPQB58fcAx749TpvKpX30ZTt8bXa37n W9NyEmS55B5plsh5gXsxFrlcvORymxm3Vb6Is1BUZys3MCcpx1I26iJypaSoT/YDR/TEYg 16I7Fb3GomCh6ez5fEQkAPSwRfvPQtM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-126-GTpieJQ7NbGgOsjMX1sIUA-1; Tue, 17 May 2022 09:23:16 -0400 X-MC-Unique: GTpieJQ7NbGgOsjMX1sIUA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2BB9780B90A; Tue, 17 May 2022 13:23:16 +0000 (UTC) Received: from [10.39.208.44] (unknown [10.39.208.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C10711121315; Tue, 17 May 2022 13:23:14 +0000 (UTC) Message-ID: Date: Tue, 17 May 2022 15:23:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2] vhost: add runtime locking check in unsafe APIs To: dev@dpdk.org, chenbo.xia@intel.com, xuan.ding@intel.com, jiayu.hu@intel.com, cheng1.jiang@intel.com, sunil.pai.g@intel.com, david.marchand@redhat.com References: <20220511065837.1267895-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: <20220511065837.1267895-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/11/22 08:58, Maxime Coquelin wrote: > This patch adds runtime checks in unsafe Vhost async APIs, > to ensure the access lock is taken. > > The detection won't work every time, as another thread > could take the lock, but it would help to detect misuse > of these unsafe API. > > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost.c | 18 ++++++++++++++++++ > lib/vhost/virtio_net.c | 6 ++++++ > 2 files changed, 24 insertions(+) > Applied to dpdk-next-virtio/main. Thanks, Maxime