DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: <humin29@huawei.com>, <chas3@att.com>
Cc: <leweix.yang@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>, <dev@dpdk.org>,
	"declan.doherty@intel.com" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures
Date: Fri, 22 Oct 2021 15:02:37 +0100	[thread overview]
Message-ID: <c15dd791-d7c3-be2a-210b-a0c95a8a4128@intel.com> (raw)
In-Reply-To: <8cb54b7b-cc00-209a-1a0a-eb655f712b5a@intel.com>

On 10/22/2021 2:47 PM, Ferruh Yigit wrote:
> On 10/22/2021 2:26 PM, Konstantin Ananyev wrote:
>> link bounding auto-test internally creates emulated ethdev.
>> Some tests change Rx/Tx functions of this emulated device on the fly:
>> by directly modifying rte_eth_dev fields and without doing stop/start
>> for these devices.
>> As now ethdev uses rte_eth_fp_ops[] for fast-path functions, these
>> direct changes doesn't make expected effect.
>> Fix the problem by guarding fast-path functions changes with
>> rte_eth_dev_stop()/rte_eth_dev_start().
>>
>> Fixes: 7a0935239b9e ("ethdev: make fast-path functions to use new flat array")
>>
>> Reported-by: Lewei Yang <leweix.yang@intel.com>
>> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> Tested 'link_bonding_autotest', it succeed after this patch (failing before)
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Hi Connor, Chas,

Unrelated with this patch, while I am testing bonding unit test, I recognized
that there are other bonding unit tests failing:
link_bonding_rssconf_autotest
link_bonding_mode4_autotest

They are testing with v21.08 too.
I am not sure if I am missing in my environment, but can you please check
them?

Thanks,
ferruh

  reply	other threads:[~2021-10-22 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 13:26 Konstantin Ananyev
2021-10-22 13:47 ` Ferruh Yigit
2021-10-22 14:02   ` Ferruh Yigit [this message]
2021-10-22 16:04   ` Ferruh Yigit
2021-10-24 10:39 ` David Marchand
2021-10-24 11:37   ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c15dd791-d7c3-be2a-210b-a0c95a8a4128@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chas3@att.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=leweix.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).