From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: BillXiang <xiangwencheng@dayudpu.com>, Chenbo Xia <chenbox@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] vdpa: update used->flags in used ring relay
Date: Thu, 19 Sep 2024 12:41:38 +0200 [thread overview]
Message-ID: <c1713039-8244-4c2f-bb19-68208076cb84@redhat.com> (raw)
In-Reply-To: <36abff3f-2b99-497f-bba4-1958074e326b@redhat.com>
On 9/19/24 12:37, Maxime Coquelin wrote:
>
>
> On 7/17/24 05:24, BillXiang wrote:
>> From: BillXiang <xiangwencheng@dayudpu.com>
>>
>> The vDPA device will work incorrectly if flags such as
>> VRING_USED_F_NO_NOTIFY are not updated correctly.
>>
>> Signed-off-by: BillXiang <xiangwencheng@dayudpu.com>
>> ---
>> lib/vhost/vdpa.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c
>> index a1dd5a753b..8abb073675 100644
>> --- a/lib/vhost/vdpa.c
>> +++ b/lib/vhost/vdpa.c
>> @@ -174,6 +174,7 @@ rte_vdpa_relay_vring_used(int vid, uint16_t qid,
>> void *vring_m)
>> idx = vq->used->idx;
>> idx_m = s_vring->used->idx;
>> ret = (uint16_t)(idx_m - idx);
>> + vq->used->flags = s_vring->used->flags;
>> while (idx != idx_m) {
>> /* copy used entry, used ring logging is not covered here */
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
I fix the title from used->flags to used flags.
And also add Fixes tag and Cc stable so that it is backported.
> Thanks,
> Maxime
prev parent reply other threads:[~2024-09-19 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 3:24 BillXiang
2024-09-19 10:37 ` Maxime Coquelin
2024-09-19 10:41 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1713039-8244-4c2f-bb19-68208076cb84@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=xiangwencheng@dayudpu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).