From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6F1C41E2E; Fri, 10 Mar 2023 20:36:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D32D40A8B; Fri, 10 Mar 2023 20:36:38 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by mails.dpdk.org (Postfix) with ESMTP id 9704B40685; Fri, 10 Mar 2023 20:36:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PuwbiDlMJsoLFb1K9WjkRYI4kZU9uQQPjLiItKHQfANLdhLPdSBQqDsf9iZB3ybtK3SP0DaD4CBkatVlfVVAexKxmOLbaWbJ/AtFbQeWUJDQ9MHbx4C82uWNMHL13nEPUtvKR2gFkfK5hW+uqRQTUJZY4mzBQOWxXZZxLem6S3sKLW3Z+p09AbSm4gXzXTmb8Wy3CgSavUEG2bFwV/BGtIOBUtW8ro6xhmfTnb+/DSwAi2Igf89G0lEa7/U9940AxS5W+RqiBigsaaMvnMuK+oaCRngNCSQeydTRoAZH/CT1JGAFPmdyrX4bCBKKxnnr9i+No3DSTcMYXyjPCeRHug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JtxroJPfAACv+TBimzY0g1R5sN7OdK+tbT5To3kDTFI=; b=EyW7O8jDN7dU5TqUF1wZVf1uwyOMGgwpvI9gjjE5uI5lrlEBVuLGUenMjTzj2H5stwvKg9Thor7GFqc+0KKQWq68oPcODKKk2GgQ0/Mi4iEHDQekT1VC5yyUjtzh+yzukOJz4CobAYV4slmQ2K/sgaOGPnatDbmjRom1KfFt5LpQJzLVz6aYHT8+7lcYPtGguX9hei1puIbHPhTDUZr69WN8h66mrKlrzRitiTucXp3tKXdYwzj4VrfUMRMGbM0Bib7t0MmRxMnM/sgToD4tNpFhtTpZmlpOqdcYaqqs2ue9HkmtoDlLcZzPryvIdrpMPgEqbuFKcMNXDfLOIGnrvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JtxroJPfAACv+TBimzY0g1R5sN7OdK+tbT5To3kDTFI=; b=Yk/z8iZcAbcDPPcZX+Mo9zl8QOdPnbNXzSNkweA/cq54G3eOVQwUbj1nkpX7W/sjuoyvoIrksYn1xTzwek8VBt+cv1FHfbALeqTSxVZIL3DxqyGwlH7zLghLX1wHGdtsqNi+QDKMCqzSNJQvno+kfhwmQG4kGk+ItuOeg5ypIoM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB8214.namprd12.prod.outlook.com (2603:10b6:930:76::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 19:36:35 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 19:36:35 +0000 Message-ID: Date: Fri, 10 Mar 2023 19:36:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Dongdong Liu , dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Cc: stable@dpdk.org, yisen.zhuang@huawei.com, lihuisong@huawei.com References: <20230310093518.5198-1-liudongdong3@huawei.com> <20230310093518.5198-3-liudongdong3@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH 02/16] net/hns3: fix possible truncation of redirection table In-Reply-To: <20230310093518.5198-3-liudongdong3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0318.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB8214:EE_ X-MS-Office365-Filtering-Correlation-Id: ecca389a-c55a-42dd-0627-08db219ec27c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PNLPaBS29vHDkauaONKFkYacPFzgWhs/V3o1oiSwEO/US4cQ36XywDDhQ85dwezkZqIaDZIlGulHPvMyTV8URuO8ZcvMpr7PHDaakksdHXz3SI7xwI0cFF9vIEDQuw1CNaVWkSAvHJJgTTIPSdlANl4b9EVDpxPG/nRi5QF8SZd+ZNPaVaZsWBu5VqSFWrO4/VP7KmTmcNUh96IDqivmq8nx0AmxXd0JhC6eVnUB+pcr+Rov5fNgumWO/MrWLAHqNYYZ+DAXBzDrL4RSTYoXEF2/QM6ZBFBcbnGFWv4dx+TUsvfy28WFzMnrz8PFcuyZgXBFvgAb+5m8c9lsKb+jbrzeuuj9agNX6OmwnhWp7frvY14zwEg54mel00D+H47rB2c+vFeyS2fuHa8D85dFxmRNxNWe5g78jv+023juuYJJ07gkr/nwRJDdXdWT5YezpsuIFB2+q7sehRE50irRpkPLz0mu2iLw+N8/wisdeiwrWBn5A6xEUf8Z8GgNYA54Ewc5A78UHor1rhRENc00fqKDW3Q37rICm2WVgZmy2Lo+h5aJkARnoKwyc+3XvwLIuuwT/ZjAFYrkGPkGcDt/riG8sgaCQTmdNzqGfzW1u05xg3zE89AX2TfJfy8R0PSzrUkn3YqaHgJy2CxwX5pFG8M32xbiem+MRHxdPCDMfQ5M1MxuxCsCdLKebF7NyAcKvrr6N4szvaf5uDyhVs+cXxF7ZKRl3SKMP3FvHJijCEE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199018)(31686004)(66946007)(44832011)(2906002)(5660300002)(26005)(8676002)(36756003)(8936002)(4326008)(66556008)(66476007)(31696002)(316002)(86362001)(478600001)(6486002)(53546011)(38100700002)(6666004)(6512007)(41300700001)(6506007)(2616005)(186003)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUh6cWZ6eStvSXVJdmhTS1VTV1poVUhoNW9tazhOOHA2SCsxa1NBS0lsVW1G?= =?utf-8?B?d0pxVERtYWJaSzgrbW9SbWNjV3Q2d0xYdlBiRFZMcDJMUUtBZGNXMG84QWdU?= =?utf-8?B?MlRzOWxOYlBHNENwMDlPS3UwN0dDVkJGRkxYeVBrNlpURFJRVmx6QTV0dlN5?= =?utf-8?B?UmlUcW5meWVCMVVNc20yZi81NGg3Z2NsT2lSS1FycWxGM0I5SlBubGhKazRL?= =?utf-8?B?azFlUHVpTjMzV2diTm1xVHhtSjAvbmRTU3dTallCTE1oTks1YTREQWNLbVF2?= =?utf-8?B?b3JWaXlXa0lTU2JUWTZ3THMzR1N6ci9VRklWdzM3VVJGaWZlR2lyU0hxd2hX?= =?utf-8?B?NU1ySmFsdFl3YjhRVnJxNW95S2pRSmZlc0t1YldCKzlWR2JJWlJnTGh4RW5D?= =?utf-8?B?a0R6S1lGYmJPRTc5aGQ3UGJRSWlGUk9LZStxN21ZV294RHJ1cHFKUktIYlR5?= =?utf-8?B?VnJiZHVjd0wwaEtOSmRRVE1zZ21OSk4xeFJhTHFndXRRQTBBQUg0UUVrS0VW?= =?utf-8?B?dUJYaHhpcGwrOTZ6bTRZRXlScDNSQytobUVtTnY2TTQva3VtZ3JUT20xLzNX?= =?utf-8?B?Z3h6NDZtc0RMVEovSjNRL1lWK1pXZnp6ZDhnRkx3QzJMYzhPQnRiN3g2MzJL?= =?utf-8?B?SW1mRUtZUHBab3BPcEtFZ1VNLzYrR1hJRkJBNGRMZ2FkKzVqTk9PcUZwTUlo?= =?utf-8?B?VlA5MWFkc0tHM3VYaDZJOWErMmJXNm04QnhkNnlmUTloS3lGdFl6bFoyL01y?= =?utf-8?B?VG51eWt4SVIrVURUeTVFdUszY2VlVnpkdk56MkhxRzZodUFRWFVsMUpvdExm?= =?utf-8?B?NCtlb2xIY05pRWVZd1RkWER4QXZKNU9mM0M5OGppSFU1TjhuUmR0U3BOTE9F?= =?utf-8?B?K2xoYWFNbDJ2NnR4bXpueC9nU1NlOGpFZzl2Ri9uK1JjeFlGLzlWV1JsNktJ?= =?utf-8?B?V005d1hkQWNwTWp4Rk5CRWd1N29MZ2ZzRXlVbFZrdDNVamVzZ1Jablc1NGZN?= =?utf-8?B?WDk1dUU5TWVzYTZPUE9HTEpIUDNaVjdzQUxqWndCdFcwNTRrVUp2VUZQZ2pH?= =?utf-8?B?RzF6ZWpFTGkyVWhucEp3UEF0YXZKa05rUU55dTdVSFpNTldtYVFSSFVwVVFj?= =?utf-8?B?cC9WNmpKV01yYi9nOHZCMCtlSTJ6LzVocWcvVURjc2JiMFJQSUlRU1hxUEdn?= =?utf-8?B?azRvM2c1Q0VEajFHTVFucG05MTFmMWhoL01TZlA1a2c4VzM5UTYweWZDOCtF?= =?utf-8?B?R3YvdjZvYTZmWjdPNlRPYndFbXUwMXUra2s3V24zYVJjNjhSaVYvQWpLb1Y4?= =?utf-8?B?b1V0SDJEYzhhVndqMkszVmN5Uy9Qc3NKZVdzTHBITXNyK0JzL0dRSmJ3SWpP?= =?utf-8?B?ZDZrbllWOXhZU3NhZ3cvdUVmS2FlTURUSFBHdWo1U2FwcjEzQ05rMXZ1aEIw?= =?utf-8?B?WU02ZHladEZNbkdLZEN5V25hU1V1OEhTMWwya0x0aDZtT0tmK3d0Vi9UVVNz?= =?utf-8?B?ODIraWJGMEFVRElXbFhZSEVnMFFVMzVqWW02SDUrbTgwZHNVU2plSVg0em5Z?= =?utf-8?B?TzJPb2prMTJaRGE2aUJ4UC9zVisrTHNZN2Qrb1lQYUJhZStacHp6U1hBOUdY?= =?utf-8?B?YlAraFB0U1oxYkNla2pHdXgvQlZnSytzMVVxd2V3a1RvbkNvVDRKdHRlV0tD?= =?utf-8?B?Nzl4Qll3MTh1RE1NNTRQSEZSRzdaTFNEWmVsOEVab3lHZTJURDlCK2Z2VjRT?= =?utf-8?B?RDM1Wk9mUEl2b0JTTG9OQzFEZmMxdE9zWmo2UFRGcFM0VmpBK2tqZjduTGFY?= =?utf-8?B?ZUpBZmZRMUYraHFyL2ZDN2hFWk04ZGhxRTcxV2xxUVo1SUJyOGJCS0Y3NzV0?= =?utf-8?B?dzFKR0M1K1l4cUJxNmMrb3ZUYSt2NGtQaW9NVnV6aDJKdEJhVytVKzdYQ05i?= =?utf-8?B?VkcyazU2NGlhUmN1UnNhY21hSGdlSUJXR1piQTNGaTNvN1g0d0ZpU0JLa2RU?= =?utf-8?B?Tmxvc1p5RmFMbFVmeVBHMTdUQlBXbW1UTkVaQWxpYVhzMGMvU3hlKzJmNk1h?= =?utf-8?B?SExoSVBvS3g0QlVVTnFZaENNU0graitybEVkRVFVVUxkYTRKV2lVK0dIMzFN?= =?utf-8?Q?1ECV6vs6rz47aw16bmvacyQ7+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecca389a-c55a-42dd-0627-08db219ec27c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 19:36:35.6544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZHeiixCaPyTE0G0ij2Gt/eMyEqSaQupv7fR3yBEQSV+Kg0Yrltei8xxkKiHC4Gu5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8214 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2023 9:35 AM, Dongdong Liu wrote: > From: Huisong Li > > The size of the redirection table is obtained from firmware. If the size > isn't a multiple of HNS3_RSS_CFG_TBL_SIZE, the redirection table from > user will be truncated. > > Fixes: c37ca66f2b27 ("net/hns3: support RSS") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Dongdong Liu > --- > drivers/net/hns3/hns3_rss.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c > index 2011c18b9b..f6d677ade8 100644 > --- a/drivers/net/hns3/hns3_rss.c > +++ b/drivers/net/hns3/hns3_rss.c > @@ -329,22 +329,28 @@ int > hns3_set_rss_indir_table(struct hns3_hw *hw, uint16_t *indir, uint16_t size) > { > struct hns3_rss_indirection_table_cmd *req; > + uint16_t max_bd_num, cfg_tbl_size; > + uint8_t qid_msb_off, qid_msb_val; > struct hns3_cmd_desc desc; > - uint8_t qid_msb_off; > - uint8_t qid_msb_val; This change seems unrelated, I can drop while merging if there is no other change request. > uint16_t q_id; > uint16_t i, j; > int ret; > > req = (struct hns3_rss_indirection_table_cmd *)desc.data; > - > - for (i = 0; i < size / HNS3_RSS_CFG_TBL_SIZE; i++) { > + max_bd_num = DIV_ROUND_UP(size, HNS3_RSS_CFG_TBL_SIZE); > + for (i = 0; i < max_bd_num; i++) { > hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RSS_INDIR_TABLE, > false); > req->start_table_index = > rte_cpu_to_le_16(i * HNS3_RSS_CFG_TBL_SIZE); > req->rss_set_bitmap = rte_cpu_to_le_16(HNS3_RSS_SET_BITMAP_MSK); > - for (j = 0; j < HNS3_RSS_CFG_TBL_SIZE; j++) { > + > + if (i == max_bd_num - 1 && (size % HNS3_RSS_CFG_TBL_SIZE) != 0) > + cfg_tbl_size = size % HNS3_RSS_CFG_TBL_SIZE; > + else > + cfg_tbl_size = HNS3_RSS_CFG_TBL_SIZE; > + > + for (j = 0; j < cfg_tbl_size; j++) { > q_id = indir[i * HNS3_RSS_CFG_TBL_SIZE + j]; > req->rss_result_l[j] = q_id & 0xff; >