From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D18945710; Thu, 1 Aug 2024 12:02:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BF794339D; Thu, 1 Aug 2024 12:02:51 +0200 (CEST) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id 6CFC54339C for ; Thu, 1 Aug 2024 12:02:49 +0200 (CEST) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-595856e2336so3166500a12.1 for ; Thu, 01 Aug 2024 03:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1722506569; x=1723111369; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G9o0+/r66vcBb5yK0l1efjC5xP7vih+PnHzx8r/YU0w=; b=vd7A97GwgP61bH9XeuRsNJDZdsxBppLutgdcLMvAt5LGa6uQUTCkH0hqoMkmcLCx8R m2EXhpaSZQMoLs1lGeietd2IdyOXGrVcKqJjMsa5BvpDc2Nhm8zwz38aUx5P6nrn1A+g +5j0Qj9lrnXOz7WX4hblTBGPZqrethsYUIIWho7VwVr9dXXRV/alH/MEHgeMgXSZ0rmj 89cMBsKB8mLhWpgMkjtbCR11utdSQfqFGinQ+KVhrklSnSOFPBcq1WiUW3zFOJdWJeTs 3rZf6GGsZ/f7DMKFZWcc+azDknsH2qGA/uFuEfXCsCFrxQUKzPZ1NWiSV6JVRvHVcK+X kl2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722506569; x=1723111369; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G9o0+/r66vcBb5yK0l1efjC5xP7vih+PnHzx8r/YU0w=; b=xOYZjrP6ihT37qV1BQobQdCUxn4zrFcbb/5r1pGrkA9PZAps4hX/iQzJeHTUxnuntU w9+ySlfJEgu05ZQZAnQIY2Ok5fXHilPBCym7EMz3svVFShOL8/BIkEMPAEAKzVCvT6Yp a1GqlKLbUdqifAlyd3JCX0wFSzFas7gsnXtM7suQIqi98ARcoAUslT0+2wXLNORdNFrR m+AW91XgmPcYj1fQn+SsZa7tfmMHjpjfhAvFrKeHKY/IHdQHJINmmFy+PcP3zTuKFKvJ LFyXlqTTH7HeHXdSeTv7h4GRL62xKm5S5PRCYiXf+0cB6ERtyx41reuhOB4HZ4PnU00v vxAg== X-Forwarded-Encrypted: i=1; AJvYcCWl8iZ2Om2+GUpdkuHvSM7Lw2mqVSK+9biUfWpe4QnPRtUAPX75LVR77/+BRWE4Q4pl0iQ72BydQkxpz+s= X-Gm-Message-State: AOJu0Yy95p6V1pNHN8m+866P1DXKdUAT/viGqpPtmFueNws+Lry/cMdE y+CbG0zk9ODoiK2I9gtI3MCWC0e3YyK4XmWKn8zVZhX8WrZqEQFobnJYCSQQsZY3cDr1PiZ3Zlz U3ng= X-Google-Smtp-Source: AGHT+IEyonrKrXKKiCh3QDj7kxAwdm6XznI9SZfTRsv9N82e86mk3ptxreHaz8S2mE/nSvOzLBcMSQ== X-Received: by 2002:a05:6402:27c9:b0:5a2:bfd1:b892 with SMTP id 4fb4d7f45d1cf-5b77c778f42mr853009a12.11.1722506568272; Thu, 01 Aug 2024 03:02:48 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ac64eb3980sm9915150a12.60.2024.08.01.03.02.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 03:02:48 -0700 (PDT) Message-ID: Date: Thu, 1 Aug 2024 12:02:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 4/5] doc: guides and API meson improvements To: Thomas Monjalon Cc: Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dev@dpdk.org References: <20231115133606.42081-1-juraj.linkes@pantheon.tech> <20240712085724.21065-1-juraj.linkes@pantheon.tech> <20240712085724.21065-5-juraj.linkes@pantheon.tech> <2887497.yaVYbkx8dN@thomas> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <2887497.yaVYbkx8dN@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 30. 7. 2024 15:28, Thomas Monjalon wrote: > 12/07/2024 10:57, Juraj Linkeš: >> The Sphinx script argument parsing improvement gives us more >> flexibility going forward, such as the ability to add non-positional >> arguments. > > You should describe what is changed and why. > The Sphinx script argument parsing improvement gives us more flexibility going forward, such as the ability to add non-positional arguments. What is currently missing is the ability to define an argument with default value, which is added here. The other change just cleans up the code a bit, replacing the path: dpdk_build_root/doc/api with meson.current_build_dir(), which is the same, as it's called in the above dir that was previously hardcoded. > >> -release = environ.setdefault('DPDK_VERSION', "None") >> -version = release >> +version = environ.setdefault('DPDK_VERSION', "None") > > I'm quite sure "release" was set for a reason. > Did it change over time with recent Sphinx? > > I looked at the docs and it didn't. I didn't realize this was a Sphinx setting. I'll revert this.