From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0280D45D78; Fri, 22 Nov 2024 01:37:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D6674026E; Fri, 22 Nov 2024 01:37:39 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 3A7CF4026A; Fri, 22 Nov 2024 01:37:35 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XvbfJ3NChz1JCmx; Fri, 22 Nov 2024 08:32:40 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id 78F63140445; Fri, 22 Nov 2024 08:37:33 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 22 Nov 2024 08:37:32 +0800 Message-ID: Date: Fri, 22 Nov 2024 08:37:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/9] app/test: fix typo in address compare To: Stephen Hemminger , CC: , , Chas Williams , "Min Hu (Connor)" , Pablo de Lara References: <20241114001403.147609-1-stephen@networkplumber.org> <20241121182443.68025-1-stephen@networkplumber.org> <20241121182443.68025-3-stephen@networkplumber.org> Content-Language: en-US From: fengchengwen In-Reply-To: <20241121182443.68025-3-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2024/11/22 2:23, Stephen Hemminger wrote: > The first argument of 'memcmp' function was equal to the second argument. > Therefore ASSERT would always be true. > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: 92073ef961ee ("bond: unit tests") > Cc: declan.doherty@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > --- > app/test/test_link_bonding.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c > index 805613d7dd..b752a5ecbf 100644 > --- a/app/test/test_link_bonding.c > +++ b/app/test/test_link_bonding.c > @@ -792,7 +792,7 @@ test_set_primary_member(void) > &read_mac_addr), > "Failed to get mac address (port %d)", > test_params->bonding_port_id); > - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr, > + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr, > sizeof(read_mac_addr)), > "bonding port mac address not set to that of primary port\n"); >