From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF66941F45; Wed, 12 Jun 2024 17:15:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25A7342E44; Wed, 12 Jun 2024 17:05:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id B09F942E61 for ; Wed, 12 Jun 2024 17:05:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718204714; x=1749740714; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3AfCcJvYAvgFq2yAfNniyGZ9Z2Fe71x6x3tnMp78t3k=; b=UG0VoLuqLot3fFZBXu1l7Se0Ub8t3mO2ahSCP31zaYoco4H+nilYqrXp 5LEE1nhBOLUJ+F10/ilGcnrDF6A49JT/lkx08FubuMF+jCxvVJ8RomnKN 0XZXVjiT0aRgS/mcLtRJuzsqYzm/toNzI+WqOeo6g5D+vK/McZ+3nQ7Nj b2qUNwQbBenBD6o8Y+SJq+C+Mr0Fpx+uUgJ4mJTcFu1DUPcwQMGutTQj6 PyIacaGHDQ6a8RYCmAoYLBmuy7zfUlbKXYknhjBj1k7vaPyCcdMJChX1r gLAXEIpd8qwhazUPPSpuhWINqFdAt2B4d4mIRXAPFB8qgfGl/n9V2kBv9 g==; X-CSE-ConnectionGUID: QQUti38sRVue0OiBFBOx4w== X-CSE-MsgGUID: gEqbKsYnT5+2tseg3RvsYA== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32459611" X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="32459611" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 08:05:13 -0700 X-CSE-ConnectionGUID: CRuv0bTXRomsZfjfVXcEJA== X-CSE-MsgGUID: ERHZBoAqToKyjG2lH/XcZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="39925479" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 08:05:12 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: ian.stokes@intel.com, bruce.richardson@intel.com, Jacob Keller Subject: [PATCH v2 069/148] net/ice/base: be more verbose when preparing timer sync Date: Wed, 12 Jun 2024 16:01:03 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20240430154014.1026-1-ian.stokes@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add an informative error message when preparing external PHYs for a timer sync fails. Signed-off-by: Jacob Keller Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index 31d6c7cf81..81b57b068c 100644 --- a/drivers/net/ice/base/ice_ptp_hw.c +++ b/drivers/net/ice/base/ice_ptp_hw.c @@ -4932,9 +4932,16 @@ int ice_ptp_port_cmd_e810(struct ice_hw *hw, enum ice_ptp_tmr_cmd cmd, bool lock_sbq) { u32 val = ice_ptp_tmr_cmd_to_port_reg(hw, cmd); + int err; - return ice_write_phy_reg_e810_lp(hw, E810_ETH_GLTSYN_CMD, val, - lock_sbq); + err = ice_write_phy_reg_e810_lp(hw, E810_ETH_GLTSYN_CMD, val, + lock_sbq); + if (err) { + ice_debug(hw, ICE_DBG_PTP, "Failed to write back GLTSYN_CMD, err %d\n", err); + return err; + } + + return 0; } /* E810T SMA functions -- 2.43.0