From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0068.outbound.protection.outlook.com [104.47.32.68]) by dpdk.org (Postfix) with ESMTP id BBFEF7CDC for ; Thu, 14 Dec 2017 12:33:53 +0100 (CET) Received: from BN3PR03CA0056.namprd03.prod.outlook.com (10.167.1.144) by MWHPR03MB2701.namprd03.prod.outlook.com (10.168.207.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Thu, 14 Dec 2017 11:33:51 +0000 Received: from BY2FFO11OLC002.protection.gbl (2a01:111:f400:7c0c::149) by BN3PR03CA0056.outlook.office365.com (2a01:111:e400:7a4d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Thu, 14 Dec 2017 11:33:50 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC002.mail.protection.outlook.com (10.1.15.178) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5 via Frontend Transport; Thu, 14 Dec 2017 11:33:39 +0000 Received: from [10.232.133.65] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBEBXgBu024922; Thu, 14 Dec 2017 04:33:43 -0700 To: Olivier MATZ , Ferruh Yigit , Thomas Monjalon References: <20171208102830.2817-1-olivier.matz@6wind.com> <448cfe74-224b-8a25-6be3-42c70c6ac514@nxp.com> <20171212165744.v2zsffollkwj54az@platinum> <1018d643-eb39-cd23-4094-9ae2a4bcd860@nxp.com> CC: Andrew Rybchenko , , Stephen Hemminger From: Hemant Agrawal Message-ID: Date: Thu, 14 Dec 2017 17:03:42 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1018d643-eb39-cd23-4094-9ae2a4bcd860@nxp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131577248221547531; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(7966004)(336005)(346002)(376002)(39380400002)(39860400002)(396003)(2980300002)(1109001)(1110001)(339900001)(24454002)(189003)(288314003)(53754006)(199004)(86362001)(31696002)(50466002)(23746002)(58126008)(316002)(77096006)(6306002)(8676002)(65806001)(65956001)(54906003)(110136005)(5660300001)(81156014)(64126003)(4326008)(229853002)(305945005)(65826007)(93886005)(81166006)(47776003)(2950100002)(230700001)(53936002)(6246003)(498600001)(2906002)(356003)(68736007)(97736004)(67846002)(85426001)(83506002)(31686004)(76176011)(36756003)(8936002)(106466001)(105606002)(966005)(53546011)(104016004); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2701; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC002; 1:lFWtlIL4S9ne+oputwyMMnu2GXfAXczjtgePi8RS8nH1pkw6h0K5vcMzxIH4sglD66LKMyEXv8vl4w0nVv9oWHn6C+8wqKtAc8KVceqLgps1xnzdWQmhYfvjSsqQ+SUs X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f85417ba-98b7-4218-cc0b-08d542e6873b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:MWHPR03MB2701; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2701; 3:SK9pibFHfCLxT0z6QuOnS/LnjqS6CaLBCIlWhY1tKD6te+r/vYBWoHzioMQfIReOSBrxwai6mOvP8wHSy8xn2SFO+d5AI/kTz34OYVcc3anXS/pEddz/bg/2bEKC51jDDt4mJ1FaoqVEhFzN7J2BLoJXUHIQ6zhD5qVlKP2/p/cnqBqdh9gfgywcpej5D/8DV1AzjMdjNpF5yAEjdFj1JW82IvV97/WY2F0zy5+iye12Ox5wHCIvWMvfT4UyAFPSBvnOzpDj10mnhmBdzpQEFj3vew9U9ZtxjyIz2XmVGwYEszYkBLhH0MBCf93OgvJEMuKSlpoEhU3D6j9hI1LB0dQ0k9y2qFCxCy7JafnV9E8=; 25:DL/dEhdhOput7dnWEk3wWPoCpzNt6Ty2AI5B6tWOkitfnje4Mqge0Q18Fy98d3vt5UT8vHQGcBbzpr5dTbOIxEagMZv8uqLyR/iAOhlSpZZplta4RSblIk76RBvIxurjN6FCHeIgjeAMXa+mQpQwkojJhbgHjeRsXDf/GClQWtU5UfRPXRTyTzAe5BtzfYl2PDhwXOplM+0RY5bqJAjANrn+7Q7puhSoU8MH/1ihQwCKe33M61ltbraY6+uuR4aDUYc5T1UOR4k8BWwolm8+bkRS7Yfzq+nO7HCyxA5fxAy2hwnLJZ/p4pMwxiEdorgj/UiFwR0Ohq7UrxBcc6Brcg== X-MS-TrafficTypeDiagnostic: MWHPR03MB2701: X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2701; 31:jTQTcKRZLz6XmuDSxuFBWUPVY9YJpSqntEVL+NswPod4xgnkBXqUZOukYxQOfHXe/O09HBaVHFvHEa4KSab87Oz1//ZIWCP3q4t9p1fxGQwEA/cH6fB9tZ82u41HKbDadRuhiFPPxo+tEjHuHPKwaOociHZUfQmNPMCCUyi9Pd/P63VY9VNOn4/utRO46x5j2ZRRp86r4IcXy9hSM8Pl/tVywU6jnuIh451FOOim648=; 4:AcdtesVJbGAZmcBCqGyatSUcY2mXXChvGQHXG0Nr3Eg3eO2vv4es3TQmn/3HTuOY6Jtus2RyzVakA9OY2uBZTkCMlPp7mx56A9buGwqf/SAQhvwoLL3RrrDmEUP4VrmgbttXHfxT0tOrs8+NOfiIMbe43hatZzqykJFazD7lYj0LVvxF5o717qx2u6J0S2zQiIpwg3Vhqj0Tx7pzKgxiALCrZGXAVykLvzDt4lA7jQbxeGKXDaBjdXRvHJMS05IJzzp4y+IPxWgk2Sw2Wrzv9cJKX0OAOyjV2vtXFNQcxPNAOSwtkqlOUSSK/27lz8au X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(5213294742642); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3231023)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123559100)(20161123561025)(20161123556025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025)(201708071742011); SRVR:MWHPR03MB2701; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:MWHPR03MB2701; X-Forefront-PRVS: 05214FD68E X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR03MB2701; 23:ZRAuLKLi2BQGQLqdGdq5PVrehnclJ/ibo+JYR?= =?Windows-1252?Q?UYTKkYiVL2ilE/O6LvU/H/q9fYftD5SyeWuNYP6JdeMLBtzF2DYzv7Hb?= =?Windows-1252?Q?QdHmk3FAg9lrvWwInK9mfp5OUb8B7GA7JzQnFd9rDPnV1JTibHYce4G0?= =?Windows-1252?Q?6/NALuw5jC6X0Jh7yoP8alBDo+aJ8UaccU101AF6Mzr6+nLQXJgSHOrh?= =?Windows-1252?Q?Qn5ezq0Au4xDr6BAfV80SfbHhBL1QcMV6zFzPNk2FcYKSquB7+FAHeAk?= =?Windows-1252?Q?VccVZDom9spI5D0Q4CQs+I6J6kpTNHKKjQs/wrXG1SuzIGC/k2QSAAN1?= =?Windows-1252?Q?x5zfa7H6MuA/4OEmLSq0FkxRJUiHWK6P8KtT9G4EEtESm7GhtKkSQSUJ?= =?Windows-1252?Q?922cUuifzZcEFvs8lar7aQ0f6CmzYk8x9fot/Vwh7SnGh2rJ47MtlGqm?= =?Windows-1252?Q?CopFXfFTvaj/qZkw8/kIbxi/RUPMuu0YlmfvNrNUjSg6DQy1mcRHYPLm?= =?Windows-1252?Q?uBXKAsPlC2gll8ilMNnlWtNZd4M8R4ZMFz1j/ws+XfvJMkcliZLrt81i?= =?Windows-1252?Q?whuaiVUmburDzw88t7wrEgCWiafSKeh/9k3i66+HkgnNoQWqHS4kto8S?= =?Windows-1252?Q?NUn6GZMHL7DZ5XO1jX+sMwOnJfzdQEAVlcA+K2YJT7uKP60h7M+FW4wI?= =?Windows-1252?Q?wLOhAo1NSd1pE09kAj8/VZMOR5z2K0AotVysAUts/W5dhuQJyXl9rJy7?= =?Windows-1252?Q?oD1plIqgGEl8aDX1bvrywnHBB+6hmr/VScoGwmFH9r4y41xWLcBaNmUj?= =?Windows-1252?Q?qWOGKT9R7HEnu9zkwmdEr4vxUSUE+WRrEvgbh4UMPV0KhYEcWYh/gnHS?= =?Windows-1252?Q?tS7pUpPguQMSD/gk2LnstmgEtgfFZaXZCLOHy8V/tgglZuQgcNRsB3n4?= =?Windows-1252?Q?+dAmTlGHNoGQbx1RZ5y2UtlsZE9wIhd2lQ8THDDx/8exFeII1RTCCLoa?= =?Windows-1252?Q?ahlRHnDeDH1BfjWaAEhLplbuH2uEywfYrjo/JOzeL6rN9G2pG4qwW5O+?= =?Windows-1252?Q?kX87egJ1CoWVVFtyA/E9b6TIU2TNoLSiDlCZru++HqAq07KgelAiSEfl?= =?Windows-1252?Q?d1YTXxFHPP3twuT6RN2pJATawa4DCcT3JQ447R/ZqADZgBqQzjw++qgv?= =?Windows-1252?Q?inB6jsXgsdpda3ayWgP2BwBDWxZ4/RzEzryrSS8uND33XyqYbK+7lNCz?= =?Windows-1252?Q?Q18QdWONg68o2+3t62QDIsauPYP+xL5tVESEe7vHBQTHXB5ay/J7p8Dq?= =?Windows-1252?Q?uDsVRRnCL44RAuyw9TAEL+XkZnNUPmW/P1OsBckvsMHhl3z7tdHQLwvw?= =?Windows-1252?Q?P7VGm9dpMMz8fo8R+u2B65oSUQ2iHjg3FJkatRmkVcC6+boOq0bBFCYg?= =?Windows-1252?Q?zTe2mxH6GU22b+G5wY0hmNQAl9tpDri5WZcIEwHlTtjdAjBR1XQAQ5/E?= =?Windows-1252?Q?kBQIM/LOiIPO1Wph1HWKx8MeHWx?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2701; 6:Yj8EcR7ShGT2g32iXX5jvw10r/fiEQsDSSeZbokYSa2iO2Iy+vhIjkACeN6DJ4HV5Q4ZccICCHoVLKCiKL3hCwu45wc/LZmxLRo1TwWHlurRuwwm6SYEnWKyFwzXqr/9STUICbKNZW+VygjunYLFHktsgVrEdOFognOG4Ai/l95nujjMT55JxqDv3addyhDHvKfPoeRZkQ6YmmUNkRKrIZNACepD44wfJixFCF0B8b+/PiVZFmByxywdvQN2gcgt0lHKX28pM72D7ZEnzGhXgVaxpTfsSFXmBBDxWl01nwxfDovuirCm8bcn2fpVGTBMY50QWV7WHTsiAijgyvwNJT45DblnkEA/f+sB97tSdj4=; 5:DkPzD1Z6KTORmmn9weB7bvURS45AFO6EtfxmQmwTwcYXwTeVa70s6Vh5nLLz5t9F0drjJ+pxIN0n5O70AzNhjbe8CsMINRoz5aB4ZzGDzi3XD7dGW/99crQzWJwP9X3h7qcvxMwPuN/Uqa7evWx7Kz96ZJTw4f1ecMvUL1srwcE=; 24:uNJqKWChrFz/n6P282Z8/htfskiZB7k2gOVXL6vFiRr1XK8t5atWtx3bEXrSqDr+L765KbzCqIRhqYgkJhm5BFw1MzeZggCVVSqk9Q8jVYo=; 7:JBl5UnRC7HZsucTvNEPHJPsX1D0U1xC09bYQAu0Blf5Pf0UbD/8vqVYslmZRXaZyG+1PfxieytViBFNAaqdiKs+ueRoSdvORZc/9MXCwGNLyx1r9Yb/sNik5gcpq62qQ4DTb5PzTxiNyzJSQTWI7tHMFmggraqUxFNqlHI7hoR+sEeo8KT8yKOO0k+3x0Pm6jAVvr7IPFJJ9PnuzP+5jwnwdEv1rzJmq2jX5NCTjGi4LyWG1oUoisv+K3oyQlpzS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2017 11:33:39.7991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f85417ba-98b7-4218-cc0b-08d542e6873b X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2701 Subject: Re: [dpdk-dev] [PATCH] net: update licence for network headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 11:33:54 -0000 On 12/13/2017 10:43 AM, Hemant Agrawal wrote: > On 12/12/2017 10:27 PM, Olivier MATZ wrote: >> On Mon, Dec 11, 2017 at 09:56:40AM -0800, Ferruh Yigit wrote: >>> On 12/10/2017 9:27 PM, Hemant Agrawal wrote: >>>> Hi all, >>>> Most templates are showing copyright first and SPDX later i.e. the >>>> typical way for writing the license. >>>> >>>> However some projects has followed it other way around to make it easy >>>> for tools i.e. the TOP line. >>>> >>>> I agree with Ferruh that we shall follow single convention. I will >>>> prefer to do it in following way to make it consistent. (I will also >>>> fix >>>> my change patches). >>>> >>>> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER >>>> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-2 >>>> >> Copyright (C) [YEAR] NAME-OF-COPYRIGHT-HOLDER-3 >>>> >> SPDX-License-Identifier: BSD-3-Clause >>> >>> Stephen mentioned Linux already has a defined syntax for this, unless >>> there is a >>> good reason to change I think we can follow same syntax, what do you >>> think? >> >> As far as I can see, it's not yet integrated in Linux. The latest >> documentation I can find as of today is: >> https://patchwork.kernel.org/patch/10091607/ >> >> About the first line: >> >> """ >> The SPDX license identifier in kernel files shall be added at the >> first >> possible line in a file which can contain a comment. For the majority >> """ >> >> Some recomandations look a bit inconsistent to me, but I didn't follow >> all the history: >> >> """ >> C source: // SPDX-License-Identifier: >> C header: /* SPDX-License-Identifier: > Expression> */ >> """ >> >> > > I tried to study the other repositories using the SPDX tagging e.g. > uboot (http://git.denx.de/?p=u-boot.git;a=tree) and odp etc. They > followed the syntax of copyright followed by SPDX. Thomas, Before I rework, What is your opinion w.r.t tooling in DPDK w.r.t SPDX. I saw a patch for checkpatch in Linux, which will also check for SPDX presence for any new file, however this patch only checked first two line for SPDX presence. (currently it is nak for other reasons) https://patchwork.kernel.org/patch/10053699/ If it makes easy for us, we can use the SPDX as first/second line convention. regards, Hemant > > Also, typically all dpdk files starts with "/*-", I am not sure about > the purpose of the "-"? > > > >> Olivier >> > >