From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09CD7A034E; Fri, 21 Jan 2022 18:09:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C988B42772; Fri, 21 Jan 2022 18:09:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EE5ED40040 for ; Fri, 21 Jan 2022 18:09:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642784966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yk8wNdWHlOXkZAU3vdnGoDoitrU1ncW/fwPVGDF3ymg=; b=PnYnMEmm5UvbXl9zaXZ5q6j+nc+BTZCubYLV5jvN1ZiZ2kSoa1bL+dclFSAoca5rREZfQh Nva7W5vpjrZUEkdNpN7p10VzsKk8w4uwieayBZ9zOOT0X8BdJlh9447hZw9wqlcD0kPykB +xEfoJc5QgAKKxSCFatJqew2pMaiO4w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-642-ylk_Fgx_OeCBdmXTGwr-rg-1; Fri, 21 Jan 2022 12:09:24 -0500 X-MC-Unique: ylk_Fgx_OeCBdmXTGwr-rg-1 Received: by mail-wm1-f72.google.com with SMTP id o193-20020a1ca5ca000000b0034d78423625so8593468wme.3 for ; Fri, 21 Jan 2022 09:09:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=Yk8wNdWHlOXkZAU3vdnGoDoitrU1ncW/fwPVGDF3ymg=; b=bQgV8KtFucn1LQTontxWuI3ftMb4sbxox/JYgQbf+NPgfkwvPrxLSBqcdUNFOOlMnp xWXYBcIdubG7cMLK4R0QPi9sGsumynDVUwR85YXD6nWqQFU+3Id5QgFqkrVCBKTAoAqN MrvVbiwSJs04kJ8hobYXM7LdsmjfdG00u4L7CSCCvopUOIoqB/aAVDzFnOXRaHD3dYVZ DZ2YdcrUQhTaAGNdmGd10IwDqmn/dWC1VzZgVjLiFl9J8ThakT50cN9cvTB1yZRDkOEC a/oLzi0ECxGvX0s7aNYDEVFppLVPAbBsXQqaLj/vK8B8P/Fgu4AjC6hdvNI0lvp7hzkX uV7w== X-Gm-Message-State: AOAM533L5hZsgFPS3XN4KvmvmcYV4TYNNMorNITeueoDm/781lRFGaBP Vn1pKQyBsBjApdrVua4ZEn+zmE8rU6JOEu7MTu9k9g8qfDHdYpcuAzadIW91tSpQuzjF5ZH5fPu tNBo= X-Received: by 2002:a05:600c:2299:: with SMTP id 25mr1573220wmf.52.1642784962998; Fri, 21 Jan 2022 09:09:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTaUcAukjfxbkX1SAfGWrdJKaQUZXQ02JXvKUXNY+VyWshxPuz3uRDuv+/tsUxZKFgNsrlqw== X-Received: by 2002:a05:600c:2299:: with SMTP id 25mr1573208wmf.52.1642784962858; Fri, 21 Jan 2022 09:09:22 -0800 (PST) Received: from [192.168.0.36] ([78.19.108.41]) by smtp.gmail.com with ESMTPSA id f14sm6765436wri.44.2022.01.21.09.09.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jan 2022 09:09:22 -0800 (PST) Message-ID: Date: Fri, 21 Jan 2022 17:09:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: Xiaoyun Li , Aman.Deep.Singh@intel.com, ferruh.yigit@intel.com, olivier.matz@6wind.com, mb@smartsharesystems.com, konstantin.ananyev@intel.com, stephen@networkplumber.org, vladimir.medvedkin@intel.com Cc: dev@dpdk.org, Sunil Pai G References: <20211015051306.320328-1-xiaoyun.li@intel.com> <20220106160333.762686-1-xiaoyun.li@intel.com> <20220106160333.762686-3-xiaoyun.li@intel.com> From: Kevin Traynor Subject: Re: [PATCH v5 2/2] testpmd: fix l4 sw csum over multi segments In-Reply-To: <20220106160333.762686-3-xiaoyun.li@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 06/01/2022 16:03, Xiaoyun Li wrote: > In csum forwarding mode, software UDP/TCP csum calculation only takes > the first segment into account while using the whole packet length so > the calculation will read invalid memory region with multi-segments > packets and will get wrong value. > This patch fixes this issue. There should be a 'Fixes:' tag and assuming you want this patch backported to LTS, 'Cc: stable@dpdk.org' too.