From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05667A0C45; Wed, 6 Oct 2021 10:51:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 893F741101; Wed, 6 Oct 2021 10:51:36 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8569A40688 for ; Wed, 6 Oct 2021 10:51:34 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="224721448" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="224721448" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 01:51:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="458350714" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 06 Oct 2021 01:51:32 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 01:51:32 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 01:51:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 6 Oct 2021 01:51:32 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 6 Oct 2021 01:51:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QCUfa09DbHKR6Hc78sDZGfkNopF09nsKoq1WsmW0+RnycIC5S/OR0E2IKp9s+p4IqIABlaYvYyS7FiI9IBjcQtdEBFy5jE0fO3IEe9xacbfHIcpAZ6of3OiQcEIvtRl2ksD5QMnrM0WxzRZl5pzcCPXP/5XontWEsvwWe3iHqNHppUVJlqnqntQ/B/06ti1hiMfKECJNuZ4bi7VVoak0T1NmwM4iZbNhMBmumnwiEtO1SutM/DZ9q7EFv0v314So4f3UTOdvtyTIgARWhAbT4Eaj5/1v+MermQASNH7dB5ck+egJy1uKVoQLQ+SIwHANzE4qzpoVxeut42oYsgXHlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=edYXrZnga6hHs4uPdkteU7uNTVE4RKZX/xzJzyR9hsg=; b=dIcQeD84QJiBA5otWuMTsK77cMp9MTRXGY4FdDBezozVkgb/m2enaoEondkQx7SEhMUJg5PeueWX8FuWesJ7w6Dc/hFaPgibGM+unlXBzfl9QJ/kChnVwywEViXncEJt2ixT+iyc8/z8LAeWEuSke81mZ3so1ukHYJLmWXYiGKtWOC0ds1Crd01DBXqE15r5uzxZUCrx6YdOMtcSS4bWmUos3KxjOkVtTidmooGVDmebCdON8SVhi/nl38xP84qU41JtwhAUn/A+GGE5ZB6IFhc2svf2IJXwZWApULZvbt53H6CBsnE1+VaEDx1/akswyappKlXMyjTIXt6+KN6Vnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=edYXrZnga6hHs4uPdkteU7uNTVE4RKZX/xzJzyR9hsg=; b=mOcUJ8TtZP0hpQVUDVhTAx/vSEp4ASyq396IWArbWnPdyYh0vuVwSPQLWUsaOkJucsHh95EY1gcBY5GuBUB3ILp9DzrNi98SDiLBpbTzxRfJcj8kK5skLlzrC+Pe0rqzL9Vri8h5xbjLz1GlSgttAsCe1ptZ34SQUJfpENBDy5I= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (20.182.107.83) by PH0PR11MB4918.namprd11.prod.outlook.com (20.182.124.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Wed, 6 Oct 2021 08:51:29 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Wed, 6 Oct 2021 08:51:29 +0000 Message-ID: Date: Wed, 6 Oct 2021 09:51:21 +0100 Content-Language: en-US To: Andrew Rybchenko , Ray Kinsella , Haiyue Wang , Qi Zhang , Xiao Wang , Beilei Xing , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Maxime Coquelin" , Chenbo Xia , Thomas Monjalon CC: References: <20210928154856.1015020-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20210928154856.1015020-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR01CA0011.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR01CA0011.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Wed, 6 Oct 2021 08:51:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e6ab8b1-52ad-4162-146c-08d988a67d10 X-MS-TrafficTypeDiagnostic: PH0PR11MB4918: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R0WSsnwshR/QVACaHHrF9ZKxD1+vytEONedjVC2gnizzihIW8seZ+HeSY4fX/h4UwIQCJRLPmYvChQNyIaH6Dz2+1Abv0FCVObKAM2MIJGU1imte6sBl0ViwXQOxoxGyK+eY4W6e1v9IPiDBWP+McEZd58OTt1UPOsXIRjshdRFBiio3E6Rvt2yQOZrHpGeF2mmrct8y1vmd+XJdGTWr1t4bzBalgkcDMySl2iICYjSpyHNPuTkFfnT4dW/D4x8L2Tk9q0awOKfYF+S8ccsWJwOsKk1HXgjARSYXYOfTFW0yyn4Y6wGO7+VHy9NtoHEtmjTQ/3+6e1s2w8cxMAS0b5tq7nesD8KcpvfHNeoAqYZFCYzTUWgRI9WJQCG/479WVY4WRmXmU6mSxlNv7EU+pWgMXg8Ep0a3I8sbK6vnEfnyuMEvLIVBoGScWbX8+4Mv9deK4V/1WwYHIrt4mqcUI9DeM8CvaCDGTHLwiKWo5v3Lvho2l6UDDlHmQrhfc9rs2rTWdheT9WBVAloOc0oldnFLtjUu1fkDnr8hvu5L7iaoAPcFnmEyRBcA/lrQF3x9ZTKoaib4ypGJ/mUXhJvq3aX61TA7MWhP86BSMBtM/usG4phKxvKXH5aroqFP707Cf1zmKfN/FNxbIvO5fShTTRq92LRBc5T548orT/k7a4+v0cnBSoewmSt3e1/6L4FQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(2616005)(66476007)(66556008)(316002)(66946007)(16576012)(36756003)(956004)(38100700002)(110136005)(31696002)(4326008)(508600001)(6666004)(6486002)(4744005)(44832011)(86362001)(53546011)(8936002)(26005)(31686004)(8676002)(921005)(5660300002)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnEyN0ljejV1NHBxNE5Laklib1NOMnZMQ1NobmZxZlFQR2VGS081TUZ1VzZu?= =?utf-8?B?U3lmbW1WbHkyczFGenBLdFdrQitBU1NhRXNyWTFLQ2trWGJVRlo2anF6Mlhu?= =?utf-8?B?TGhTcGErSk51NURhSTV0a0JyNmZ0SHdlVjROM2lhYndzK1pGOU1USm5Td0Y1?= =?utf-8?B?dlM4WVVEV3BKMWlERG1SekNKdUVoeXl6NERxL21mV3VOajJ2bFZldWxkaHNN?= =?utf-8?B?M2JxY2lTNFpWYjNMOXc4OFhVSnlqRVkrQ0FRVm40ajJlOTJIZGNleFVaS1I1?= =?utf-8?B?eHNGYWFMU3hkTE5LSGNDN3paYnQ5NWRLOFNFMXBIZnp4Z2JhNWVFWFYvSDRZ?= =?utf-8?B?aEF5WCtyQWQ1YUNuS3d3U0l1NGFhZCs2aXlQbzlSWWY0M0FSOEJBajdSaVVv?= =?utf-8?B?OTZNTkNnTUxaNXZrOTAxbWowRlZWdHRjMVhTOWNkaUtwaGt3VUpudHhNQnZD?= =?utf-8?B?azlQLzhHcThjYndEQ05yWU9qVjUxcThPWmxYRzlzMFgxQWtVU21MVElabEtz?= =?utf-8?B?MWlSL1RkOE9wMDVoQjF1Z3lTRldMZ3hhR0t3U3VOODN3OWxjWXpUcWVjd29O?= =?utf-8?B?Q3ZYRTFlMW5ZRnQyVXJXS0RhYXRuSXRzLzJwdDNhWkFoYU9MNDAvckZJa05W?= =?utf-8?B?TitoZlFlZHNMRGY0K0tsYlBMaE5tS3Fvek5UbHo3UjJrTFBsYTIvb296cUhH?= =?utf-8?B?QkNxZSs0QzkybHhrdXdmMlNRQTlOMVRYdFlsK3NDYUNsV1g1K0FNK3NKVzNh?= =?utf-8?B?ckQ1VldmaWx0M0dLR0pKdTFnWFdETHg1MmNtTTZzcjE3bUlWZytmRUlNRm5R?= =?utf-8?B?SnZaRStwbm4vWEh0b2VzMFJwalBFYzNVQnEwdWY4UG1UeVpTZStsSW4xZTJR?= =?utf-8?B?ZVhkdzAzdXRraElvT0pVUUVTaUNvWnZvWW8zZk1wUUFWL3ZFMlBscDdCbDRu?= =?utf-8?B?SHZINDJia0JudXB6d0tCaS9Wcm5LcWpydktqejZoTHhBamtScW1POVNQTnp5?= =?utf-8?B?WVNBSHVvTllWRFRKY0NTTmVRcjhYdmxqMVZabk5NWHFjU1grUzVDOHdiSXBJ?= =?utf-8?B?RUNvemtYSWZHbnliVWpOSlpPTmcvR0xUOWR1Z3dYNTNLNGhjekJxK2NjbFBr?= =?utf-8?B?R2FrcmhOb2Nmb2FqRDJlc1A3R0hxaVQ4VUUyRXFydVprdVprMllzUUdZckRH?= =?utf-8?B?ZDZMZ0p3RmozVkdGQTFjL0pNQy9HcWQrM2YzWFNSbnBiTjUxNjM0WnM5WGtZ?= =?utf-8?B?Nm9YVDcwNWR5ZGdWVzBBQTZhTW45SHkxTnF0NDJoUWgrVE5xaG11VlRVTmV4?= =?utf-8?B?OVpHVnJUbS9vemRsaUZDWmwvN2FlNTNvL0ZpL1lLVGpiTUp2cm94bEJkaXpQ?= =?utf-8?B?ODZLKzNJSHhFeCtPckYrb29vTzdOOGdDd0t3Yno5QzNQbFpmNWFjdDJ0TFdU?= =?utf-8?B?QldiU09MZ0NCTm82aEszYjV6b3hOR0tsS0tjeGVpS2NlaW9GVzM4aHZlbUN6?= =?utf-8?B?VnJtSnpXSzRxQW9DUXhmWmttczBkcGdlcHI0K1JEKzZ4ZVh0V0pWcGQ2ZENr?= =?utf-8?B?bGNIaEVpZGZnZk5PZ2M5WlozTHQ0Tzh4TXM2WjY3dzN2akhvcEJNZXhEdGh5?= =?utf-8?B?b1NlV1pvR3pHUXRLU0x4dDlqR20wcVExSU12TXI4UWs2b1JBbkhJNmlZTXBW?= =?utf-8?B?elFZeFhrMWZCTVBzcmtYMUZhUnF4TDR5UkhrZkFYWGRIZlUvYm5waHhVbzFE?= =?utf-8?Q?FINM6rI6VqY7v/izapa2Nr8e9xC4o7besHDSmgZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0e6ab8b1-52ad-4162-146c-08d988a67d10 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 08:51:29.6388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c/hy8PP4Q2MKIjEjsXUm320OXjdZmvpvmXJAmu6103Y/njCBmEWUhtX2r/z+coVfPPdmKDivkKfjebscB0JyAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4918 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy Rx descriptor done API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/2021 4:48 PM, Andrew Rybchenko wrote: > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index da1633d77e..c82089930f 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1894,7 +1894,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) > } > > eth_dev->dev_ops = &virtio_eth_dev_ops; > - eth_dev->rx_descriptor_done = virtio_dev_rx_queue_done; Checking twice, should 'virtio_dev_rx_queue_done()' declaration and definition be removed? It seems there is no user of the function except here.