Re: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/3/2020 7:20 AM, ssardar@amd.com wrote:
> From: Sardar Shamsher Singh <Shamshersingh.Sardar@amd.com>
> 
> adding below APIs for axgbe
> - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping
> - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping
> - axgbe_enable_rx_vlan_filtering: to enable vlan filter mode
> - axgbe_disable_rx_vlan_filtering: to disable vlan filter mode
> - axgbe_update_vlan_hash_table: crc calculation and hash table update
> based on vlan values post filter enable
> - axgbe_vlan_filter_set: setting of active vlan out of max 4K values before
> doing hash update of same
> - axgbe_vlan_tpid_set: setting of default tpid values
> - axgbe_vlan_offload_set: a top layer function to call stip/filter etc
> based on mask values
> 
> Signed-off-by: Sardar Shamsher Singh <Shamshersingh.Sardar@amd.com>
> ---
>  doc/guides/nics/features/axgbe.ini |   1 +
>  drivers/net/axgbe/axgbe_common.h   |  29 +++++
>  drivers/net/axgbe/axgbe_dev.c      | 171 +++++++++++++++++++++++++++--
>  drivers/net/axgbe/axgbe_ethdev.c   | 169 +++++++++++++++++++++++++++-
>  drivers/net/axgbe/axgbe_ethdev.h   |  16 +++
>  drivers/net/axgbe/axgbe_rxtx.c     |   6 +
>  6 files changed, 381 insertions(+), 11 deletions(-)
> 
> diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini
> index 0becaa097..b7b4dd992 100644
> --- a/doc/guides/nics/features/axgbe.ini
> +++ b/doc/guides/nics/features/axgbe.ini
> @@ -11,6 +11,7 @@ Scattered Rx         = Y
>  Promiscuous mode     = Y
>  Allmulticast mode    = Y
>  RSS hash             = Y
> +VLAN                 = Y

There is no "VLAN" feautre defined [1], but "VLAN filter" [2] & "VLAN offload"
[3], and in this patch I guess you mean both.

But for "VLAN offload", I don't see the driver sets "PKT_RX_VLAN" or
"PKT_RX_VLAN_STRIPPED" mbuf flags at all. And it doesn't use 'mbuf.vlan_tci' at
all, in both Rx & Tx. Are you sure VLAN offload supported by driver?

And for Tx, driver still uses 'PKT_TX_VLAN_PKT' which is deprecated, can you
please replace it with 'PKT_TX_VLAN'?



[1]
http://lxr.dpdk.org/dpdk/v20.02/source/doc/guides/nics/features/default.ini

[2]
http://lxr.dpdk.org/dpdk/v20.02/source/doc/guides/nics/features.rst#L363

[3]
http://lxr.dpdk.org/dpdk/v20.02/source/doc/guides/nics/features.rst#L474