From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1E6AC4CA1 for <dev@dpdk.org>; Thu, 8 Mar 2018 15:38:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2018 06:38:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,441,1515484800"; d="scan'208";a="206541696" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.141]) ([10.237.220.141]) by orsmga005.jf.intel.com with ESMTP; 08 Mar 2018 06:38:38 -0800 To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org References: <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> <cover.1517925320.git.anatoly.burakov@intel.com> <eb142226e1e62abe5a95bb135468732131580b71.1517925320.git.anatoly.burakov@intel.com> <20180308121229.GA8660@bricha3-MOBL3.ger.corp.intel.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <c20e86f7-6154-a6a2-bf39-980d91f5efbf@intel.com> Date: Thu, 8 Mar 2018 14:38:37 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180308121229.GA8660@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 08 Mar 2018 14:38:40 -0000 On 08-Mar-18 12:12 PM, Bruce Richardson wrote: > On Wed, Feb 07, 2018 at 09:58:36AM +0000, Anatoly Burakov wrote: >> During lcore scan, find maximum socket ID and store it. This will >> break the ABI, so bump ABI version. >> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> >> --- >> >> Notes: >> v4: >> - Remove backwards ABI compatibility, bump ABI instead >> >> v3: >> - Added ABI compatibility >> >> v2: >> - checkpatch changes >> - check socket before deciding if the core is not to be used >> >> lib/librte_eal/bsdapp/eal/Makefile | 2 +- >> lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- >> lib/librte_eal/common/include/rte_eal.h | 1 + >> lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ >> lib/librte_eal/linuxapp/eal/Makefile | 2 +- >> lib/librte_eal/rte_eal_version.map | 9 +++++++- >> 6 files changed, 44 insertions(+), 15 deletions(-) >> > Breaking the ABI is the best way to implement this change, and given the > deprecation was previously announced I'm ok with that. > > Question: we are ok assuming that the socket numbers are sequential, or > nearly so, and knowing the maximum socket number seen is a good > approximation of the actual physical sockets? I know in terms of cores > on a system, the core id's often jump - are there systems where the > socket numbers do too? > > /Bruce > I am not aware of any system that would jump sockets like that. I'm open to corrections, however :) -- Thanks, Anatoly