From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA465A0351; Thu, 3 Mar 2022 14:39:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A97240687; Thu, 3 Mar 2022 14:39:39 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 0C1C340141 for ; Thu, 3 Mar 2022 14:39:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646314778; x=1677850778; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=0FYKwCGYK6uFixWrIrW9YMvSb7fwVDjzdBQ50EuAyQs=; b=feAq+lQCmA6sgRiKPgKa17PgGRIZu0MJQKSLrRf4tuf7Abz677bqoy+f BrPmsbrVeYN7G6Yt1RRRjAmNho94ws6vq51VPhio6EbXvy+P34gTIJPH/ Wes6pTsR182aWiBTh3cWPv93Nu0Qbi3jLM6ZwfNPXZNl07YvEWR8GC4vl uCpmKoBHn7mwLFm+PcSN6pvXZ/6CLfrwaCYi2uYWFVa+HhvuPcO9X3THI y+TaWD9twIccqecfKI1yKvlc1K9RdEP3MdblWfG+nBteo6BvR1v7oy9g0 sciHLby2JP3gSa0e9U+dMlKOgxFJngSKRXgOlT/wU4AZNP3SK498Y8TJ5 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="233640434" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="233640434" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 05:39:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="640186834" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga002.fm.intel.com with ESMTP; 03 Mar 2022 05:39:37 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 05:39:36 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 05:39:36 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 3 Mar 2022 05:39:36 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 3 Mar 2022 05:39:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PonXEUTdF6vPpPvy2gC7CFQCkNYoa103QrWV+EAVOeDJMYuKko3C/TZRFYY3BYzYm03Jj4CWRLFXuePtmUBc2KqRxoO4/HpmamI9jZ3Rz9knpXV6nJJUskPIMBhTYCCHgYO2k5CzxqjlhcdmgU2Fnf+UAGBr0xqN4FmJNjoCvf5lp+MJH6/OaXF8EqEgBQEYBMwz6D9DUK03M9WwVnKule470a3GrItH6K4OooHjSG8oWNeIrdfFWquq2GrbNHFXm5GvEYzck6Aw8DJuB/f83HeofiT7na5r2x3A6SlVo3qf6VGMhKAbL3SXki2QelmRym7/avD1TgAQnWwO9Qms2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=04+D+zw7nEQYpFJDrZITLhIcZatcDb5D+pA4+1nq0Hc=; b=hdOho8trmdUDKtJwJHUVOvyoC+z7pjb+EMJtmdyGdEEugZcI2JeZXsMxmEzkdLA9P95Dm4n8Ju0oclFq5JVqDaxVPr3F8f+VUS5xPX44vpl9HwtBODN5ZmR2WWCa3J7squatC/kjnSZR80vvHjm6muSWrxJ6L172ADF8JgflBHrrm3kqAwDKTlhPJjlQsk76ktAkkIO8COxahGhaJmMpKyT+LK/+y3Fa5ei5k7qTWNLwOkg2YiPgV0j5/JZCUKt0gGDbBQFOQdqaIzYtrsDx75299MEzhQNEvv0FB+CEMaYKKu3Mg01w5I6jEOpZjP8wAplzL/36jtymyKm7q7/1iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB1645.namprd11.prod.outlook.com (2603:10b6:301:b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Thu, 3 Mar 2022 13:39:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 13:39:34 +0000 Message-ID: Date: Thu, 3 Mar 2022 13:39:28 +0000 Subject: Re: [PATCH] app/testpmd: fix flow creation parsing Content-Language: en-US To: "Huang, ZhiminX" , Ori Kam , Alexander Kozyrev , "dev@dpdk.org" CC: Suanming Mou References: <20220301224739.3072563-1-akozyrev@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0429.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6041ea44-c918-4908-b85d-08d9fd1b40a6 X-MS-TrafficTypeDiagnostic: MWHPR11MB1645:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mT+/Sg6F1c657LyFr+HUkeR4zvwQVN65/dtqxCZqoMuAm4DmzCY9yY8RZaKYSjjV0mOdNNE14s9nz70J/E/xNaUYKhOofOKVJBc91L1jQlTC2oQLp8yymRGXkrAHtEGywOcY2cK2nXoivifH86C4gXtzcet9eXyabOf7LoMQ/n/BceN1qsza6h2emkY8ePWTxCGgDrVx1dsd+HRWuQu7SuEzcx9PNFXCboOkxqmHQSdsUuJAZfREZs9v4tfWowB58HlyRKYoYSjofS/bOJxipl9qYEddFPF7sN0MPmqe17T3ZZK/nkvpvrTJvMLQLhEHdWVQYPjhxEq9xCEK59hJpOYj2kDI8/E0+/bZs8yxY/UgLc5FJL/wJcG+5v3UtSPY9sE8I92aqlWCjenBFfJnBs6FKOCJ4EFPfxBYokJB/wvSbfNlIdF06ocsiUkp8OZKb7z/3w8fpUm3Kv7g3ORgJh053z3MoAPphk0wMmmA/ou/AEbDfsGk49BIOQQQPaFEk/Ixce8TyEbMuUHQtuy9hX8lxKuk37PUuaVwg+ODS/tQpo8ZPFZVOgpNYJ5hBfcyQZmj5rGlQtXNS65a3JpXTVGDJO6v0KRsFTqGPBb80Iy9Fn/TqilpVEbu5d2He4PjFDjL1CrMgwsqXgOH57fYrZ3eE5uHf4xut8ERKaAZtNbhAGMbnkAqnRpei0d1OZs2eo2wCYXLqmIDK0INH8hW7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(53546011)(8676002)(4326008)(316002)(2616005)(66946007)(66556008)(508600001)(6486002)(66476007)(31696002)(86362001)(6506007)(6666004)(110136005)(38100700002)(186003)(26005)(82960400001)(83380400001)(44832011)(2906002)(31686004)(8936002)(5660300002)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzVFNGNJT21pWWc2MjJpYis5OHBSMXdvSlRvWlF0M2lodHdjL3cycFN2NUFD?= =?utf-8?B?SEZYSzRzdTBLQ1pGdDlBWi9lWGdZN01ydnFqYU1tL2JLek1mN3h4bWpvcTdH?= =?utf-8?B?VExTNHhOcjBMMWZqNnBlWnoxdldFMUR3NXpqcHoyY2NLanJUYjJzL3NUL2p4?= =?utf-8?B?RWxnaHVYRlBjMFh1aUs3ZU5JTkZWRnpwUkFXaXVidHR4K2RDZ2lDSmZkeTVU?= =?utf-8?B?SVA0V3B5d3lzb3lGaU4wNU16ZDkyak03UnlTdXpZZFo4TGpmN0x1Unhwd00v?= =?utf-8?B?ZHpwY1p2dGJWUHFUcjNtdjFqUmM3MC9WT01MTGlSVjdBTkxOUnZaZzNURlpV?= =?utf-8?B?RG92MU5pcUU3ZVp5NDRBNzFsMjUxWEN1dFFDcjY3RGVKU2xFM3ZicnJwc09i?= =?utf-8?B?TnROKzRMWnIxNjZZbWZKS3RDOVJkSTZtdUxEenEwWlV0eEI2N3VEVFpxYUpn?= =?utf-8?B?OXllZ3VuaXR5OTdsUFdNRFJSYkRETlcwLzI3QjhweUFGa1lIQzZmOEpxd1Va?= =?utf-8?B?SEdsaXNlM1E3RTdQdnZiOVdaQlNnd2VITW1ENHJKY1IwUkhza21aU1dRTnhi?= =?utf-8?B?b3FtTVl2YkxiS3ZDUDBqNTJ4ZlBaUjZqUzI2SFRoU2FIczY3ODJ5RVF4UlVK?= =?utf-8?B?T1JJUTVFNXl3SFlOK3llYWNyWHk0bEtYZ2R0WmZKbmNZVjFsL3lWRHhBTER5?= =?utf-8?B?dXJ4ZDJIN0lsSWpDNEh2K3hjM1lCdWdFZ0NBbDlpU2xsTkNXck5OK3VVNHNT?= =?utf-8?B?TklZMm5nYnlzYmZCUVRnZWF5RGlxRmNmYVVzeFlCaG14QnpzU2NEd2wrSGJL?= =?utf-8?B?dHlhTjk3NFRNRGRkbDRhTVoxdjJtYTBKZkk2TlBTbXJWTUZzMXVzOUZ6WjA3?= =?utf-8?B?YVhDaWM5MC84TEQyZERoWExZSHliemZnem5JemJyU3N0K0hJeURmKzJmck50?= =?utf-8?B?K29QYTVUSkIzeUFTWVlab2pwbjllRFdhZG5vUnUwT3YyR3NibGVWU3c5WmZh?= =?utf-8?B?SksvUjZETzNvcW1EVU1LdlRnRm5ic08zVytscm5xNjlucXViU2RTQU11T1Bv?= =?utf-8?B?UVM1THVvOXFLNU02L0tJSGtEUmkybmpCc1VWekZHNGluaDVDZ2hzV2Y1dGdE?= =?utf-8?B?cGlYY2tEdXF4SFlpelFWY1lmcjlmUzJia2RJV1ZkZWlYRGZ5NEp4YmdaTnZU?= =?utf-8?B?NDNvclZHYkhPRk4wa2pGV2Fabi9jTTlaYjVOK0ZmTkhyMkRQaVVNQnhrNlZx?= =?utf-8?B?Q3hnNWFhSGZMVmpqWDBGNkhQNXQvd3luWnFUcTZPbFVIOS9xREJGcGduSGZa?= =?utf-8?B?bW1LRDJEUGloemRibUlpbjdIbUR3cHFjdEhhMy82R3NwVTcwMzBzdzQyN3Vn?= =?utf-8?B?OWFuUXRRNTdIaUlTdWlGaG85bVNtaTd3K29zTjhIZ1hpMGdpRldxemNuaEdU?= =?utf-8?B?SUxDYllFOFNnTk1XY1d6ekNYOXdSQ01FRndrOVFCajdHd01PZXUrdzR4QzBY?= =?utf-8?B?WDUvVVRHMlVLR2dVdjhtbDQ0bmdiVGZWZVBHZ1pCQ3JjSVBqRUJGWnZvT09H?= =?utf-8?B?SzZYalRzT3o1Y0VxVk1QSS96YzlLcUYvQVoza3pMcWdqcHk5OWZNZFgvSXU3?= =?utf-8?B?Qk9ieU5UOFpXQm5uZmJTY3ZDN1RCajR6dnowSmpsKzlPbzg0OE1oWkQvem1x?= =?utf-8?B?L1BiUUtCa1MzOC9QUHZ3ZUl0UHJwdnFQdFlKSkJDeU10TTJhSlRCMmNqT1Vq?= =?utf-8?B?Tkwzc1l0VGZhYkU5ZTF2QXhDVWgvQU1zS3JrVXhMZ2N4V0dqcUxwRGtFUXpR?= =?utf-8?B?WC9mTXFLVXEvTHNna083NG5xZ0VRRVlKVm1oV2pyL1BRMmpmcGhDWHVGb2ZG?= =?utf-8?B?Q1JES1E1UWNsdzdZYVovZnozUVZVMEhjYi9KeUFVWnJPZTZET29BaTFJTUVL?= =?utf-8?B?ZmM2Z0ZKMHpXY3IyRE1JdHlFSHlLUkJta0FuWVdQdDlWV1BidXozd0JHOFRG?= =?utf-8?B?Uzh4dXdaRGVQMllGUUlkTllyRWpnbm1GMEJEVVJ3SmdtVVNQVGMxWVVpTFVT?= =?utf-8?B?aXRCMEVlZEZBa3dTMFB4aWZmTFUrcmtuKy9iVWJFZitVdzA5OGV5ZFljMXQ1?= =?utf-8?B?dkl5emxrRnp6SjZNTnI2Wmp6dlVlcDltcDRFZml1bEhwK3RqWFkvdUphSzU0?= =?utf-8?Q?vfpwHDZekvT6HqOAMU3Zyus=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6041ea44-c918-4908-b85d-08d9fd1b40a6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 13:39:34.3397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gwIQlEx4QBhFT5fS9Iy9K9H++VJ0U8wxD7m5yRzkilnQlsZdgqLHG3zBEmjNHRb6XPTI7b3CiLH6/5G8z7JeiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1645 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/2022 8:33 AM, Huang, ZhiminX wrote: >> -----Original Message----- >> From: Ori Kam >> Sent: Wednesday, March 2, 2022 4:13 PM >> To: Alexander Kozyrev ; dev@dpdk.org >> Cc: Suanming Mou >> Subject: RE: [PATCH] app/testpmd: fix flow creation parsing >> >> Hi Alexander, >> >> >>> -----Original Message----- >>> From: Alexander Kozyrev >>> Subject: [PATCH] app/testpmd: fix flow creation parsing >>> >>> A pattern template creation shares the parsing mechanism with a simple >>> flow creation. The pattern template creation only consists of pattern >>> items while the flow creation continues with actions. >>> The parsing mechanism now accommodates both cases and allows to stop >>> at the item end token, which should not happen for the flow creation. >>> Fix parsing mechanism to differentiate between these two cases. >>> >>> Bugzilla ID: 941 >>> Fixes: 04cc665fab ("app/testpmd: add flow template management") >>> >>> Signed-off-by: Alexander Kozyrev >> >> Acked-by: Ori Kam > > Tested-by: Zhimin Huang > Applied to dpdk-next-net/main, thanks.