From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57663A00C5; Tue, 15 Feb 2022 10:19:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F48B410F3; Tue, 15 Feb 2022 10:19:44 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 638F240E78 for ; Tue, 15 Feb 2022 10:19:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644916782; x=1676452782; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=R3WXpSFgJOiaN/Q/rJfjjv/20YllOiP5tE8mRhcCxSs=; b=QzkibsRABT2EJqhUBajf3OV1WubUf5jjAaN9ZobHdlO0xKKCQuyNqaDN Xf77hOqDQlRHeUyVRThTI3LPXNsETQTvTEmZc4ChKcJ+KGxOBcxBlNmZO JrzvGoUl27wSM0CHQI28x0peep+Zz6fA08/PC2JNEogKLeZECNMotNGB5 840HGG/8qa9SHVc4OeuIYz29ehBDtnDoQROuVDp4jFT57NlWU3Pr+6jj+ Qj6yb+nMbpvy/nMQGYbtV2vRntrRxrXQnLK2LjB8CZtcbb54r0IkgqA5D RSzV5YthIhDze+/ic/iUX3Tcye0RTmB27YJjOpKHzBSUQxdD8ttr8JYlp g==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="230265730" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="230265730" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 01:19:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="544195715" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga008.jf.intel.com with ESMTP; 15 Feb 2022 01:19:41 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 01:19:41 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 01:19:40 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 01:19:40 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 01:19:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WY4Ff3hAhwa4Y5Nuhv3wMCdO7A4oa/jvZ4W2nVMUbGP5tMFOi+TfWZi9P+kQ7I8X4DfwVFb4ZZ0PA9hSI2FtY0CbD7q/NyyuOJjpx8W6qN288cQNUtfOWpOt6NEAK//hi9fM9mi0cNGbcCO/rQpqw7S6QjZj4wXS9yTZ0U39M0+GdhAoJmrpMsS6pfjL0ofPCEZOEAhNMdhmJ2bluJvh8RblConQUl1FKeygZpkoK5yOsGw4WJms3yjK6rIrw59/336CPwfPno5n1hXUj+K7MT8AXGA6kudoskIIbkz9575r2Jnyq8t0elB/QWIt/3O2kayWaDn2/nCzoQJlHkQ7Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L/s5uOw9udfSkg1tlCfBveHFgEd+/G9Na3yhc25OEOw=; b=P86e1UU/Xc2TFDQof2404wn+f4lolfGvsOU5i3fpqfvEAS5471CybdRyc/PcCKqOjrcgFzSfc3Q6Pw0tcX/wadbE/SWidx2ihlT+ebpDhHu5cPeLr/m7+4JxFCXxK7nBNbgd4u6IASSfkQ+QzNngmEJNzpPKXFQ0mJI703ZZQr3E2jSrfurTTLed7yZhlikvWn/TKTsmakvviZl3UBwdd0xVW/pTFWHY9uY9J5S+G7QN61eUaO2VAJTGSJYV1CMK1u9smQkrY8/mbfcfVQLovbINkOQisK5L+QVps6pyQ+NlDyPtbdsXOPX/m2T4X4+rCYGNBddBmsZRYLiIPJ8OSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM4PR11MB5472.namprd11.prod.outlook.com (2603:10b6:5:39e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb 2022 09:19:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 09:19:39 +0000 Message-ID: Date: Tue, 15 Feb 2022 09:19:33 +0000 Content-Language: en-US To: Haiyue Wang , CC: Thomas Monjalon , Andrew Rybchenko References: <20220215070402.265481-1-haiyue.wang@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v1] ethdev: beautify the Rx desc number check indent X-User: ferruhy In-Reply-To: <20220215070402.265481-1-haiyue.wang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0005.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d32387ce-d8a6-4f23-1ddb-08d9f0644a7f X-MS-TrafficTypeDiagnostic: DM4PR11MB5472:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X3+SBt15OmiAuNka4gSbzUebVqugx4EEYAwTSKdAJp3R4gZflZI3pRLKw8IvwuWrwgkY/R6I3GGaIUHv3VQOdtP8pQHnTOAcyVXL/D3P+S0HaM/5h/54Rp07MB663oq15lLnNnDkDFJx/Kgqx7T73Xd0oU+WjHFFX9Ukn61RM9VXfbzQAyBWoacGP2o9VOHdBu7nMBjJwf0wzem9KFQIOBQH2FHiObm+QkA58+zVNPozuAQZRewQBFsDNjIfDw2vzniSvlglNepuDrNGZBQ5gXCYh4LXm5zNwYKhkIZPQQHiyMttDwYL3aOPsXXJRRvX6ZbErJzPE9jadWkX1QFJU8OsRlg5kX3Q0qnVVUmGvw8u/lyLbvR/uz/39qYYl9hAB/AE+DPNH17GeCnIIfSxtsvP8+ucXYr5b/UfBgtP7EA1lvRqyGLT3NNGvk0n44uMzNOpj6AC8fzLnLQfF7n1oV+ylZ8WNMyWyvx2W4Kq9T2z91kTZcJN/UNstjKVKGuInMLCwNw9qJfEfKfkPmULEVQdrv+099T/vAIuKWE3d4CgoNjedpileBtD3YX2aCEucMrIPckXoJQC8T1zwYxM8A61FfsSDZHAOz1gtizgSF0CqnolnPvcZsEiO35NpvMYiQTtpynSuFYilnfVE5klQ2MH1x6PesXM5l7slN9zUgCbJTcjwokoCvmZIW7NYvIzPodwbbifYWnqY+gd9qFS2MCpDuOdy/7xdgZyrdwZGrfVVJQSGODZzGgnpLBUZK15Z/xpBRGpGCfohu54sUpAW98IwLjikvbtjCCBbg4FNO0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(44832011)(2906002)(6512007)(83380400001)(508600001)(6506007)(2616005)(186003)(26005)(66556008)(8936002)(4326008)(66946007)(36756003)(31686004)(54906003)(86362001)(6486002)(966005)(8676002)(31696002)(316002)(6666004)(5660300002)(38100700002)(82960400001)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTBvbThaL2NqUXNtd0pZb3F0QkxxSG1XTmhPY3ppSk5ocTl2RVdMRmp3cDNG?= =?utf-8?B?bnN6azJYRW1YdTRkVDNDeDFFNmN6dTV2QUlaVkdvUXY0Rmo3TTRQbE1vL011?= =?utf-8?B?amIwazhOS1J1U1ZGZUJGVlRqU1VBeDQ5WDVMZHZ2bEE0UE1DMS8wTGNEcjNP?= =?utf-8?B?cnRvZCtwMmJtakVMWWo4UmlsNXZqOWp1c3ArbE16bnF1QUtXKzR2ci92SlVk?= =?utf-8?B?MzZjMndZVDZrWTVBVFM3S1pyQk9qcmlOeitjMGhhd0ZHaGd6M2hUQmtOL005?= =?utf-8?B?SEZaazRna2IzYVFLVVRJWVVKemtIZFlxOG5RQXc1OFV4QmZUZ09QeGI2RDBm?= =?utf-8?B?WE1maWZjdS91SE56RG0waVZWUGxkcFE1c0xjd3Q0WDUxbk9SV2dGMDVFN2I2?= =?utf-8?B?MWtVbWdMSzhOa1ZWTlR0NDRwbmZIZmFyMmJzY2Noc3ZzQ1B4cXdRU1BtMDF1?= =?utf-8?B?Tys1U0tzQTNwT0xYeVJnOENPdk4rVzZRaGVKVUxOYU9yKys5S0RZVDZXZ1F5?= =?utf-8?B?Q1dWejNYem9lQWxwcitTdml1YUJ3dHFqa1RFY29ITmQydXYxcGVpaWZzd0wy?= =?utf-8?B?U1JLWTVVeGMyYXZLaU5MYmg4UGREMEZsTGswOHIyTCtHaWJSbjQzcWF5VW5Z?= =?utf-8?B?ZVNOTVdEbGZXZERrd3NIT0V6SGlPd3hZeTMvbTdvcDdsOHlwYVNjcjJ0NWZp?= =?utf-8?B?dWhzVmFwRlZaaDFDSC9KbzJOYmd4Q1ZiSkt4Y2x5ZjlkZHc4UGJ2eVY0YWJQ?= =?utf-8?B?YUxHZnJaQU5oTldIRHRPVkVqWEUxRVVVa085K2R1R3Z1UkVpQjFaZVRsZjFs?= =?utf-8?B?cVlrWk1VRjE2TlUrT3RRUWdGUm5HTTlOK3JUMjBmRExETmMxM0h0V0ViN1JT?= =?utf-8?B?dlJmSFFqSnM1SUxnaDhhMXkvbFEwWWpyRG04elVhOWxqd0NxU0E0cHpuSTVn?= =?utf-8?B?NnlyL0F6SmRKZHVaaHA1ZmMwbnE1WFVxeEF0ekRsTVBWN2Yyd09rTVNFdVhD?= =?utf-8?B?Kzl2S1lXM3B2Z1gxNUk0Y3JBUGM4YjFTQXhsQjI4N1V5TjVhY1FHejJiUUEz?= =?utf-8?B?ZmE3a01pOEYrTk5LY2tJNytlQkVFUldnSEVCWnZ3U09DRnBoaTZLZEtHRkhj?= =?utf-8?B?NDNvSFdVdVl3c1BwdlZobHhOSWNUb0p3WU1nVUp5aGhzMmMvbVBJQXlPN21u?= =?utf-8?B?ZHJxVVhka0p3ZWJCOHVPdHFyN2pQQWE2QUtKb1gwRkUwckJ6WE9pZk9hWml5?= =?utf-8?B?djNRQ01KbWlTY3NsZHZVYUd0SHB5TDFrUlZ0aVFzeWg3MTlaeG93bG43eElP?= =?utf-8?B?Z3RRL0l6VElQYmFYRWhUNFRxVk91clY1WkJNa1A3S2p0WWhlTjNvTE1uVmp1?= =?utf-8?B?bk9zcENxZ3I2VExPbDd5UWplLzJPdDcySnBzM3dqdTB1U0FhWW0xY0wvZTlI?= =?utf-8?B?N3E2NHR0SlVVUE41Q1dWeFRZQ1pBTTZhdDk3SDI3YktYaWVIVER0TXMyUHJ6?= =?utf-8?B?UVgzaitWWGk0YXJIVVFnWnBxeS9qM3VadnhKVHR5QUxhU0hYUlJ4RHduSGtO?= =?utf-8?B?UCtsNTlwUzBGcW82cURqeTF1QUxqV0RtcWZkTU5Hb0plNXVyclRGWlU1cjY5?= =?utf-8?B?eWwwUjRCOXZtdjdkcEdSWjZaZVRLUUJDTEFtV2RBYy8zSzdNTC9jN0R2aE0v?= =?utf-8?B?NHJiSDF4eEdRUXIxcTZEUHU3VTNscC9JYjVJeStiZWVPcE5Ec2ROcmY1cG02?= =?utf-8?B?ZE5RZVBBa3Yzbk02ZWtOVVlLaVNCZHBQRmtmbVlHc0IzOFRpb2ZBNkxqaUQ2?= =?utf-8?B?NmI3NWxyQXhOQTRxZ2hQM2NSUXJKbzVsUHlrZmV2YzQxei9vWlI5aHhTcENr?= =?utf-8?B?d3VEd0huelJnYTZhSDhpUVQvaklvbUlYRGg3d3NqNGpaTDFXc01CYWgySll2?= =?utf-8?B?U3MxUWNtWk9mSFV3WC8xVnNUS1BtMUdmQWZtaEdqMmRxcTh2RjFvTjdrd0sw?= =?utf-8?B?a0FyN3N1TC9hL1VqVGdmZmNpNzNFa292Q3NWUHZEZHF1bnlwY3V5R2Jycmsw?= =?utf-8?B?UENMSnNmajJTNUp1R1Nkcm9uQVlUOEIvU2l4R3pXdm8vTUt3d0NERmI3Zzdk?= =?utf-8?B?cXFSWDNUWlRPRjNpSlJsa1VNbkxwdjZ1ZE5MTVNhUllCNmk1ZDlKblVWOHIw?= =?utf-8?Q?EEqYBxTc4s71Ri/BdCuSLtU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d32387ce-d8a6-4f23-1ddb-08d9f0644a7f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 09:19:38.9844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4H1F3MGJ0szvs3d4j0mHEj8uT6CV3yFzQzDmuPVdW5cdxdwhBPqz9en2zMwBYJSTxhjdn8pYkdpr2oxmcskBqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5472 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 7:04 AM, Haiyue Wang wrote: > Align to Tx desc number check indent, which may help to understand Rx > descriptor limits member in the alignment comparison view. And remove > the extra empty line. > > Signed-off-by: Haiyue Wang > --- > lib/ethdev/rte_ethdev.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index 70c850a2f1..54f1e14c6b 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -1799,9 +1799,8 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > } > > if (nb_rx_desc > dev_info.rx_desc_lim.nb_max || > - nb_rx_desc < dev_info.rx_desc_lim.nb_min || > - nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) { > - > + nb_rx_desc < dev_info.rx_desc_lim.nb_min || > + nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) { > RTE_ETHDEV_LOG(ERR, > "Invalid value for nb_rx_desc(=%hu), should be: <= %hu, >= %hu, and a product of %hu\n", > nb_rx_desc, dev_info.rx_desc_lim.nb_max, Hi Haiyue, Initial code matches to DPDK coding convention, updated code doesn't: https://doc.dpdk.org/guides/contributing/coding_style.html And I don't think syntax only updates are good idea, it corrupts the git history with minimal gain, instead better to fix them while doing a functional changes in those lines.