From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 39D1D5F2C for ; Thu, 26 Apr 2018 11:50:41 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 821D8480064; Thu, 26 Apr 2018 09:50:39 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 26 Apr 2018 10:50:34 +0100 To: Thomas Monjalon CC: , Olivier MATZ References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1524673942-22726-7-git-send-email-arybchenko@solarflare.com> <4297121.oP7HX5CK1i@xps> <5302029.6bfcN0d6QB@xps> From: Andrew Rybchenko Message-ID: Date: Thu, 26 Apr 2018 12:50:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <5302029.6bfcN0d6QB@xps> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23806.003 X-TM-AS-Result: No--13.634100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1524736240-Mzob0y1-n9R8 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 6/6] doc: advertise bucket mempool driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 09:50:41 -0000 On 04/26/2018 01:04 AM, Thomas Monjalon wrote: > 25/04/2018 23:56, Thomas Monjalon: >> Usually it is better to update the release notes in the main patch >> implementing the feature (probably the first one in this case). >> You can also update it step by step in several patches. Yes, will do in v4. >> 25/04/2018 18:32, Andrew Rybchenko: >>> --- a/doc/guides/rel_notes/release_18_05.rst >>> +++ b/doc/guides/rel_notes/release_18_05.rst >>> @@ -147,7 +147,15 @@ New Features >>> compatible with virtio 0.95 and 1.0. This driver registers ifcvf vDPA driver >>> to vhost lib, when virtio connected, with the help of the registered vDPA >>> driver the assigned VF gets configured to Rx/Tx directly to VM's virtio >>> - vrings. >> Removing this last word is probably a mistake. My bad, very inaccurate rebase. >>> + >>> +* **Added bucket mempool driver.** >>> + >>> + Added bucket mempool driver which provides a way to allocate contiguous >>> + block of objects. >>> + Number of objects in the block depends on how many objects fit in >>> + RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option. >>> + The number may be obtained using rte_mempool_ops_get_info() API. >>> + Contiguous blocks may be allocated using rte_mempool_get_contig_blocks() API. > Please add this feature at the beginning of the list (as the first one). Will do in v4 > If possible, I would prefer you rebase on top of the mainline > (looks to be next-net here). Yes, that's right. Will do in v4. > Thanks and sorry for nit-picking, I'm testing your stamina :) You're welcome. Thanks for review notes. Andrew.