From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Asaf Penso <asafp@mellanox.com>, dev@dpdk.org
Cc: viacheslavo@mellanox.com, matan@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: set default queue indices
Date: Wed, 15 Apr 2020 09:34:56 +0200 [thread overview]
Message-ID: <c2388a4a-49f3-6d7f-8d56-472a01758998@redhat.com> (raw)
In-Reply-To: <1584985813-14883-1-git-send-email-asafp@mellanox.com>
Hi Asaf,
On 3/23/20 6:50 PM, Asaf Penso wrote:
> The rte_vhost_get_vring_base function is being called to get the values
> of last_avail_idx and last_used_idx.
> These fields will not have the correct values in case the function
> returns an error.
>
> Adding a check for the function return value, and in the case of an
> error, set the fields to be zero and print a warning message.
Fixes tag is missing here.
I will add it while merging:
Fixes: bff735011078 ("vdpa/mlx5: prepare virtio queues")
> Signed-off-by: Asaf Penso <asafp@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-04-15 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 17:50 Asaf Penso
2020-04-15 7:34 ` Maxime Coquelin [this message]
2020-04-15 11:52 ` Asaf Penso
2020-04-17 17:14 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2388a4a-49f3-6d7f-8d56-472a01758998@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=asafp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).