From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24ABEA0C45; Wed, 22 Sep 2021 08:39:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB2954003F; Wed, 22 Sep 2021 08:39:51 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 5F87B4003C for ; Wed, 22 Sep 2021 08:39:50 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 976637F50B; Wed, 22 Sep 2021 09:39:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 976637F50B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1632292789; bh=5zCH0X2pi3/8G+k4V/P6IijXIPl6V+u3iIKdBjhuAVg=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=LAeQCuwGzT8E2EfU1KNXHxl5OBlggEBU1Zlom6P4IK6dl0fCUpAVcWJSbT7tn1Hb3 UO6+SXNuAkfccOGVKXJQkkg+PJRagSEexdd7E4Yb2NEIvglN6syDkvBqhFGzxhym6e hs9lNHrlBZV7+WzGJezI7RR3zzpSkxeMxmf10O94= To: "Min Hu (Connor)" , dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net References: <20210922033630.41130-1-humin29@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Wed, 22 Sep 2021 09:39:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210922033630.41130-1-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/21 6:36 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Use the testpmd to perform the following operations: > 1) mac_addr add 0 00:18:2D:00:00:90 > 2) mac_addr add 0 00:18:2D:00:00:91 > 3) mac_addr add 0 00:18:2D:00:00:92 > 4) mac_addr set 0 00:18:2D:00:00:91 > 5) show port 0 macs > Number of MAC address added: 4 > 00:18:2D:00:00:91 > 00:18:2D:00:00:90 > 00:18:2D:00:00:91 > 00:18:2D:00:00:92 > > This is due to the reason that if the address has been added as a > non-default MAC address by rte_eth_dev_mac_addr_add API, it doesn't remove > from dev->data->mac_addrs[] when set default MAC address with the same > address. > > Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > --- > lib/ethdev/rte_ethdev.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index daf5ca9242..77657a3314 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -4360,6 +4360,7 @@ int > rte_eth_dev_default_mac_addr_set(uint16_t port_id, struct rte_ether_addr *addr) > { > struct rte_eth_dev *dev; > + int index; > int ret; > > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > @@ -4381,6 +4382,20 @@ rte_eth_dev_default_mac_addr_set(uint16_t port_id, struct rte_ether_addr *addr) > if (ret < 0) > return ret; > > + /* > + * If the address has been added as a non-default MAC address by > + * rte_eth_dev_mac_addr_add API, it should be removed from > + * dev->data->mac_addrs[]. > + */ > + index = eth_dev_get_mac_addr_index(port_id, addr); > + if (index > 0) { > + /* remove address in NIC data structure */ > + rte_ether_addr_copy(&null_mac_addr, > + &dev->data->mac_addrs[index]); > + /* reset pool bitmap */ > + dev->data->mac_pool_sel[index] = 0; > + } > + > /* Update default address in NIC data structure */ > rte_ether_addr_copy(addr, &dev->data->mac_addrs[0]); > > If I change default MAC to something else later, should the old default MAC be returned to some specific pools? I guess it is hard to do. If the change is accepted, the behaviour must be documented in rte_eth_dev_default_mac_addr_set() description.