From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81ECFA04C8; Fri, 18 Sep 2020 19:23:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A8B21DAE9; Fri, 18 Sep 2020 19:23:54 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id F07B01D533 for ; Fri, 18 Sep 2020 19:23:51 +0200 (CEST) IronPort-SDR: RHwFPi7igbmrzBn8zD/4fEujhiLsz8xRA9l5Rj9RDjXiL+yxII1+zcAIb9IIH1KxV+BXvgewtU bw732dEK/sDw== X-IronPort-AV: E=McAfee;i="6000,8403,9748"; a="221561561" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="221561561" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 10:23:49 -0700 IronPort-SDR: Z5X2AOSMsWHsudd36R0Vg8HsVcvbEFdq+wygWg8Xn6vSbbSFVJzNEUrSPOUxfME+A/6xvPEvXD DU5bWIxZqdNg== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484286894" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.248]) ([10.213.227.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 10:23:42 -0700 To: i.dyukov@samsung.com, dev@dpdk.org, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> From: Ferruh Yigit Message-ID: Date: Fri, 18 Sep 2020 18:23:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v11 00/24] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/2020 8:06 PM, Ivan Dyukov wrote: <...> > > v11 changes: > * 0 Mbps => None > * Invalid speed => Invalid > * Change code style of rte_eth_link_speed_to_str > > v10 changes: > * remove format string arg from rte_eth_link_to_str function > * add rte_eth_link_speed_to_str function > * add usage of rte_eth_link_speed_to_str in examples > > v9 changes: > * remove rte_eth_link_printf function > * add ETH_LINK_MAX_STR_LEN definition > * add usage of ETH_LINK_MAX_STR_LEN in examples > > v8 changes: > * rename rte_eth_link_strf to rte_eth_link_to_str > * refactor rte_eth_link_to_str according to review comments > * fix codestyle > * fix commit message in 02 patch > * fix compile error in ntb application > * merge "app" and "doc" commits > > v7 changes: > * fix meson build > * change _strf function. now it does not fails in case of unknown specifiers like %d. it just copy it to target string. > * remove invalid_fmt unit test. > * add unknown specifier test. > * fix codestyle > > v6 changes: > * fix spelling in comments according to checkpatch warning > > v5 changes: > * rename rte_eth_link_format to rte_eth_link_strf > * add '\n' to default strings > * update remaining examples. patch with subj 'examples: new link status print format' contains examples which have no maintainers. > TBD: > update remaining nic drivers with 'unknown' speed. It should be provided in separate patchset. > > v4 changes: > * refactor rte_eth_link_format using strlcat func instead of snprintf > * added new checks to unit tests > * few minor fixes according review comments > TBD: > update examples in 'example' folder with new status printing mechanism > update remaining nic drivers with 'unknown' speed > > v3 changes: > * remove rte_eth_link_prepare_text function > * add rte_eth_link_format and rte_eth_link_printf functions > * added unit tests for rte_eth_link_format function > TBD: > update examples in 'example' folder with new status printing mechanism > update remaining nic drivers with 'unknown' speed > > v2 changes: > * add function which format link status to textual representation > * update drivers for Intel nics with 'unknown' speed > TBD: > update examples in 'example' folder with new status printing mechanism > update remaining nic drivers with 'unknown' speed > > v1 changes: > This is initial patchset which introduces UNKNOWN speed to dpdk > applications. Also it contains changes related to printf formating. > Patchset contains changes for app/ and doc/ folders. > examples/ folder will be provided later. > > The ethdev patch introduces 'ETH_SPEED_NUM_UNKNOWN' and driver patches were already merged from previous version. Will get the remaining ones.